Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2388
See https://issues.apache.org/jira/browse/STORM-2607
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2380
+1, good work.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147053713
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147050615
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2387
Looks like 1.1.x branch also needs the patch, and that branch shouldn't be
on top of STORM-2781.
https://github.com/apache/storm/blob/1.1.x-branch/external/storm-kafka-client/src/main/java/or
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147050462
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit() {
priva
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/2389
Storm heartbeats promotion
Storm now doesn't support large cluster[ for example thousand of
supervisors] very well, for our production, topology submission/killing is very
ineffective when cluste
GitHub user liujkang opened a pull request:
https://github.com/apache/storm/pull/2388
storm-kafka-client 1.1.1lag still is 1
when i use storm-kafka-client kafkaspout to consume message,
still has 1 message
[http://note.youdao.com/yws/public/resource/93a58cfe26d2c6f9f9
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147026299
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit() {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147025782
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsFor
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147025420
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsFor
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147022902
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147016997
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015438
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015407
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015173
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147014032
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit() {
priva
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013717
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -255,26 +255,25 @@ private void throwKafkaConsumerInter
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013620
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -125,8 +125,8 @@ public void open(Map conf,
TopologyCo
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013385
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013419
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012506
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012486
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012458
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012467
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2383
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2382
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146997432
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146997051
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146996955
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146996683
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2385
@govind-menon why is YSTORM-2725 prefixed by Y? Should it be STORM-2725? If
so, can you please fix the typo. Thanks.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2384
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2386
I don't know why the storm-core is waiting for so long and not yet started.
https://travis-ci.org/apache/storm/builds/292621349
However, the build on my repo
https://travis-ci.org/Ethan
Hello,
Is it hard to change jps process name of apache storm UI? I have noticed
that in my system with storm 1.1.0 it has a definetly nonunique and cryptic
name 'core'.
Best,
Vladimir Protsenko
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2387
+1 for the change. It might be good to add a test that demonstrates the fix
as well if possible.
---
37 matches
Mail list logo