Re: [Discuss] Release Storm 1.2.0

I agree with Jungtaek, if metrics v2 can go in very soon it should go in, otherwise I'd rather release 1.2.0 now and work on getting 2.0.0 ready for release. 1.x and master have drifted pretty far apart, and it's causing a lot of porting work at this point. 1.x still has a lot of Clojure code,

Re: [Discuss] Release Storm 1.2.0

Hi Taylor, Is it https://github.com/apache/storm/pull/2203 ? I think it would be great to get this in 1.2 release. Can we try to address the issues in a week or so and get this in? Thanks, Arun On 11/17/17, 7:13 AM, "P. Taylor Goetz" wrote: >The original idea for the 1.2

Re: [Discuss] Release Storm 1.2.0

We already initiated a discussion for 1.1.2 and 1.2.0 at several months ago, and given that serious patches for storm-kafka-client are only in 1.2.0 because of heavy diverging of branches, I rather not wait for issues which don't have due date. I also don't want to have 1.3.0 and just let us

Re: [Discuss] Release Storm 1.2.0

The original idea for the 1.2 release was that would introduce the metrics v2 work (and there is additional work required there, so I understand a desire not to delay the release). Do we want to stick with that, or deviate? If the latter, would we do a 1.3 release for metrics? As far as a

[GitHub] storm issue #2409: STORM-2796: Flux: Provide means for invoking static facto...

Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2409 I am ok with handling the property limitation in a separate issue. Perhaps we could document what is not yet supported and open a jira for it. ---

[GitHub] storm pull request #2424: [STORM-2820] fix validateTopologyWorkerMaxHeapSize...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2424 ---

[GitHub] storm issue #2419: STORM-2805: Clean up confs in TopologyBuilders

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2419 @srdo I think I have addressed all of your comments. I also found a few places were an NPE could happen, and one where the TopologyBuilder was not setting the resource configs correctly. I fixed

[GitHub] storm issue #2409: STORM-2796: Flux: Provide means for invoking static facto...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2409 @roshannaik See latest commit. I merged/fixed your patch. Most of the issues were typos (e.g. "refList" != "reflist"). The other issue was that properties in flux do not (currently) support

[GitHub] storm issue #2409: STORM-2796: Flux: Provide means for invoking static facto...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2409 @HeartSaVioR Yes, I will add assertions, although the tests would still fail without them (the constructor/method won't be found and a IllegalArgumentException will be thrown). @roshannaik

[GitHub] storm pull request #2425: [STORM-2815] UI HTTP server should return 403 if t...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2425 ---

[GitHub] storm pull request #2419: STORM-2805: Clean up confs in TopologyBuilders

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2419#discussion_r151444918 --- Diff: storm-client/src/jvm/org/apache/storm/drpc/LinearDRPCTopologyBuilder.java --- @@ -53,12 +53,12 @@ // Trident subsumes the functionality

[GitHub] storm pull request #2419: STORM-2805: Clean up confs in TopologyBuilders

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2419#discussion_r151444375 --- Diff: storm-client/src/jvm/org/apache/storm/coordination/BatchSubtopologyBuilder.java --- @@ -84,24 +84,24 @@ private BoltDeclarer setBolt(String id,

[GitHub] storm issue #2425: [STORM-2815] UI HTTP server should return 403 if the user...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2425 @HeartSaVioR This is for https://github.com/apache/storm/pull/2421/files for 1.x-branch. Could you review it? Thanks ---

[GitHub] storm pull request #2425: [STORM-2815] UI HTTP server should return 403 if t...

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2425 [STORM-2815] UI HTTP server should return 403 if the user is unauthorized (1.x) Portback of https://github.com/apache/storm/pull/2421 You can merge this pull request into a Git repository by

[GitHub] storm issue #2319: [STORM-2693] Nimbus assignments promotion

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2319 @danny0405 Yes right. Thank you for your patience and understanding the policy of Storm contribution. ---

[GitHub] storm issue #2319: [STORM-2693] Nimbus assignments promotion

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2319 @HeartSaVioR ok, i will do the 2.0.0 version, the promotion is running on our production cluster for a while and it works great, i will start to work on the 2.0.0 branch now, is the master branch