Re: [DISCUSS] Drop standalone mode of Storm SQL

2017-12-05 Thread Jungtaek Lim
Received 4 +1 binding and 1 +1 non-binding in a day, which looks consensus has been made. I will skip voting process and go ahead since Storm SQL is experimental. I'm filing issue here https://issues.apache.org/jira/browse/STORM-2845 Thanks for participating! 2017년 12월 6일 (수) 오후 12:40, Xin Wang

Re: [DISCUSS] Drop standalone mode of Storm SQL

2017-12-05 Thread Xin Wang
+1 - Xin 2017-12-06 7:14 GMT+08:00 Hugo Da Cruz Louro : > +1. It would just be good that once you move onto streams API this is easy > to test. It is highly important that we can quickly run simple tests form > the CLI and IDE. Without that it is very hard to fix bugs, test new > features during

Re: [DISCUSS] Drop standalone mode of Storm SQL

2017-12-05 Thread Hugo Da Cruz Louro
+1. It would just be good that once you move onto streams API this is easy to test. It is highly important that we can quickly run simple tests form the CLI and IDE. Without that it is very hard to fix bugs, test new features during early developments, and come up with ways to reproduce users po

Re: [DISCUSS] Drop standalone mode of Storm SQL

2017-12-05 Thread Jungtaek Lim
Arun and Priyank, Yes that's how we have been having tests with trident mode, and same applies on moving on streams API. Btw, it doesn't mean we provide users to execute SQL in local cluster mode. Maybe good to have that CLI feature. Given that we've 3 +1 (binding) including me and 1 +1 (non-bind

Re: [Discuss] Release Storm 1.2.0

2017-12-05 Thread Hugo Da Cruz Louro
@Arun, there is also this STORM-2844 I just filled. I am working on a and and will discuss in the JIRA potential solutions because this bug was introduced while fixing STORM-2666. Thanks, Hugo

Re: [DISCUSS] Drop standalone mode of Storm SQL

2017-12-05 Thread P. Taylor Goetz
+1 -Taylor > On Dec 5, 2017, at 2:09 PM, Priyank Shah wrote: > > +1 (NB). As Arun mentioned, it will be good to run test it by running > topologies in local mode. > > On 12/5/17, 10:07 AM, "Arun Iyer on behalf of Arun Mahadevan" > wrote: > >+1, I don’t see much use for standalone mode

Re: [DISCUSS] Drop standalone mode of Storm SQL

2017-12-05 Thread Priyank Shah
+1 (NB). As Arun mentioned, it will be good to run test it by running topologies in local mode. On 12/5/17, 10:07 AM, "Arun Iyer on behalf of Arun Mahadevan" wrote: +1, I don’t see much use for standalone mode other than for testing. Assume we can use the storm-sql in local mode

Re: [Discuss] Release Storm 1.2.0

2017-12-05 Thread Arun Mahadevan
Looks like now we are only waiting on below Kafka spout issues : https://github.com/apache/storm/pull/2428 https://github.com/apache/storm/pull/2438 Maybe we should include the metrics changes as well? https://github.com/apache/storm/pull/2203 Can we try to get the above merged ASAP and start

Re: [DISCUSS] Drop standalone mode of Storm SQL

2017-12-05 Thread Arun Mahadevan
+1, I don’t see much use for standalone mode other than for testing. Assume we can use the storm-sql in local mode to run topologies locally without deploying to cluster ? Thanks, Arun On 12/4/17, 10:53 PM, "Jungtaek Lim" wrote: >Hi devs, > >We have been exposing "standalone mode" of St

[GitHub] storm issue #2438: STORM-2835: storm-kafka-client KafkaSpout can fail to rem...

2017-12-05 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2438 +1 ---

[GitHub] storm pull request #2438: STORM-2835: storm-kafka-client KafkaSpout can fail...

2017-12-05 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2438#discussion_r155007745 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -242,9 +242,7 @@ public void nextTuple() {

[GitHub] storm pull request #2446: STORM-2843: [Flux] properties file not found when ...

2017-12-05 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/2446 STORM-2843: [Flux] properties file not found when loading resources... …from classpath STORM-2843 for 1.x-branch https://issues.apache.org/jira/browse/STORM-2843 You can merge th

[GitHub] storm pull request #2445: STORM-2843: [Flux] properties file not found when ...

2017-12-05 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/2445 STORM-2843: [Flux] properties file not found when loading resources... …from classpath You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/

[GitHub] storm issue #2440: STORM-2784: storm-kafka-client KafkaTupleListener method ...

2017-12-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2440 Thanks @hmcl I merged this into 1.x-branch again. ---

[GitHub] storm pull request #2444: STORM-2842: Fixed links for YARN&Kubernetes Integr...

2017-12-05 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/2444 STORM-2842: Fixed links for YARN&Kubernetes Integration This is very minor change. Fixed links for YARN&Kubernetes Integration. You can merge this pull request into a Git repository by running:

[GitHub] storm pull request #2440: STORM-2784: storm-kafka-client KafkaTupleListener ...

2017-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2440 ---