[GitHub] storm pull request #2661: [STORM-3055] remove conext connection cache

2018-05-04 Thread pczb
GitHub user pczb opened a pull request: https://github.com/apache/storm/pull/2661 [STORM-3055] remove conext connection cache worker has already cache connection use supervisor_id + port and if context and worker both cache the can be some problem describe in jira You can

[GitHub] storm issue #2657: STORM-3048 : A Potential NPE

2018-05-04 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2657 I am getting a failure now of ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on project storm-server: You have 792 Checkstyle

[GitHub] storm pull request #2658: Storm 2171: Removing LocalFsBlobStore specific Nim...

2018-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2658 ---

[GitHub] storm pull request #2657: STORM-3048 : A Potential NPE

2018-05-04 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2657#discussion_r186169192 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java --- @@ -98,6 +98,7 @@ public

[GitHub] storm pull request #2657: STORM-3048 : A Potential NPE

2018-05-04 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2657#discussion_r186169251 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java --- @@ -135,6 +136,7 @@

[GitHub] storm pull request #2657: STORM-3048 : A Potential NPE

2018-05-04 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2657#discussion_r186173164 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java --- @@ -98,6 +98,7 @@ public

[GitHub] storm pull request #2657: STORM-3048 : A Potential NPE

2018-05-04 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2657#discussion_r186169276 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java --- @@ -173,6 +175,7 @@

Re: [VOTE] Release Apache Storm 1.1.3 (rc1)

2018-05-04 Thread Bobby Evans
+1 I built from the git tag, ran all of the unit tests launched a single node cluster and ran a few simple tests on it. On Thu, May 3, 2018 at 12:21 PM P. Taylor Goetz wrote: > This is a call to vote on releasing Apache Storm 1.1.3 (rc1) > > Full list of changes in this

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

2018-05-04 Thread Bobby Evans
+1 I built it from the tag (e001672cf0ea59fe6989b563fb6bbb450fe8e7e5) since the tag did move recently. I ran all the unit tests, I started a single node cluster and ran some manual tests. Thanks, Bobby On Thu, May 3, 2018 at 12:18 PM P. Taylor Goetz wrote: > CORRECTION:

[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port

2018-05-04 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2660 @ghajos Can you tell me how you tested your patch ? ---

[GitHub] storm issue #2647: STORM-3040: Improve scheduler performance

2018-05-04 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2647 @danny0405 In my tests `TestResourceAwareScheduler.testLargeTopologiesCommon` went from about 7 mins to about 7 seconds. For `TestResourceAwareScheduler.testLargeTopologiesOnLargeClustersGras` I

[GitHub] storm issue #2659: STORM-3042 restore topology.acker.cpu.pcore.percent

2018-05-04 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2659 @Ethanlm - updated the issues you mentioned. ---

[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port

2018-05-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2660 @ghajos Thanks for the information. I didn't recognize the fact that the new test is passing without #2643. I agree this is out of scope, just think that if the new test can verify the new

[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port

2018-05-04 Thread ghajos
Github user ghajos commented on the issue: https://github.com/apache/storm/pull/2660 @raghavgautam Thanks for the quick reaction! Unfortunately the newly introduced test passes without #2643, so it does not test the original issue. Since in this modification both the server