Hi devs,
I hopefully have a time to sort out issues regarding Storm 2.0.0 and link
to epic issue.
https://issues.apache.org/jira/browse/STORM-2714
(require login to Apache JIRA to see issues in epic)
I guess we are close to the release, mostly left reviewing some pending
pull requests, and some
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2744#discussion_r201218268
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/Values.java ---
@@ -23,9 +23,13 @@ public Values() {
}
public Values(Object.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2747#discussion_r201216094
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -109,6 +133,7 @@ public void printCliHelp(String command, PrintStream
out
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2660
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2746
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2753
---
Github user aniketalhat closed the pull request at:
https://github.com/apache/storm/pull/2755
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@HeartSaVioR I have already attach the test data in the comment, also a
test class everyone can have a test.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2755
@aniketalhat Thanks for the fix. I cherry picked the changes to master, 1.x
and 1.1.x. Could you please close this PR, as the changes have been merged?
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2753
I have manually test against a few cases and they seems to be fine. I don't
know how much more rigorous I should test on but judging from the context the
change is pretty much self explanatory. Sh
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2633
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2710
Could you please rebase? I'm expecting the code diff would be reduced after
that.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2756
Thanks @choojoyq, merged.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2756
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2744
@revans2 @HeartSaVioR Now constructor allows `null` values.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2746#discussion_r201149188
--- Diff:
integration-test/src/main/java/org/apache/storm/st/topology/window/TimeDataIncrementingSpout.java
---
@@ -0,0 +1,64 @@
+/*
+ * Copyright 2018
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2739
@zd-project No it is good to merge. Just merged.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2739
---
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2746#discussion_r201144238
--- Diff:
integration-test/src/main/java/org/apache/storm/st/topology/window/TimeDataIncrementingSpout.java
---
@@ -0,0 +1,64 @@
+/*
+ * Copyrig
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2753
The code looks good to me. Is this manually tested with Logviewer UI? I'd
just want to check this to skip checking manually as I'm reviewing bunch of PRs
at once.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
I'd like to say it doesn't mean I don't plan to review this. I'd rather say
other issues which are directly coupled with releases (mostly Storm 2.0.0)
should be reviewed prior to this, unless you
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405
Could you address @revans2 comment, mostly backing up your proposed patch
with numbers? You may want to get help to correctly measure numbers from
well-known library like JMH.
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Looks like StormMetricRegistry has already had filtering by daemon type
feature that we need. It also supports report at different intervals and such.
Apart from the injection suggestion, do you t
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2756
Got it, thanks for the answer.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Dropwizard Metrics seems to have
[MetricFilter](https://metrics.dropwizard.io/3.1.0/apidocs/com/codahale/metrics/MetricFilter.html)
built-in. I think we can leverage so for filtering out unwanted
Greetings, Apache software enthusiasts!
(You’re getting this because you’re on one or more dev@ or users@ lists
for some Apache Software Foundation project.)
ApacheCon North America, in Montreal, is now just 80 days away, and
early bird prices end in just two weeks - on July 21. Prices will b
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2756
+1
Yes, likely. There's no reason people can't just upgrade to 1.1.x/1.2.x
instead, and it's adding a bunch of work for us to have to keep backporting to
old branches.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2756#discussion_r200972001
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -80,22 +81,24 @@ public void refresh() {
List mine =
K
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2756
base branch is changed to ``1.1.x-branch``. Am i understand correctly that
the last release version of 1.0.x-branch was 1.0.6 and newer version will never
be released?
---
Github user choojoyq commented on a diff in the pull request:
https://github.com/apache/storm/pull/2756#discussion_r200964011
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -80,22 +81,24 @@ public void refresh() {
List mine
Github user choojoyq commented on a diff in the pull request:
https://github.com/apache/storm/pull/2756#discussion_r200963984
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -80,22 +81,24 @@ public void refresh() {
List mine
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2755
Oops, yes. Jungtaek is right, I don't think we're working on 1.0.x anymore.
The changes look good to me. +1. I'll try cherry-picking these changes to
master, 1.x and 1.1.x in a bit.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2755#discussion_r200959509
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java
---
@@ -54,8 +57,12 @@ public NamedTopicFilter(String...
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2590
@srdo
I'm sorry but could you please rebase this? Thanks in advance!
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2755
While this PR is based on 1.0.x-branch since the branch is baed on that
branch, I guess we wouldn't want to maintain 1.0.x-branch any more. We would be
better to cherry pick squashed commit into
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2756
Could you please point this to at least 1.1.x-branch? We are trying to
maintain 3 version lines and due to this, 1.0.x version is no longer supported.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2652
@srdo
The patch wasn't applied to 1.x-branch cleanly. Could you please raise a PR
for 1.x-branch as well? Thanks in advance!
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2652
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2443
@srdo
Yeah, thanks for reminding this.
Applying the change manually again would be easier than rebasing, since
there were nice efforts on storm-sql (checkstyle violation reduction,
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2650
---
40 matches
Mail list logo
