Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2745
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2745
Fixed.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2745
Yes, the thread is still interrupted after the exception is thrown. I'll
change it to use `interrupted` instead.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2745
Sorry I don't think I submitted my nit. We are calling `isInterrupted` in
asyncLoop. Is this going to leave the state of the thread as interrupted after
we throw the exception.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2750
---
+1 would love to try it when an RC is avail!
Alexandre Vermeerbergen
2018-07-10 21:15 GMT+02:00 Arun Mahadevan :
> +1 to get it out soon.
>
>
>
>
> On 7/10/18, 11:52 AM, "P. Taylor Goetz" wrote:
>
>>+1 Sounds good to me.
>>
>>-Taylor
>>
>>> On Jul 10, 2018, at 2:18 AM, Jungtaek Lim wrote:
>>>
>
+1 to get it out soon.
On 7/10/18, 11:52 AM, "P. Taylor Goetz" wrote:
>+1 Sounds good to me.
>
>-Taylor
>
>> On Jul 10, 2018, at 2:18 AM, Jungtaek Lim wrote:
>>
>> Hi devs,
>>
>> I hopefully have a time to sort out issues regarding Storm 2.0.0 and link
>> to epic issue.
>>
>> https://issu
+1 Sounds good to me.
-Taylor
> On Jul 10, 2018, at 2:18 AM, Jungtaek Lim wrote:
>
> Hi devs,
>
> I hopefully have a time to sort out issues regarding Storm 2.0.0 and link
> to epic issue.
>
> https://issues.apache.org/jira/browse/STORM-2714
> (require login to Apache JIRA to see issues in ep
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r201455774
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -781,7 +781,7 @@ private static SerializationDelegate
getSerializationDelegate(Map
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2759
Will squash commits before merge, didn't want to mix them up in case this
should be split into smaller PRs.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2759
STORM-2947: Remove some deprecated methods from Storm 2.0.0.
This handles some of the deprecated things mentioned in STORM-2947.
There'll probably be followups to this PR to remove more functionality,
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2710
I'm kind of wondering whether decorator pattern is better than subclassing
or not, for TimedPortAndAssignment, because itself is already a wrapper.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2747
@agresch @HeartSaVioR I added in the docs, and also updated the docs for a
few other missing commands.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2747#discussion_r201400787
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -109,6 +133,7 @@ public void printCliHelp(String command, PrintStream
out) {
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2710
Rebase completed with one new commit added. The new
TimerDecoratedAssignment is incorporated.
---
Sounds good to me. The list in JIRA also looks fine to me.
It might make sense to get https://github.com/apache/storm/pull/2443 in
before doing https://issues.apache.org/jira/browse/STORM-2972, so the first
might effectively block removing storm-kafka.
I think even if we can't remove everything l
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2590
@HeartSaVioR Rebased.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2758
STORM-3046: Ensure KafkaTridentSpoutEmitter handles empty batches corâ¦
â¦rectly when they occur at the beginning of the stream
1.x version of https://github.com/apache/storm/pull/2652. The t
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2757
STORM-3013: Keep KafkaConsumer open when storm-kafka-client spout is â¦
â¦deactivated, in order to keep metrics working
1.x version of https://github.com/apache/storm/pull/2648
You can merge
19 matches
Mail list logo
