date:20181031

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread govind-menon

Github user govind-menon commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229883970 --- Diff: storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java --- @@ -414,6 +418,34 @@ public void validateInteger(String name, Objec

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread Ethanlm

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229880617 --- Diff: storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java --- @@ -414,6 +418,34 @@ public void validateInteger(String name, Object o)

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread Ethanlm

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229879326 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -607,6 +608,27 @@ protected String javaCmd(String cmd) {

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread Ethanlm

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229878430 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -607,6 +608,27 @@ protected String javaCmd(String cmd) {

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread Ethanlm

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229876743 --- Diff: storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java --- @@ -414,6 +418,34 @@ public void validateInteger(String name, Object o)

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread Ethanlm

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229875813 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -1041,6 +1041,24 @@ @isPositiveNumber @NotNull public static fin

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread govind-menon

Github user govind-menon commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229869065 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -622,22 +624,26 @@ public boolean areAllConnectionsReady() {

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread govind-menon

Github user govind-menon commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229854058 --- Diff: storm-server/src/test/java/org/apache/storm/daemon/supervisor/BasicContainerTest.java --- @@ -319,7 +319,15 @@ public void testLaunch() throw

[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

2018-10-31 Thread govind-menon

Github user govind-menon commented on a diff in the pull request: https://github.com/apache/storm/pull/2881#discussion_r229853904 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/normalization/NormalizedResourceOffer.java --- @@ -81,6 +81,20 @@ public void