[
https://issues.apache.org/jira/browse/STORM-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt reopened STORM-1347:
-
Accidentally closed.
> ui changes to display the topology vers
[
https://issues.apache.org/jira/browse/STORM-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt resolved STORM-1347.
-
Resolution: Fixed
> ui changes to display the topology vers
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/1353#issuecomment-213607240
@lujinhong Can you file a jira to make the move. I think I have a patch
lying around in my repo which brings some perf improvements in addition to
moving the
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-200564783
This PR has been open for a long time, i am still +1 and will merge this
this weekend if no one objects.
---
If your project is set up for it, you can reply to
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/1188#issuecomment-199499535
@harshach fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/1188#issuecomment-199434354
@harshach will update tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/1188
STORM-1604:Delayed transition should handle NotALeaderException
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt
Parth Brahmbhatt created STORM-1604:
---
Summary: Delayed transition should handle NotALeaderException
Key: STORM-1604
URL: https://issues.apache.org/jira/browse/STORM-1604
Project: Apache Storm
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/1144#issuecomment-188447027
@knusbaum I think we should. WE have see RejectedExecutionException on > 5
different customer clusters. I can backport this if others also agree.
---
If y
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/1145#issuecomment-187957776
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
+1 on DropWizard.
On 2/23/16, 2:02 PM, "Harsha" wrote:
>-1 on spring boot or anything related to spring.
>This api is intended to be very simple powering UI and any rest clients
>interested in grabbing the metrics from the same api as UI does.
>
>Jersey is good and dropwizard (http://www.dropwi
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/1144
STORM-1569: Adding option in nimbus to specify request queue size in â¦
â¦config.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Parth Brahmbhatt created STORM-1569:
---
Summary: Allowing users to specify the nimbus thrift server queue
size.
Key: STORM-1569
URL: https://issues.apache.org/jira/browse/STORM-1569
Project: Apache
[
https://issues.apache.org/jira/browse/STORM-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt resolved STORM-1147.
-
Resolution: Fixed
> Storm JDBCBolt should add validation to ensure either insertQuery
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/1101#issuecomment-183113689
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/STORM-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt resolved STORM-1521.
-
Resolution: Fixed
Fix Version/s: 2.0.0
> When using Kerberos login from key
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/1064#issuecomment-182478517
Not sure how i missed that you were creating a singleton :-). +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/1064#issuecomment-182469322
@dbahir Does the legacy provider take care of logging in only once
internally?
---
If your project is set up for it, you can reply to this email and have
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/991#issuecomment-173358421
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/991#issuecomment-173352336
I think you need to add this module to
incubator-storm/storm-dist/binary/src/main/assembly/binary.xml . I am +1 once
that is done.
---
If your project is set
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/994#issuecomment-173027654
We can either just include this as a warning as part of Release Notes or we
can roll this change back. I am fine with including just a Release Note to warn
all
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/963#issuecomment-172122588
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/STORM-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt resolved STORM-1199.
-
Resolution: Fixed
Fix Version/s: 1.0.0
> Create HDFS Sp
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/936#issuecomment-171777228
@roshannaik Thanks for the patch. I have merged this request to master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/939#issuecomment-170755274
@arunmahadevan I am still +1 but the up merge is failing for
storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java can you
please upmerge the last
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-167640073
closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Parth-Brahmbhatt closed the pull request at:
https://github.com/apache/storm/pull/387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/724#issuecomment-167639763
What jira is this associated with? I see some ip addresses in pom and even
looking at the change I cant understand what is this intending to do.
---
If your
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/980
STORM-1423: storm UI in a secure env shows error even when credentialâ¦
â¦s are present.
You can merge this pull request into a Git repository by running:
$ git pull https
Parth Brahmbhatt created STORM-1423:
---
Summary: storm UI in a secure env shows error even when
credentials are present
Key: STORM-1423
URL: https://issues.apache.org/jira/browse/STORM-1423
Project
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/939#issuecomment-166698659
@arunmahadevan Thanks for the patch. I think the missing piece is the
how-to-use guide. you can file a follow up jira for that. Overall looks good to
me and
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r48282204
--- Diff: storm-core/src/jvm/backtype/storm/spout/CheckpointSpout.java ---
@@ -0,0 +1,280 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r48280341
--- Diff: storm-core/src/jvm/backtype/storm/spout/CheckpointSpout.java ---
@@ -0,0 +1,280 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r48279728
--- Diff: storm-core/src/jvm/backtype/storm/spout/CheckpointSpout.java ---
@@ -0,0 +1,280 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r48279460
--- Diff: storm-core/src/jvm/backtype/storm/spout/CheckpointSpout.java ---
@@ -0,0 +1,280 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r48279308
--- Diff: storm-core/src/jvm/backtype/storm/spout/CheckPointState.java ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-164586572
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/900#issuecomment-164565516
Overall I am +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/900#discussion_r47559536
--- Diff:
storm-core/src/jvm/backtype/storm/windowing/WaterMarkEventGenerator.java ---
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/900#discussion_r47557478
--- Diff: docs/documentation/Windowing.md ---
@@ -126,6 +126,96 @@ Time duration based tumbling window that tumbles after
the specified time durati
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/938#issuecomment-163715625
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/935
STORM-1381:Adding client side submission hook along with LocalClusterâ¦
⦠changes to run tets.
Conflicts:
storm-core/src/jvm/backtype/storm/Config.java
Topology
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/935#issuecomment-163088677
the local cluster changes should be credited to @harshach
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Parth Brahmbhatt created STORM-1381:
---
Summary: Client side topology submission hook.
Key: STORM-1381
URL: https://issues.apache.org/jira/browse/STORM-1381
Project: Apache Storm
Issue Type
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-162580970
Still +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/919#issuecomment-162082605
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/922#issuecomment-162069596
@revans2 @unsleepy22 I did not know Jstorm has it and hasn't had a chance
to look at the dist cache.
My goal was to allow users to update topolo
[
https://issues.apache.org/jira/browse/STORM-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15040780#comment-15040780
]
Parth Brahmbhatt commented on STORM-1346:
-
Code available in
https://github
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/922
STORM-1345: UpdateTopology API and implementation.
No unit tests added. Update will allow to update config, jar (if some
dependency is updated without the topology changing in any way), or
Parth Brahmbhatt created STORM-1347:
---
Summary: ui changes to display the topology version.
Key: STORM-1347
URL: https://issues.apache.org/jira/browse/STORM-1347
Project: Apache Storm
Parth Brahmbhatt created STORM-1345:
---
Summary: Thrift, nimbus ,zookeeper, supervisor and worker changes
to support update topology.
Key: STORM-1345
URL: https://issues.apache.org/jira/browse/STORM-1345
Parth Brahmbhatt created STORM-1346:
---
Summary: upgrade topology CLI tool
Key: STORM-1346
URL: https://issues.apache.org/jira/browse/STORM-1346
Project: Apache Storm
Issue Type: Sub-task
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/884#issuecomment-158451109
I'm +1 too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/895#issuecomment-158230675
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/STORM-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011207#comment-15011207
]
Parth Brahmbhatt commented on STORM-1187:
-
[~arunmahadevan] Do you want to
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/884#issuecomment-157749683
Thanks for the contribution, any reason you decided to make this hook part
of serialized topology. If you see some other examples, like the nimbus hook
(though
[
https://issues.apache.org/jira/browse/STORM-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt resolved STORM-1098.
-
Resolution: Fixed
Fix Version/s: 0.11.0
> Storm Nimbus H
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/862#issuecomment-156209629
Venketesh did give some comments. I am going to merge this in given the
comments would not block them
---
If your project is set up for it, you can reply to
+1.
On 11/11/15, 2:27 PM, "Derek Dagit" wrote:
>+1
>
> --
>Derek
>
>
>- Original Message -
>From: P. Taylor Goetz
>To: dev@storm.apache.org
>Cc:
>Sent: Wednesday, November 11, 2015 4:21 PM
>Subject: [DISCUSS] 1.0 Release (was Re: [DISCUSS] Initial 0.11.0 Release)
>
>Changing subject i
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44373855
--- Diff:
storm-core/src/jvm/backtype/storm/nimbus/ITopologyActionNotifierPlugin.java ---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44373870
--- Diff:
storm-core/test/jvm/backtype/storm/nimbus/InMemoryTopologyAcitonNotifier.java
---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44373750
--- Diff:
storm-core/test/jvm/backtype/storm/nimbus/InMemoryTopologyAcitonNotifier.java
---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44373716
--- Diff:
storm-core/src/jvm/backtype/storm/nimbus/ITopologyActionNotifierPlugin.java ---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-155269316
overall I am +1, couple of clarifying questions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44365491
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44365442
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -87,7 +87,7 @@ public void prepare(Map conf
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44304729
--- Diff:
storm-core/test/jvm/backtype/storm/nimbus/InMemoryTopologyAcitonNotifier.java
---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/848#issuecomment-155133328
Hi, I am +1 on this patch. Sorry took me longer to review than I expected.
Thank a lot for your contributions.
---
If your project is set up for it, you can
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/865#discussion_r44204822
--- Diff: conf/storm.yaml.example ---
@@ -19,7 +19,7 @@
# - "server1"
# - "server2"
#
-#
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/862#issuecomment-154580884
Upmerged. I will merge the patch in once someone from Atlas team reviews
and confirms this is sufficient for them.
---
If your project is set up for it, you
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44189170
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -124,6 +124,8 @@
:id->sched-status (atom {})
:cred-renew
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44189187
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -814,6 +816,11 @@
(.assignSlots inimbus topologies
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/848#issuecomment-154464749
@zhuoliu Sorry I did partial review and then got distracted, give me
today's day and I will add more comments.
---
If your project is set up for it, yo
[
https://issues.apache.org/jira/browse/STORM-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992692#comment-14992692
]
Parth Brahmbhatt commented on STORM-1098:
-
[~svenkat] Give you are the repo
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/862
STORM-1098: Nimbus hook for topology actions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt/incubator-storm STORM
+1 for different targets.
Thanks
Parth
On 11/5/15, 11:40 AM, "Parth Brahmbhatt"
wrote:
>Our internal tests do things like that but as Harsha mentioned It is kind
>of tightly couple with our infra.
>
>I think if we can agree on using DuckTape (or some other framework) w
ply-To: Bobby Evans mailto:ev...@yahoo-inc.com>>
Date: Thursday, November 5, 2015 at 12:34 PM
To: Parth Brahmbhatt
mailto:pbrahmbh...@hortonworks.com>>,
"dev@storm.apache.org<mailto:dev@storm.apache.org>"
mailto:dev@storm.apache.org>>
Subject: Re: [Discusson] Stor
It will be good to add a basic test suite before 0.11 release at least to
test out things like HA where we should really have some chaos monkey
testing. From all the options I have seen/used duck tape seems to be the
best option as of now.
Thanks
Parth
On 11/5/15, 11:23 AM, "Bobby Evans" wrote:
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/848#discussion_r44042484
--- Diff: docs/documentation/ui-rest-api.md ---
@@ -172,6 +172,27 @@ Sample response:
}
```
+### /api/v1/history/summary (GET
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/848#discussion_r44042359
--- Diff: docs/documentation/ui-rest-api.md ---
@@ -172,6 +172,27 @@ Sample response:
}
```
+### /api/v1/history/summary (GET
[
https://issues.apache.org/jira/browse/STORM-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt reassigned STORM-1098:
---
Assignee: Parth Brahmbhatt (was: Sriharsha Chintalapani)
> Storm Nimbus H
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43940643
--- Diff: storm-core/src/jvm/backtype/storm/windowing/WindowManager.java ---
@@ -0,0 +1,210 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/854#issuecomment-153864538
I agree with @revans2 , lets maintain backward compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43933512
--- Diff:
storm-core/src/jvm/backtype/storm/topology/WindowedBoltExecutor.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43932253
--- Diff:
storm-core/src/jvm/backtype/storm/topology/base/BaseWindowedBolt.java ---
@@ -0,0 +1,184 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/854#issuecomment-153836316
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43922969
--- Diff: storm-core/src/jvm/backtype/storm/windowing/WindowManager.java ---
@@ -0,0 +1,210 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43918519
--- Diff:
storm-core/src/jvm/backtype/storm/topology/WindowedBoltExecutor.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43918998
--- Diff:
storm-core/src/jvm/backtype/storm/topology/base/BaseWindowedBolt.java ---
@@ -0,0 +1,184 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43918453
--- Diff:
storm-core/src/jvm/backtype/storm/topology/WindowedBoltExecutor.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed to the Apache Software
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43894940
--- Diff:
examples/storm-starter/src/jvm/storm/starter/SlidingWindowTopology.java ---
@@ -0,0 +1,129 @@
+/**
+ * Licensed to the Apache
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r43894593
--- Diff:
examples/storm-starter/src/jvm/storm/starter/SlidingWindowTopology.java ---
@@ -0,0 +1,129 @@
+/**
+ * Licensed to the Apache
+1
Tested locally.
On 10/29/15, 12:46 PM, "P. Taylor Goetz" wrote:
>+1 (binding)
>
>Ran a suite of fault tolerance tests.
>
>-Taylor
>
>> On Oct 23, 2015, at 4:26 PM, P. Taylor Goetz wrote:
>>
>> This is a call to vote on releasing Apache Storm 0.10.0 (rc1)
>>
>> Full list of changes in this
[
https://issues.apache.org/jira/browse/STORM-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981895#comment-14981895
]
Parth Brahmbhatt commented on STORM-1139:
-
You can post your question
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/831
STORM-1147: Added validation checks and tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt/incubator-storm STORM
Parth Brahmbhatt created STORM-1147:
---
Summary: Storm JDBCBolt should add validation to ensure either
insertQuery or table name is specified and not both.
Key: STORM-1147
URL: https://issues.apache.org/jira
+1.
On 10/27/15, 10:56 AM, "Bobby Evans" wrote:
>+1
>Apache is about community over code, and this should help to merge the
>two communities, at the cost of working through merging the two code
>bases.
> - Bobby
>
>
> On Tuesday, October 27, 2015 12:49 PM, P. Taylor Goetz
> wrote:
>
>
>
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/802#issuecomment-148763402
@revans2 The log concerns were from the origin PR that @danielschonfeld
which he has fixed but I guess he force pushed the branch. I am +1 on this
change too
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/802#issuecomment-148524703
lot of unnecessary log statements, can you remove them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/794#issuecomment-147019720
+1, good catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 404 matches
Mail list logo
