[GitHub] storm issue #1768: STORM-2194: Report error and die, not report error or die

2016-12-01 Thread chawco
Github user chawco commented on the issue: https://github.com/apache/storm/pull/1768 I've left some follow up comments in [1767](https://github.com/apache/storm/pull/1767). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-01 Thread chawco
Github user chawco commented on the issue: https://github.com/apache/storm/pull/1767 So, there's some ambiguity in place here that would need to get resolved. Basically, there's two sources for InterruptedException/InterruptedIOException -- one from Storm itself, and on

[GitHub] storm pull request #1768: STORM-2194: Report error and die, not report error...

2016-11-09 Thread chawco
GitHub user chawco opened a pull request: https://github.com/apache/storm/pull/1768 STORM-2194: Report error and die, not report error or die This appears to have just ported an existing bug from executor.clj -- this is what I believe the expected behaviour is/was. You can merge

[GitHub] storm pull request #1767: STORM-2194: Report error and die, not report error...

2016-11-09 Thread chawco
GitHub user chawco opened a pull request: https://github.com/apache/storm/pull/1767 STORM-2194: Report error and die, not report error or die We should still kill our executor after encountering an unhandled exception. This change logs what happens as before, but also ensures we

[GitHub] storm pull request: Include topic information with Kafka metrics

2015-03-19 Thread chawco
Github user chawco commented on the pull request: https://github.com/apache/storm/pull/470#issuecomment-83695774 I've amended the offending commit. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] storm pull request: Include topic information with Kafka metrics

2015-03-19 Thread chawco
Github user chawco commented on the pull request: https://github.com/apache/storm/pull/470#issuecomment-83682537 Sure thing, I've filed [STORM-713 ](https://issues.apache.org/jira/browse/STORM-713) for this issue. --- If your project is set up for it, you can reply to this emai

[GitHub] storm pull request: Include topic information with Kafka metrics

2015-03-19 Thread chawco
GitHub user chawco opened a pull request: https://github.com/apache/storm/pull/470 Include topic information with Kafka metrics Currently, Kafka metrics are emitted with partition information, but no information about which topic that partition belongs to. This patch includes the