[jira] [Commented] (STORM-738) Multilang needs Overflow-Control mechanism and HeartBeat timeout problem

2015-04-07 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482655#comment-14482655 ] DashengJu commented on STORM-738: - [~kabhwan] I have two questions about heartbeat

[GitHub] storm pull request: STORM-742 Let ShellBolt treat all messages to ...

2015-04-07 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/497#issuecomment-90392638 @HeartSaVioR We have tested the patch. It solved most of the problem, but it still exist in some cases. Currently, even with ACK, the subprocess

[GitHub] storm pull request: STORM-742 Let ShellBolt treat all messages to ...

2015-03-31 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/497#issuecomment-88300765 I checked the code again, my consideration will not happen, it will send heartbeat tuple every second. please ignore. --- If your project is set up for it, you can

[jira] [Commented] (STORM-738) Multilang needs Overflow-Control mechanism and HeartBeat timeout problem

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389942#comment-14389942 ] DashengJu commented on STORM-738: - Yes, It's more dangerous in OOM issue from OS. It affect

[jira] [Issue Comment Deleted] (STORM-738) Multilang needs Overflow-Control mechanism and HeartBeat timeout problem

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-738: Comment: was deleted (was: Yes, It's more dangerous in OOM issue from OS. It affect other normal topology

[jira] [Commented] (STORM-738) Multilang needs Overflow-Control mechanism and HeartBeat timeout problem

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389943#comment-14389943 ] DashengJu commented on STORM-738: - Yes, It's more dangerous in OOM issue from OS. It affect

[jira] [Issue Comment Deleted] (STORM-738) Multilang needs Overflow-Control mechanism and HeartBeat timeout problem

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-738: Comment: was deleted (was: Yes, It's more dangerous in OOM issue from OS. It affect other normal topology

[jira] [Commented] (STORM-738) Multilang needs Overflow-Control mechanism and HeartBeat timeout problem

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389941#comment-14389941 ] DashengJu commented on STORM-738: - Yes, It's more dangerous in OOM issue from OS. It affect

[jira] [Commented] (STORM-738) Multilang needs Overflow-Control mechanism and HeartBeat timeout problem

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389876#comment-14389876 ] DashengJu commented on STORM-738: - [~kabhwan] With normal JVM bolt, all tuples are cached

[GitHub] storm pull request: STORM-742 Let ShellBolt treat all messages to ...

2015-03-31 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/497#issuecomment-88300244 thanks for submit this patch quickly. we will test in our situation today. But i have another consideration: does this increase too many heartbeat msg

[jira] [Updated] (STORM-738) Multilang needs Overflow-Control and HeartBeat bug

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-738: Attachment: storm_multilang.png Multilang needs Overflow-Control and HeartBeat bug

[jira] [Updated] (STORM-738) Multilang needs Overflow-Control mechanism and HeartBeat timeout problem

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-738: Description: hi, all we have a topology, which have 3 components(spout-parser-saver) and the parser

[jira] [Created] (STORM-738) Multilang needs Overflow-Control and HeartBeat bug

2015-03-31 Thread DashengJu (JIRA)
DashengJu created STORM-738: --- Summary: Multilang needs Overflow-Control and HeartBeat bug Key: STORM-738 URL: https://issues.apache.org/jira/browse/STORM-738 Project: Apache Storm Issue Type: Bug

[jira] [Updated] (STORM-738) Multilang needs Overflow-Control and HeartBeat bug

2015-03-31 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-738: Description: hi, all we have a topology, which have 3 components(spout-parser-saver) and the parser

[GitHub] storm pull request: [storm-redis] Clarify Redis*StateUpdater's exp...

2015-03-26 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/488#issuecomment-86784079 nice, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381932#comment-14381932 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. [storm-redis

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381933#comment-14381933 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. [storm-redis

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381930#comment-14381930 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. [storm-redis

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381929#comment-14381929 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. [storm-redis

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381931#comment-14381931 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. [storm-redis

[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...

2015-03-26 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/481#issuecomment-86542208 @revans2 I think we should merge this PR to all branches. please help to review. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) [storm-redis] RedisStateSetUpdater writes

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) [storm-redis] RedisStateSetUpdater writes

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381926#comment-14381926 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. [storm-redis

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381925#comment-14381925 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. [storm-redis

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) [storm-redis] RedisStateSetUpdater writes

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) [storm-redis] RedisStateSetUpdater writes

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) [storm-redis] RedisStateSetUpdater writes

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) [storm-redis] RedisStateSetUpdater writes

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381941#comment-14381941 ] DashengJu commented on STORM-723: - good idea [storm-redis] RedisStateSetUpdater writes

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-25 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379364#comment-14379364 ] DashengJu commented on STORM-723: - [~kabhwan] I do not know what is the difference about

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-25 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379559#comment-14379559 ] DashengJu commented on STORM-723: - I think expiration of state is a important feature

[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...

2015-03-25 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/481#issuecomment-86294019 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-25 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86293223 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-25 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381221#comment-14381221 ] DashengJu commented on STORM-723: - Besides document expiration feature, shall we change

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-24 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379131#comment-14379131 ] DashengJu commented on STORM-723: - [~kabhwan] I checked the code, it was a bug to use

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2015-02-05 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-73170761 @HeartSaVioR , @ptgoetz I agree with committer sponsors only committers can join external's committer sponsors. I have changed the committer sponsors members

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2015-02-03 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-72795383 @harshach , ok, you or @HeartSaVioR should responsible for fix this bug, because I just know how to fix it in linux, but not in windows. thanks --- If your

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2015-01-20 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-70777681 @revans2 , I have added you to the committer. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: [STORM-607] storm-hbase HBaseMapState should s...

2015-01-05 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/364#issuecomment-68693496 @ptgoetz , can you help to review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2015-01-04 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68626207 @HeartSaVioR and I have added abstract bolt and trident state implementations, we also add some test cases, and modify the readme usage. Anyone can help review

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-31 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68431816 @harshach , we have added tests for both topology and trident. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-31 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68434697 @HeartSaVioR If JedisCommands is designed for single key operation, It is useful for RedisState, because we provide the JedisCommands interface to user

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-31 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68447314 The users of our trident state, they may have a redis or have a redis cluster. normally, they will not have both. When they have a redis, they want to use the Jedis

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-31 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68447798 may be support 1) 2) 4) is ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-31 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68449366 ok,I will add 2) 3) 4) those days. @HeartSaVioR Happy New Year :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-30 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68346400 @HeartSaVioR I have merged your PR, thanks. And I have added Apache licenses to all files. I have found JedisCommands interface suitable for trident state

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68244243 @darionyaphet , I think storm-redis can support redis and redis-cluster both. we can also add redis-sharding solution to trident state. @HeartSaVioR , yes, I

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68324052 @harshach , @Parth-Brahmbhatt , @HeartSaVioR I have implemented a few functions in current PR. As @HeartSaVioR says, it's better to collaborate with each

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68325551 @HeartSaVioR , ok , you can responsible for core storm bolt. And I will add more data types for trident state and unit tests. next time commit, I will add

[jira] [Created] (STORM-609) add storm-redis to storm external

2014-12-25 Thread DashengJu (JIRA)
DashengJu created STORM-609: --- Summary: add storm-redis to storm external Key: STORM-609 URL: https://issues.apache.org/jira/browse/STORM-609 Project: Apache Storm Issue Type: New Feature

does trident state HBaseMapState can privode transactional state on normal stream?

2014-12-10 Thread DashengJu
persistentAggregate(), why not support other interface than Snapshottable? I means why not support to persistent two field of the stream to hbase? thanks -- dashengju +86 13810875910 dashen...@gmail.com

[GitHub] storm pull request: [STORM-442] multilang ShellBolt/ShellSpout die...

2014-11-05 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/305#issuecomment-61774651 @clockfly I think it is not a good idea to kill sub process. Because when we catch a exception, we do not know whether sub process is still running. kill pid may

[GitHub] storm pull request: [STORM-442] multilang ShellBolt/ShellSpout die...

2014-11-02 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/305#issuecomment-61447792 @HeartSaVioR yes, there is a chance to occur that subprocess writes stderr for some reason but parent process runs well without Exception. When this happens

[GitHub] storm pull request: [STORM-442] multilang ShellBolt/ShellSpout die...

2014-10-29 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/218#issuecomment-61038451 @HeartSaVioR , parent process's exception contains two types: 1) net io error caused; for example, subprocess report an error to stderr and exit; 2) parent

Re: 答复: apache-storm-0.9.3-rc1 do not have lib: zookeeper and netty

2014-10-27 Thread DashengJu
thanks On Tue, Oct 28, 2014 at 12:05 PM, 翟玉勇[技术中心] scott.z...@vipshop.com wrote: Hi, Is right,all the zookeeper and netty classes package into storm-core jar -邮件原件- 发件人: DashengJu [mailto:dashen...@gmail.com] 发送时间: 2014年10月28日 11:49 收件人: dev@storm.apache.org 主题: apache-storm