Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2930
@govind-menon
The CLI is not recognizing -c options are configuration parameters.
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2930
@govind-menon The `node-health-check` command is missing from `storm.py`
after this change.
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2931
@govind-menon Thank you for the patch.
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2925
@d2r Thank you for the fix and squashing the commits.
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2925#discussion_r240759867
--- Diff:
storm-client/src/jvm/org/apache/storm/dependency/DependencyUploader.java ---
@@ -154,11 +154,23 @@ private boolean
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2925#discussion_r240759159
--- Diff:
storm-client/src/jvm/org/apache/storm/dependency/DependencyUploader.java ---
@@ -154,11 +154,23 @@ private boolean
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2920#discussion_r239231045
--- Diff:
storm-server/src/main/java/org/apache/storm/metricstore/NimbusMetricProcessor.java
---
@@ -24,7 +24,7 @@
public void
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2917
@srdo There was no explicit issue. Just wanted to upgrade to latest on
jetty minor version
---
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2917
[STORM-3294] Upgrade jetty version to latest stable 9.4.14.v20181114 version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2908#discussion_r234019467
--- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
@@ -1197,8 +1238,9 @@ public IBolt makeAckerBoltImpl() {
* When
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2903
[STORM-3284]: Add inheritance to cgroups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm
add-cgroup
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2902#discussion_r231608903
--- Diff:
storm-server/src/main/java/org/apache/storm/utils/ServerUtils.java ---
@@ -691,8 +691,10 @@ public static boolean isRAS(Map conf
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2902#discussion_r231580524
--- Diff:
storm-server/src/main/java/org/apache/storm/utils/ServerUtils.java ---
@@ -691,8 +691,10 @@ public static boolean isRAS(Map conf
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2902
The jenkins failure seems unrelated.
---
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2902
[STORM-3282] Fix RAS worker count estimation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm storm3282
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2895
[STORM-3275] Fix UIHelpers timeout while starting profiler
The Jprofiler start action, requires calculating timeout in milliseconds,
while input is in minutes. Also, the logic works to say
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2882
Travis-ci build failures seems unrelated to the changes.
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2882
@revans2 , ok, looking at output, I thought it was trying to output JSON
data. Thanks for the explanation.
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2882#discussion_r227061728
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -104,6 +115,164 @@ public void printCliHelp(String command, PrintStream
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2882#discussion_r227061218
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -104,6 +115,164 @@ public void printCliHelp(String command, PrintStream
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2882#discussion_r227061504
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -104,6 +115,164 @@ public void printCliHelp(String command, PrintStream
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2744#discussion_r225509252
--- Diff: storm-client/test/jvm/org/apache/storm/tuple/ValuesTest.java ---
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2744#discussion_r225509106
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/Values.java ---
@@ -23,9 +23,13 @@ public Values() {
}
public Values
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2878#discussion_r225502712
--- Diff: storm-core/src/jvm/org/apache/storm/command/KillTopology.java ---
@@ -25,21 +25,49 @@
public static void main(String[] args
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2878#discussion_r225358947
--- Diff: storm-core/src/jvm/org/apache/storm/command/KillTopology.java ---
@@ -25,21 +25,49 @@
public static void main(String[] args
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2871
> @kishorvpatil I am not sure if we want to swallow IOException, since it
may be due to some serious problem which we want to propagate and nimbus cannot
continue in that case.
Agreed.
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2876
[STORM-3254] Don't wait for localization of blobs if assignments change.
Delay in blobstore can cause slot to become unusable.
You can merge this pull request into a Git repository by ru
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2871#discussion_r224548982
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2871#discussion_r224538909
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2864
[STORM-3246]Use utf-8 charset to write log files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm
fix-logfile
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2855#discussion_r222100110
--- Diff:
storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java ---
@@ -106,13 +106,13 @@ public void run
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2855#discussion_r222091724
--- Diff:
storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java ---
@@ -106,13 +106,13 @@ public void run
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2852#discussion_r221288492
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2850,6 +2853,7 @@ public void launchServer() throws Exception
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2852#discussion_r221257606
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2850,6 +2853,7 @@ public void launchServer() throws Exception
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2850
[STORM-3235] Fix WorkerToken renewal criteria and refactor
- Fix broken condition to validate if new `WorkerToken` should be added.
- Refactor code out of `Nimbus` into `WorkerTokenManager
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2831
https://user-images.githubusercontent.com/6090397/45646222-afa9d500-ba90-11e8-9651-56b153e7ce42.png";>
@revans2 I fixed the position and removed duplicate space entries showi
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2831
OMG, my bad.. looks like the span tag is added twice. Let me fix it..
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2805
@revans2 Looks like we have few conflicts on this PR?
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218086663
--- Diff: storm-client/src/jvm/org/apache/storm/stats/ClientStatsUtil.java
---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2831
STORM-3224: Fix FLUX YAML Viewer icon location/position on UI page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2825
[STORM-3220] Allow ability to enable/disable http binding
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2814
[STORM-3207] Fix Sasl Plugin to use WorkerToken
The `doAsUser` is null for DRPCClient. If WorkerToken is found, it should
use it.
Also, setting on `addServerDefinition` to `localhost
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2744
@HeartSaVioR Removed unwanted condition.
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2744
@revans2 @HeartSaVioR Now constructor allows `null` values.
---
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2744
[STORM-3132] Avoid NPE in the Values Constructor
`Values` construction could end up throwing NPE.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2660
@raghavgautam Can you please address the merge conflicts?
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2718
Good catch @agresch
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2700#discussion_r192811084
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1333,6 +1336,21 @@ private AssignmentDistributionService
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2651
@HeartSaVioR @revans2 sorry for delay in addressing the review comments.
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2651#discussion_r188107350
--- Diff: storm-client/src/jvm/org/apache/storm/drpc/ReturnResults.java ---
@@ -103,21 +85,32 @@ public void execute(Tuple input
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2651#discussion_r188107411
--- Diff: storm-client/src/jvm/org/apache/storm/drpc/ReturnResults.java ---
@@ -103,21 +85,32 @@ public void execute(Tuple input
Github user kishorvpatil closed the pull request at:
https://github.com/apache/storm/pull/2638
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2638
@srdo, You are right. This was exception I noticed on old internal version
of the code package. It is clearly not necessary in 2.x latest code. Let me
close this patch.
---
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2651
[STORM-3054] Add Topology level configuration socket timeout for DRPC
Invocation Client
This patch fixes following this:
- Add Topology level configuration socket timeout for DRPC
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2638
@srdo , What I mean is there are many instances where kafka is wrapping
actual exceptions into `InterruptedException`. I am not sure why/what is the
objective, but only way to understand the
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2641#discussion_r184525490
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/BlobStoreAPIWordCountTopology.java
---
@@ -38,176 +47,66 @@
import
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2641#discussion_r184525138
--- Diff:
examples/storm-perf/src/main/java/org/apache/storm/perf/utils/MetricsSample.java
---
@@ -160,7 +159,7 @@ private static MetricsSample
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2641#discussion_r183772336
--- Diff:
examples/storm-hbase-examples/src/main/java/org/apache/storm/hbase/topology/LookupWordCount.java
---
@@ -1,25 +1,19
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2641#discussion_r183771851
--- Diff:
examples/storm-hdfs-examples/src/main/java/org/apache/storm/hdfs/bolt/SequenceFileTopology.java
---
@@ -151,15 +145,15 @@ public void
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2638
@HeartSaVioR @srdo ., The issue in assuming that `InterruptedException` is
only coming from external interruptions. Below is the actual example we noticed
when Kafka Spout`TimeoutException` was
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2641
[STORM-3037] Lowering CheckStyle Violations across all modules
Below is the list of modules affected by this patch. The max allowed
violations are going down by 17000+.
| Module Name
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2638
@srdo Moved the `LOG.error` before changing exception Cause.
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2638#discussion_r182847223
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -109,6 +109,8 @@
import javax.security.auth.Subject
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2638#discussion_r182843808
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -361,6 +363,7 @@ public void run() {
Time.sleep
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2638
[STORM-3034] Adding exception stacktrace for executor failures in worker
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2631
@agresch I have addressed the code review comments.
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2631#discussion_r180811674
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/normalization/NormalizedResourceRequest.java
---
@@ -187,4 +187,29 @@ public
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2631#discussion_r180800090
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/normalization/NormalizedResourceRequest.java
---
@@ -187,4 +187,29 @@ public
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2631
[STORM-3025] Optimize Cluster methods with Caching to avoid loopy loops
Optimizing the `Cluster` methods that are called from with high frequency
calls to speed-up scheduling time on new
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2603
@HeartSaVioR , I think changes in #2433 do take care of caching assignments
within `InMemoryAssignmentBackend`, so the changes proposed in #2603 are no
longer needed. I am closing this PR
---
Github user kishorvpatil closed the pull request at:
https://github.com/apache/storm/pull/2603
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2603
@HeartSaVioR Sure. Let me review #2433. In the meantime, I will create
patch for 1.x-branch.
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2603
@d2r Thank you for the review. I have addressed the comments. The failure
seems unrelated to my changes - the test passes on local environment.
---
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2603
[STORM-3003] Adding Assignment caching to Nimbus
Since nimbus ( scheduler generates assignments) it can cache it instead of
polling for it from ZK or other state manager. This would improve
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2576
[STORM-2976] Fix Supervisor HealthCheck validations
The couple of issues with Supervisor HealthCheck functionality.
1. `ClassCastException` while reading configuration.
2. The
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2563
@HeartSaVioR Thank you, I fixed the indentation.
---
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2563
[STORM-2961] Refactor addResource and addResources Methods in
BaseConfigurationDeclarer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user kishorvpatil closed the pull request at:
https://github.com/apache/storm/pull/2487
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2487
closing the PR as no longer needed for master branch.
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2531#discussion_r164154647
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2638,6 +2647,34 @@ private int getNumOfAckerExecs(Map
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2531#discussion_r164134542
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -46,7 +46,7 @@
(:import [org.apache.commons.io FileUtils])
(:import
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2531#discussion_r163729225
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/kerberos/ServerCallbackHandler.java
---
@@ -18,79 +18,86 @@
package
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2531#discussion_r163728603
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/kerberos/KerberosSaslTransportPlugin.java
---
@@ -114,22 +120,26 @@ public
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2487
@HeartSaVioR, Please find patch for 1.x-branch -
https://github.com/apache/storm/pull/2529
---
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2529
[STORM-2873] Do not delete backpressure ephemeral node frequently
- Do not delete backpressure ephemeral node frequently
- Add backpressure timeout.
- Cleanup backpressure znodes
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2487
Ok. I will create the PR for 1.x-branch.
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2487
@srdo , Please review changes addressing the comments.
---
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2487
[STORM-2873] Do not delete backpressure ephemeral node frequently
If ephemeral znode is created once, then we can leave it as is - as other
workers would look at timestamp to ensure it is not
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2456#discussion_r157072777
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -640,6 +641,150 @@ public void
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148882086
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -62,123 +70,144 @@ public void prepare(Map
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2390#discussion_r147774596
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -159,14 +159,6 @@
public static final String
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2390
[STORM-2790] Add nimbus admins groups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm add-admin-groups
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2363#discussion_r143844543
--- Diff:
storm-server/src/test/java/org/apache/storm/localizer/AsyncLocalizerTest.java
---
@@ -286,29 +297,80 @@ public void
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2345
@revans2 LGTM.
---
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2345#discussion_r143559023
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedBlob.java ---
@@ -0,0 +1,220 @@
+/**
+ * Licensed to the Apache
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2345#discussion_r143510721
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java ---
@@ -156,17 +146,141 @@ public AsyncLocalizer(Map conf
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2345#discussion_r143501314
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -263,7 +314,41 @@ public String toString
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2345#discussion_r143499778
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -104,9 +111,12 @@
this.port = port
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2358
[STORM-2770] Add fragmentation metrics for CPU and Memory
The patch addresses following:
- Calculate fragmentation of CPU/memory
- Display it on UI under Cluster summary
- Add
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2337#discussion_r140328729
--- Diff: bin/storm.py ---
@@ -739,7 +739,6 @@ def
supervisor(klass="org.apache.storm.daemon.supervisor.Supervisor"):
1 - 100 of 372 matches
Mail list logo
