Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2363#discussion_r143844543
--- Diff:
storm-server/src/test/java/org/apache/storm/localizer/AsyncLocalizerTest.java
---
@@ -286,29 +297,80 @@ public void testRequestDownloadTopologyBlobs() throws
Exception {
class TestLocalizer extends AsyncLocalizer {
TestLocalizer(Map<String, Object> conf, String baseDir) throws
IOException {
- super(conf, AdvancedFSOps.make(conf), baseDir, new
AtomicReference<>(new HashMap<>()), null);
+ super(conf, AdvancedFSOps.make(conf), baseDir);
}
@Override
protected ClientBlobStore getClientBlobStore() {
return mockblobstore;
}
+
+ synchronized void addReferences(List<LocalResource> localresource,
PortAndAssignment pna, BlobChangingCallback cb) {
+ String user = pna.getOwner();
+ for (LocalResource blob : localresource) {
+ ConcurrentMap<String, LocalizedResource> lrsrcSet =
blob.shouldUncompress() ? userArchives.get(user) : userFiles.get(user);
+ if (lrsrcSet != null) {
+ LocalizedResource lrsrc =
lrsrcSet.get(blob.getBlobName());
+ if (lrsrc != null) {
+ lrsrc.addReference(pna, blob.needsCallback() ? cb
: null);
+ lrsrc.addReference(pna, blob.needsCallback() ? cb
: null);
--- End diff --
remove duplicate call?
---
