Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2915
Could you help me to retrigger CI?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2915
@revans2 Hi,is my revision consistent with your thoughts? And I also have a
question,whether we can't use ResourceAwareScheduler if
supervisor.run.worker.as.user is false?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2915
@revans2
Thanks for your reply.I really want to launch worker as who submit it.I
think TOPOLOGY_SUBMITTER_USER is for this,but this config doesn't work.I know
your concernsï
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2915
@revans2 could you help me to review this PR? thanks
---
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2915
[STORM-3291]Worker can't run as the user who submitted the topology
[https://issues.apache.org/jira/browse/STORM-3291](https://issues.apache.org/jira/browse/STORM-3291)
Without principal
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2765
@revans2
Thanks for your reply.I will try to modify the way to separate out a host
from a port.
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2765
@revans2
Thanks for your reply.I will try to modify the way to separate out a host
from a port.
---
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2765
[STORM-3152]Storm has supported ipv6 but Troubleshooting.md didn't update
[https://issues.apache.org/jira/browse/STORM-3152](https://issues.apache.org/jira/browse/STORM-3152)
As storm's
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2066
@aniketalhat
You can look through my PRï¼and my intention was to export
java.security.auth.login.config=the path to your keytab,and it works.You can
try it.
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
Hi,revans! I guess you forgot this PR after a long time.I just want to
know if this PR is available because I used to work hard to make it. Even if
you think it is not good enough
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2600
@HeartSaVioR
Could you help me review this PR?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2599
@HeartSaVioR
Could you help me review this PR?
---
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2601
[STORM-2998]Wrong className in LoggerFactory.getLogger method
[https://issues.apache.org/jira/browse/STORM-2998](https://issues.apache.org/jira/browse/STORM-2998)
If we use
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2600
[STORM-2997] Add logviewer ssl module in SECURITY.md
[https://issues.apache.org/jira/browse/STORM-2997](https://issues.apache.org/jira/browse/STORM-2997)
Add logviewer ssl module
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2599
[STORM-2996] Inaccurate description about offset and kafkaspout will make
users confused
[https://issues.apache.org/jira/browse/STORM-2996](https://issues.apache.org/jira/browse/STORM-2996
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
Hi,@revans2,I'm not sure whether the ci's failure related to me.And I have
add a retry to DRPCInvaction,could you help me to review it?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@HeartSaVioR @revans2
Hi,are you available to help me review this PR?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@HeartSaVioR
Hi,are you available to help me review this PR?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
Hi,@revans2,I'm not sure whether the ci's failure related to me.And I have
add a retry to DRPCInvaction,could you help me to review it?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
Do you mean there no need to reconnect when I create a DRPCInvocationClient
instance?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
I try to fix this bug follow your advice,but I found the original bug
occurred in line 41
[https://github.com/liu-zhaokun/storm/blob/d92f1a9c8d7442d4959fec57813fc5de42b179a9/storm
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
I have fix the checkstyle errors and log the exception.Could you help me
review this PR again?
---
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2365
[STORM-2773]If a drpcserver node in cluster is down,drpc cluster won't work
if we don't modify the drpc.server configuration and restart the cluster
[https://issues.apache.org/jira/browse
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2297
@srdo
Thanks for your reply.I mean if curator has retried several times and
failed,the code where I modify will throw a exception,and it will never attempt
to connect another zkserver
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2297
@srdo
I guess you support my PR,right?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2297
@srdo
I don't think it's related to retry, the key is how storm will do when the
first zkserver is down.
---
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136286746
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136284170
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136279982
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136278638
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2297
[STORM-2713] when the connection to the first zkserver is
timeout,storm-kafka's kafkaspout will throw a exception
[https://issues.apache.org/jira/browse/STORM-2713](https://issues.apache.org
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2259
@HeartSaVioR
Thanks for your support.Could you help me merge it if you have some time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2259
@HeartSaVioR
Could you have a look if you have some time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2259
[STORM-2676] Error class name for log in JsonRecordHiveMapper.java.
[https://issues.apache.org/jira/browse/STORM-2676](https://issues.apache.org/jira/browse/STORM-2676)
The class
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2240
@revans2
Hello,I have modified this PR followed your suggestion.Thanks again for
your hard work.Review it,Please.
---
If your project is set up for it, you can reply to this email and have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2240
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2240
@revans2
Hello,I have updated SECURITY.MD,review it,please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2240
[STORM-2657] Update SECURITY.MD
[https://issues.apache.org/jira/browse/STORM-2657](https://issues.apache.org/jira/browse/STORM-2657)
There are several PRs about storm acl merged
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@revans2
You are right.I created several PRs which has been mergerd that is related
to ACL. I will update SECURITY.md in a new PR with these changes later.Could
you help me merge this PR
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@revans2
Could you help me review this PRï¼there are no committer to review it all
the time.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@Ethanlm
Hi,Ethan. @HeartSaVioR and @revans2 both approved this PR,could you help
me merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@Ethanlm
Ok,thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@Ethanlm
Hi,could you help me review the new change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@Ethanlm
Thanks for your reply.I will modify it follow your suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@HeartSaVioR
I have modify this PR follow @revans2 suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@HeartSaVioR
OK, I will do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@HeartSaVioR
Do you have time to help me review this PR,it's about drpc acl?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@harshach
It has always been the case.In other words,the value of this configuration
is digest all the time.You can see StormSubmitter.java,line 92.It doesn't
matter even that is in case
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@HeartSaVioR
I have modified this PR according to your opinion,and it has passed all the
test.Could you help me merge it?Thank you very much.
---
If your project is set up for it, you can
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@HeartSaVioR
Thanks for your reply.I will remove it from Config.java.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@harshach
Thanks for your reply.You can see StormSubmitter.java,line
91.STORM_ZOOKEEPER_TOPOLOGY_AUTH_SCHEME is should always be set to digest.It
can't be and won't be other value.So,I
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@haitaoyao
I am so sorry to bother you.Do you have time to help me review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@harshach
I am so sorry to bother you.Do you have time to help me review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@vesense
I am so sorry to bother you.Do you have time to help me review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@HeartSaVioR
I am so sorry to bother you.Do you have time to help me review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2208
@HeartSaVioR
I am so sorry to bother you.Do you have time to help me review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2208
[STORM-2627] The annotation of storm.zookeeper.topology.auth.scheme in
Config.java is wrong
[https://issues.apache.org/jira/browse/STORM-2627](https://issues.apache.org/jira/browse/STORM-2627
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2207
[STORM-2626] Provided a template for drpc-auth-acl.yaml
[https://issues.apache.org/jira/browse/STORM-2626](https://issues.apache.org/jira/browse/STORM-2626)
The default value
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@HeartSaVioR
Thanks very much for your hard work.I know your difficulties now,and I will
support your work.
---
If your project is set up for it, you can reply to this email and have your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
Could anyone help me merge this PR?It has been create long long ago.I only
want to handle it properly.Could anyone reply to me?
---
If your project is set up for it, you can reply to this email
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@HeartSaVioR
Since this PR has been "+1"ï¼could you help me merge IT now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@harshach
Could you help me merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@srdo
Could you help me merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@revans2
Could you help me merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@vesense
Could you help me merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@HeartSaVioR
Did you miss this PR?Could you help me merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@HeartSaVioR
Did you miss this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@HeartSaVioR
Could you help me merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun closed the pull request at:
https://github.com/apache/storm/pull/2058
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user liu-zhaokun closed the pull request at:
https://github.com/apache/storm/pull/1890
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@hmcl
Could you help me merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun closed the pull request at:
https://github.com/apache/storm/pull/2066
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@HeartSaVioR
The new commit has passed all the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@HeartSaVioR
Hello,I have update the test,and adjust my code according to @revans2 's
opinion.Could you help me merge it?
---
If your project is set up for it, you can reply to this email
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@revans2
Yes,I pass this configuration by storm.config.I will take a look at that
test,and adjust my code according to your opinion.Thanks for your reply.
---
If your project is set up
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@HeartSaVioR
Thanks for your reply,if possible, please help me merge it as soon as
possible,because this PR has been created for a long time.
---
If your project is set up for it, you can
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@HeartSaVioR
Users needn't copy the configuration,storm.zookeeper.auth.payload, from
storm-cluster-auth.yaml.template and paste to their storm.yaml.They only should
add this configuration
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@HeartSaVioR
It says "Note that if this is set to something with a secret (as when using
digest authentication) then it should only be set in the
storm-cluster-auth.yaml
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2180
@HeartSaVioR
I want to use my payload by setting the configuration which named
"STORM_ZOOKEEPER_TOPOLOGY_AUTH_PAYLOAD",but it doesn't work.The payload of any
topology always
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2166
@HeartSaVioR
Please help me merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2166
Are there any body help me merge it?It was created for a long time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2180
[STORM-2602] storm.zookeeper.topology.auth.payload doesn't work even you
set it
[https://issues.apache.org/jira/browse/STORM-2602](https://issues.apache.org/jira/browse/STORM-2602
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2166
@HeartSaVioR
Hello,are you available to help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@HeartSaVioR
Hello,are you available to help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@vesense
Could you help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2170
[STORM-2564] We should provide a template for storm-cluster-auth.yaml
[https://issues.apache.org/jira/browse/STORM-2564](https://issues.apache.org/jira/browse/STORM-2564
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2166
@HeartSaVioR
Hello,are you available to help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2166
@vesense
Hello,are you available to help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2166
[STORM-2559] There are three configurations in defaults.yaml haven't been
used in storm.
[https://issues.apache.org/jira/browse/STORM-2559](https://issues.apache.org/jira/browse/STORM-2559
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@HeartSaVioR
Do you agree with me?Could you help me merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@HeartSaVioR
The explanation has existed in docs\SECURITY.md,so I didn't add it in these
files.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@HeartSaVioR
kishorvpatil approved these changes 28 days ago,could you help me merge
this PR as soon as possible?
---
If your project is set up for it, you can reply to this email and have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@HeartSaVioR
Hello,long time no see!Anyway,thanks for your reply.
The $ here should be replace with their keytab and principal by
users manually.
---
If your project is set up
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@kishorvpatil @vesense @HeartSaVioR @harshach ,can you take a look at
this PR? It's too long to almost forget
The issue is still âIN PROGRESSâ
I just want to finish it properly
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@harshach
Could you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@HeartSaVioR
Could you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@kishorvpatil
Could you help me merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2110
@kishorvpatil
Could you help me merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 212 matches
Mail list logo
