Github user reiabreu commented on the issue:
https://github.com/apache/storm/pull/2620
Yeah, going through the Travis logs it does seem they are unstable.
Thank you for your help. Much appreciated.
---
GitHub user reiabreu reopened a pull request:
https://github.com/apache/storm/pull/2620
STORM-2994: KafkaSpout doesn't commit offsets for null tuples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reiabreu/storm 1.x-branch
Github user reiabreu closed the pull request at:
https://github.com/apache/storm/pull/2620
---
GitHub user reiabreu opened a pull request:
https://github.com/apache/storm/pull/2620
STORM-2994: KafkaSpout doesn't commit offsets for null tuples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reiabreu/storm 1.x-branch
Github user reiabreu commented on the issue:
https://github.com/apache/storm/pull/2593
@srdo Sure, I'll have a look
---
Github user reiabreu commented on the issue:
https://github.com/apache/storm/pull/2593
Thank you for guiding me through the changes. I've squashed all the commits
and pushed a fresh one
---
Github user reiabreu commented on a diff in the pull request:
https://github.com/apache/storm/pull/2593#discussion_r178586564
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutNullTupleTest.java
---
@@ -0,0 +1,76
Github user reiabreu commented on the issue:
https://github.com/apache/storm/pull/2593
KafkaSpoutAbstractTest is tightly coupled to KafkaSpoutConfig through
createSpoutConfig, meaning that to test a single configuration change, we need
to create a new test class. This is something
Github user reiabreu commented on a diff in the pull request:
https://github.com/apache/storm/pull/2593#discussion_r178559146
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -570,20 +572,25 @@ public void ack(Object
Github user reiabreu commented on a diff in the pull request:
https://github.com/apache/storm/pull/2593#discussion_r178510737
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -484,8 +484,11 @@ private boolean emitOrRetryTuple
Github user reiabreu commented on the issue:
https://github.com/apache/storm/pull/2593
Hi folks! I won't have access to a computer until next weekend. I'll pick
it up then. Thank you for understanding
On Wed, 28 Mar 2018, 08:15 Jungtaek Lim, <notificati...@github.
GitHub user reiabreu opened a pull request:
https://github.com/apache/storm/pull/2593
STORM-2994 KafkaSpout commit offsets for null tuples
Hello,
Let's kick off this pull request.
Unit tests for null tuples were missing. I'm in the process of adding them.
I'll
12 matches
Mail list logo
