GitHub user rfarivar opened a pull request:
https://github.com/apache/storm/pull/1043
Storm 1226
This is translating util.clj into java functions mostly in
utils/Utils.java.
Translation is half way done, passing all unit tests. Putting the pull
request up to get reviews
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/949#issuecomment-165204905
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/941#issuecomment-165202824
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/945#issuecomment-165182657
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/941#issuecomment-165180783
It's an unlikely scenario and I might be paranoid, but what if the tests
were running on a cluster under heavy traffic? For instance, what if the tests
were to b
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/943#issuecomment-165178423
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47715049
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -28,94 +32,272 @@
import
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/946#issuecomment-164920140
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/948#discussion_r47710294
--- Diff: storm-core/src/clj/backtype/storm/daemon/logviewer.clj ---
@@ -320,7 +320,7 @@
logs-groups (concat (conf LOGS-GROUPS
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/949#discussion_r47708800
--- Diff: docs/documentation/Logs.md ---
@@ -0,0 +1,30 @@
+---
+title: Storm Logs
+layout: documentation
+documentation: true
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47707713
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -193,17 +199,21 @@ public void freeAllSlots(Cluster cluster
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/921#issuecomment-164898677
Done with this review pass. Mostly formatting issues, no major problem I
can detect with the logic.
---
If your project is set up for it, you can reply to this email
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47699342
--- Diff:
storm-core/test/jvm/backtype/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java
---
@@ -0,0 +1,293 @@
+/**
+ * Licensed to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47699328
--- Diff:
storm-core/test/jvm/backtype/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java
---
@@ -0,0 +1,293 @@
+/**
+ * Licensed to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47699315
--- Diff:
storm-core/test/jvm/backtype/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java
---
@@ -0,0 +1,293 @@
+/**
+ * Licensed to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47699226
--- Diff:
storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -0,0 +1,1176 @@
+/**
+ * Licensed to the
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47699186
--- Diff:
storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -0,0 +1,1176 @@
+/**
+ * Licensed to the
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47698554
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/scheduling/IStrategy.java
---
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47698498
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
---
@@ -159,18 +163,22 @@ public
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47698615
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -489,17 +489,62 @@ public void validateField(String name, Object o
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47698666
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -176,6 +177,14 @@
boolean includeZero() default
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47698332
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/priority/DefaultSchedulingPriorityStrategy.java
---
@@ -0,0 +1,86
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47698086
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/DefaultEvictionStrategy.java
---
@@ -0,0 +1,110
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47692734
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -28,94 +32,272 @@
import
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47691574
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -28,94 +32,272 @@
import
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47691194
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Nodes.java ---
@@ -0,0 +1,159 @@
+/**
+ * Licensed to the Apache Software
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47691091
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Nodes.java ---
@@ -0,0 +1,159 @@
+/**
+ * Licensed to the Apache Software
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r4769
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -230,6 +241,61 @@ public void freeTopology(String topId, Cluster
cluster
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47689863
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -193,17 +199,21 @@ public void freeAllSlots(Cluster cluster
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47689810
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -193,17 +199,21 @@ public void freeAllSlots(Cluster cluster
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47686911
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -403,13 +415,23 @@ public void addResourcesForExec(ExecutorDetails exec
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47683188
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -403,13 +415,23 @@ public void addResourcesForExec(ExecutorDetails exec
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47677186
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47681877
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -90,6 +92,21 @@ public Cluster(INimbus nimbus, Map supervisors, Map newAssignments
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47681330
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -430,12 +457,44 @@ public SupervisorDetails getSupervisorById(String
nodeId
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47668189
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47669322
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47677367
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47677641
--- Diff:
examples/storm-starter/src/jvm/storm/starter/ResourceAwareExampleTopology.java
---
@@ -84,6 +82,12 @@ public static void main(String[] args
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47668318
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47669270
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47668683
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47669412
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47668082
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47668887
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47667907
--- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md ---
@@ -0,0 +1,224 @@
+# Introduction
+
+The purpose of this document is to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47667617
--- Diff: conf/defaults.yaml ---
@@ -251,10 +251,14 @@ topology.disruptor.batch.timeout.millis: 1
topology.disable.loadaware: false
# Configs
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/728#discussion_r47586860
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -182,7 +177,7 @@ private boolean connectionEstablished(Channel channel
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/728#discussion_r47586629
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -23,24 +23,17 @@
import backtype.storm.metric.api.IStatefulObject
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/728#discussion_r47586615
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -23,24 +23,17 @@
import backtype.storm.metric.api.IStatefulObject
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-164613029
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/885#discussion_r47586077
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -149,9 +150,9 @@ public EmitState next(SpoutOutputCollector collector
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47553786
--- Diff: external/storm-kafka/README.md ---
@@ -237,7 +238,7 @@ You can do a wildcard topic match by adding the
following config
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47553706
--- Diff: external/storm-kafka/README.md ---
@@ -226,8 +226,9 @@ You can return a null and the message will be ignored.
If you have one static to
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47552629
--- Diff:
external/sql/storm-sql-kafka/src/test/org/apache/storm/sql/kafka/TestKafkaDataSourcesProvider.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47552257
--- Diff:
external/sql/storm-sql-kafka/src/test/org/apache/storm/sql/kafka/TestKafkaDataSourcesProvider.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47552209
--- Diff:
external/sql/storm-sql-kafka/src/test/org/apache/storm/sql/kafka/TestKafkaDataSourcesProvider.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47552042
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/backends/standalone/PlanCompiler.java
---
@@ -0,0 +1,131
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47551924
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/backends/standalone/PlanCompiler.java
---
@@ -0,0 +1,131
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47551419
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/ExprCompiler.java
---
@@ -0,0 +1,471 @@
+/**
+ * Licensed to the Apache
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47551166
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/ExprCompiler.java
---
@@ -0,0 +1,471 @@
+/**
+ * Licensed to the Apache
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47551182
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/ExprCompiler.java
---
@@ -0,0 +1,471 @@
+/**
+ * Licensed to the Apache
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47550941
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java
---
@@ -0,0 +1,168 @@
+/**
+ * Licensed to the Apache
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47550851
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java
---
@@ -0,0 +1,168 @@
+/**
+ * Licensed to the Apache
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/927#discussion_r47550481
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/StormSqlImpl.java ---
@@ -0,0 +1,101 @@
+/**
+ * Licensed to the Apache Software
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/938#issuecomment-164543211
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/941#discussion_r47549426
--- Diff:
storm-core/test/clj/backtype/storm/security/auth/ThriftClient_test.clj ---
@@ -20,26 +20,26 @@
(:import [org.apache.thrift.transport
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/933#discussion_r47549090
--- Diff: storm-core/test/clj/backtype/storm/nimbus_test.clj ---
@@ -1238,10 +1238,11 @@
(testing "nimbus-data uses correct ACLs"
(l
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/933#discussion_r47548775
--- Diff: conf/defaults.yaml ---
@@ -179,7 +179,7 @@ task.refresh.poll.secs: 10
task.credentials.poll.secs: 30
# now should be null by default
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/934#discussion_r47548412
--- Diff:
examples/storm-starter/src/jvm/storm/starter/BlobStoreAPIWordCountTopology.java
---
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/934#discussion_r47548343
--- Diff:
examples/storm-starter/src/jvm/storm/starter/BlobStoreAPIWordCountTopology.java
---
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/934#discussion_r47548325
--- Diff:
examples/storm-starter/src/jvm/storm/starter/BlobStoreAPIWordCountTopology.java
---
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/945#issuecomment-164540466
Minor nit picks, +1 after the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/945#discussion_r47547551
--- Diff: docs/documentation/distcache-blobstore.md ---
@@ -0,0 +1,732 @@
+# Storm Distributed Cache API
+
+The distributed cache feature in storm
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/945#discussion_r47546495
--- Diff: docs/documentation/distcache-blobstore.md ---
@@ -0,0 +1,732 @@
+# Storm Distributed Cache API
+
+The distributed cache feature in storm
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/945#discussion_r47546157
--- Diff: docs/documentation/distcache-blobstore.md ---
@@ -0,0 +1,732 @@
+# Storm Distributed Cache API
+
+The distributed cache feature in storm
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/945#discussion_r47545780
--- Diff: docs/documentation/distcache-blobstore.md ---
@@ -0,0 +1,733 @@
+# Storm Distributed Cache API
+
+The distributed cache feature in storm
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/900#discussion_r46704537
--- Diff:
storm-core/src/jvm/backtype/storm/windowing/TimeEvictionPolicy.java ---
@@ -21,21 +21,30 @@
* Eviction policy that evicts events based on
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/909#issuecomment-161369727
The updated links look good, but I don't understand why this can't be part
of #908?
---
If your project is set up for it, you can reply to this email and
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/908#issuecomment-161369105
The updated links look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user rfarivar opened a pull request:
https://github.com/apache/storm/pull/631
[STORM-937] Changing the log level from info to debug
This is to reduce the noisiness of supervisor logs.
You can merge this pull request into a Git repository by running:
$ git pull https
81 matches
Mail list logo
