Github user sureshms closed the pull request at:
https://github.com/apache/storm/pull/837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user sureshms opened a pull request:
https://github.com/apache/storm/pull/852
STORM-1164. Code cleanup for typos, warnings and conciseness
A lot of cleanup in this patch. Let me know if this needs to be split into
smaller manageable patches. This should not make the existing
Github user sureshms commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43554133
--- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java ---
@@ -30,18 +31,20 @@
private HashMap>> bundles =
new H
Github user sureshms commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43553925
--- Diff:
storm-core/src/jvm/backtype/storm/serialization/SerializationFactory.java ---
@@ -81,8 +81,9 @@ public static Kryo getKryo(Map conf
GitHub user sureshms opened a pull request:
https://github.com/apache/storm/pull/837
STORM-1153 Use static final instead of just static for class members
Along with making static variables, I have also cleaned up the code in
those files. Especially around reducing code verbosity by
GitHub user sureshms opened a pull request:
https://github.com/apache/storm/pull/836
STORM-1152 Change map keySet iteration to entrySet iteration for effiâ¦
keySet to entrySet iteration changes along with other minor comments and
code cleanup.
You can merge this pull request into