[GitHub] storm issue #1918: STORM-2339: Python code format cleanup in storm.py

2017-06-22 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1918 This is unfortunate. Maybe someone else can take this on: My eagerness evaporated somewhere around April. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #1918: STORM-2339: Python code format cleanup in storm.py

2017-04-28 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1918 "At 2 months, your baby doesn’t yet have the coordination to play with toys. But she may bat at a colorful object hanging in front of her. Your baby may even briefly hold a toy that you pla

[GitHub] storm pull request #1918: STORM-2339: Python code format cleanup in storm.py

2017-03-08 Thread tibkiss
Github user tibkiss commented on a diff in the pull request: https://github.com/apache/storm/pull/1918#discussion_r105094892 --- Diff: bin/storm.py --- @@ -193,21 +205,26 @@ def parse_args(string): args = [re.compile(r"'((?:[^'\\]|\\.)*)'").su

[GitHub] storm issue #1937: STORM-2355: Storm-HDFS: inotify support

2017-03-08 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1937 bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1923: STORM-2345: Type mismatch in ReadClusterState's ProfileAc...

2017-03-08 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1923 bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1918: STORM-2339: Python code format cleanup in storm.py

2017-03-08 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1918 bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1937: STORM-2355: Storm-HDFS: inotify support

2017-03-06 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1937 @harshach : Updated this PR based on your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1937: STORM-2355: Storm-HDFS: inotify support

2017-03-06 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1937 @roshannaik : I've replied to your questions on the JIRA by extending the description issue description. Please check it out and let me know if you have further questions. Thanks! --- If

[GitHub] storm issue #1937: STORM-2355: Storm-HDFS: inotify support

2017-02-24 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1937 Thanks for the comments. I'll be OoO next week, will address them beginning of March. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request #1937: STORM-2355: Storm-HDFS: inotify support

2017-02-24 Thread tibkiss
Github user tibkiss commented on a diff in the pull request: https://github.com/apache/storm/pull/1937#discussion_r103071553 --- Diff: pom.xml --- @@ -234,7 +234,7 @@ 0.2.4 3.3.2 0.9.0 -16.0.1 +14.0.1 --- End diff

[GitHub] storm issue #1918: STORM-2339: Python code format cleanup in storm.py

2017-02-24 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1918 Thanks for the review @harshach , I've changed the title in JIRA, PR & commit message accordingly. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #1962: storm jdbc topology should log the jdbc connection string...

2017-02-24 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1962 Thanks for this addition, looks reasonable. I'd recommend opening an issue first in jira, then posting this PR with the associated issue id. --- If your project is set up for it, yo

[GitHub] storm pull request #1962: storm jdbc topology should log the jdbc connection...

2017-02-24 Thread tibkiss
Github user tibkiss commented on a diff in the pull request: https://github.com/apache/storm/pull/1962#discussion_r102898864 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/HikariCPConnectionProvider.java --- @@ -40,6 +44,10 @@ public synchronized void

[GitHub] storm issue #1918: STORM-2339: Beauty contest in storm.py

2017-02-23 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1918 This PR has been pending since a while now. Could someone please take a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1911: STORM-2336 Close Localizer and AsyncLocalizer when superv...

2017-02-14 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1911 For future reference: This issue has been committed with a typo in the issue id: STORM-2236 was used as opposed to the correct STORM-2336 `64a9dd0 2017-02-01 Jungtaek Lim STORM-2236

[GitHub] storm pull request #1938: STORM-2360: Storm-Hive: Thrift version mismatch wi...

2017-02-14 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1938 STORM-2360: Storm-Hive: Thrift version mismatch with storm-core You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/storm STORM-2360

[GitHub] storm pull request #1934: STORM-2333: CGroup memory and CPU metrics

2017-02-13 Thread tibkiss
Github user tibkiss commented on a diff in the pull request: https://github.com/apache/storm/pull/1934#discussion_r100821485 --- Diff: storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupCpu.java --- @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1934: STORM-2333: CGroup memory and CPU metrics

2017-02-12 Thread tibkiss
Github user tibkiss commented on a diff in the pull request: https://github.com/apache/storm/pull/1934#discussion_r100691777 --- Diff: storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupCpu.java --- @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm issue #1928: Create ZippedTextFileReader.java

2017-02-12 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1928 Thanks for contributing, nice idea! Seems like the build has failed due to missing symbols in ZippedTextFileReader.java: https://travis-ci.org/apache/storm/jobs/199168284 Unit

[GitHub] storm pull request #1937: STORM-2355: Storm-HDFS: inotify support

2017-02-12 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1937 STORM-2355: Storm-HDFS: inotify support You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/storm feature/inotify_in_hdfsspout-1.x-branch

[GitHub] storm pull request #1926: STORM-2350: Storm-HDFS's listFilesByModificationTi...

2017-02-06 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1926 STORM-2350: Storm-HDFS's listFilesByModificationTime is broken You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/storm STORM

[GitHub] storm pull request #1923: STORM-2345: Type mismatch in ReadClusterState's Pr...

2017-02-05 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1923 STORM-2345: Type mismatch in ReadClusterState's ProfileAction processing Map You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/

[GitHub] storm pull request #1918: STORM-2339: Beauty contest in storm.py

2017-02-03 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1918 STORM-2339: Beauty contest in storm.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/storm fix/beauty_contest Alternatively you can

[GitHub] storm pull request #1917: STORM-2338: Subprocess exception handling is broke...

2017-02-03 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1917 STORM-2338: Subprocess exception handling is broken in storm.py on Windows environment You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss

[GitHub] storm pull request #1915: STORM-2337: Broken documentation generation for st...

2017-02-02 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1915 STORM-2337: Broken documentation generation for storm-metrics-profiling-internal-actions.md and windows-users-guide.md You can merge this pull request into a Git repository by running: $ git

[GitHub] storm issue #1740: STORM-2158: Fix OutOfMemoryError in Nimbus' SimpleTranspo...

2016-10-20 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1740 @HeartSaVioR : Thanks for the explanation. Created the PR for master: https://github.com/apache/storm/pull/1741 --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request #1741: STORM-2158: Fix OutOfMemoryError in Nimbus' Simple...

2016-10-20 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1741 STORM-2158: Fix OutOfMemoryError in Nimbus' SimpleTransportPlugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/storm STORM

[GitHub] storm issue #1740: STORM-2158: Fix OutOfMemoryError in Nimbus' SimpleTranspo...

2016-10-20 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1740 @HeartSaVioR : Sure, will do it shortly. I'm wondering: shall make a PR for 1.0.x-branch too? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] storm pull request #1740: STORM-2158: Fix OutOfMemoryError in Nimbus' Simple...

2016-10-20 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1740 STORM-2158: Fix OutOfMemoryError in Nimbus' SimpleTransportPlugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/storm STORM

[GitHub] storm issue #1579: STORM-1989: X-Frame-Options support for Storm UI

2016-07-22 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1579 @harshach : The patch is not interfering with CORS filter. It is an additional filter addressing the ClickJacking vulnerability. @ptgoetz : Super thanks for merging the PR to both branches

[GitHub] storm issue #1579: STORM-1989: X-Frame-Options support for Storm UI

2016-07-20 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1579 Thanks @ptgoetz for the review! The Travis test failure seems unrelated to me: The base version of the patch also fails with test errors. --- If your project is set up for it, you can

[GitHub] storm pull request #1579: STORM-1989: X-Frame-Options support for Storm UI

2016-07-20 Thread tibkiss
GitHub user tibkiss opened a pull request: https://github.com/apache/storm/pull/1579 STORM-1989: X-Frame-Options support for Storm UI You can merge this pull request into a Git repository by running: $ git pull https://github.com/tibkiss/storm feature/x-frame-options-support