Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2689
Hi @revans2 Now I'm on vacation. I will add a usage document for RocketMQ
example after I get back next week.
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2518
Also rebased PR.
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2518
@hustfxj Added logs and fixed warnings for RocketMqSpout/RocketMqBolt.
---
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2518#discussion_r180281409
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMqSpout.java
---
@@ -60,14 +58,14 @@
public class RocketMqSpout
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2518#discussion_r178704108
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/RocketMqConfig.java
---
@@ -23,28 +23,20 @@
import java.util.Properties
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2518
@vongosling Added unit tests and rebased PR.
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2518
@vongosling Will add more unit tests later.
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2518
Any comments are welcome..
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2518
@harshach @vongosling @hustfxj Do yo have time to take a look?
---
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2518
STORM-2902: Some improvements for storm-rocketmq module
## Brief changelog
* Upgraded RocketMQ version to 4.2.0 which brings improvements and new
features like batch sending
* Imporved
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2446
@HeartSaVioR Created new PR for this.
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2445
@HeartSaVioR Created new PR for this.
---
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2479
STORM-2843: [Flux] [1.x-branch]properties file not found when loading
resources fâ¦
â¦rom classpath
STORM-2843 for 1.x-branch
https://issues.apache.org/jira/browse/STORM-2843
Github user vesense closed the pull request at:
https://github.com/apache/storm/pull/2446
---
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2478
STORM-2843: [Flux] properties file not found when loading resources fâ¦
â¦rom classpath
STORM-2843 for master branch
https://issues.apache.org/jira/browse/STORM-2843
You can
Github user vesense closed the pull request at:
https://github.com/apache/storm/pull/2445
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2445
@HeartSaVioR PR updated. Could you take a look again?
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2469
@ptgoetz @satishd
Yes, I know that kafka-avro-serializer depends on
kafka-schema-registry-client and avro.
There were io.confluent.kafka.schemaregistry.client.XXX not found errors
when
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2469
STORM-2861: Explicit reference kafka-schema-registry-client
https://issues.apache.org/jira/browse/STORM-2861
You can merge this pull request into a Git repository by running:
$ git pull https
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2445#discussion_r157729717
--- Diff:
flux/flux-core/src/main/java/org/apache/storm/flux/parser/FluxParser.java ---
@@ -39,51 +39,57 @@
private FluxParser
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2448
Thanks @Ethanlm Merged into master.
---
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2446
STORM-2843: [Flux] properties file not found when loading resources...
â¦from classpath
STORM-2843 for 1.x-branch
https://issues.apache.org/jira/browse/STORM-2843
You can merge
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2445
STORM-2843: [Flux] properties file not found when loading resources...
â¦from classpath
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2444
STORM-2842: Fixed links for YARN Integration
This is very minor change. Fixed links for YARN Integration.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2377
I prefer to Ieave it as it is, since the log time and the
taskInfo.timestamp is not same. Perhaps someone uses it, I'm not sure.
---
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2234
@omerhadari I assigned the Jira to you and added you to the Jira
contributors.
@srdo I added you to the Jira committers/PMCs.
---
If your project is set up for it, you can reply to this email
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2227
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2220
Sorry for the delay. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2220
Looks good to me. It would be better if we can apply new code style to the
changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2209
Looks great. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2214
STORM-2634: Apply new code style to storm-sql-runtime
Reduce the max allowed violation count to 0.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2213
STORM-2633: Apply new code style to storm-sql-redis
Reduce the max allowed violation count to 0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2212
STORM-2632: Apply new code style to storm-sql-kafka
Reduce the max allowed violation count to 0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2211
STORM-2631: Apply new code style to storm-sql-mongodb
Reduce the max allowed violation count to 0.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2210
STORM-2630: Apply new code style to storm-sql-hdfs
Reduce the max allowed violation count to 0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user vesense closed the pull request at:
https://github.com/apache/storm/pull/2196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2196
OK. No problem. I will close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2196
STORM-2619: Correct the JDK version in Setting-up-a-Storm-cluster.md
The Storm 2.0 needs JDK 1.8+
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2194
STORM-2594: Apply new code style to storm-rocketmq
Reduce the max allowed violation count to 0.
Changed the class names including MQ to Mq.
>Since storm-rocketmq is only mer
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2193
STORM-2589: Apply new code style to storm-mongodb
Reduce the max allowed violation count to 0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2192
This can be cherry-picked to 1.x branch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2192
STORM-2618: Add TridentKafkaStateUpdater for storm-kafka-client
* Added TridentKafkaStateUpdater, otherwise users have to create a class
themselves.
usage scenario
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2189
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2189#discussion_r126295391
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/authorizer/SimpleACLAuthorizer.java
---
@@ -157,6 +162,25 @@ public boolean permit(ReqContext
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2191
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2183
+1
We'd better add the new command to document. (Command-line-client.html)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2092
@harshach / @revans2 Can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2092#discussion_r113874786
--- Diff: docs/storm-pmml.md ---
@@ -0,0 +1,37 @@
+#Storm PMML Bolt
--- End diff --
Nice catch. Will fix.
---
If your project is set up
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2092
STORM-2493: update documents to reflect the changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-2493-documents
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2091
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2082
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2087
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2089#discussion_r113431656
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/LambdaTopology.java ---
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2089
@arunmahadevan Addressed your comments. Please take a look again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2089#discussion_r113403773
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/LambdaTopology.java ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2089#discussion_r113403731
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java ---
@@ -353,6 +421,31 @@ public void setStateSpout(String id, IRichStateSpout
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2089#discussion_r113403709
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java ---
@@ -353,6 +421,31 @@ public void setStateSpout(String id, IRichStateSpout
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2089
@srdo Addressed your comments. Please take a look again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2089#discussion_r113364466
--- Diff:
storm-client/src/jvm/org/apache/storm/lambda/LambdaBiConsumerBolt.java ---
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2089#discussion_r113364472
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/LambdaTopology.java ---
@@ -0,0 +1,52 @@
+/**
+ * Licensed to the Apache Software
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2089#discussion_r113364469
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java ---
@@ -316,6 +322,68 @@ public BoltDeclarer setBolt(String id, IWindowedBolt
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2089
STORM-2490: Lambda support
https://issues.apache.org/jira/browse/STORM-2490
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2085
@tandrup Yes, you need to apply apache license to new files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2077
Merged, and I added you to the contributors list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2077
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r111882508
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,177 @@
+/**
+ * Licensed
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2024
@vongosling @hustfxj @harshach Updated. Can you take a look again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r111867114
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,189 @@
+/**
+ * Licensed
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r111551137
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,189 @@
+/**
+ * Licensed
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r111551156
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,189 @@
+/**
+ * Licensed
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r111551133
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,189 @@
+/**
+ * Licensed
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2071
STORM-1858: KafkaBolt: sharing a single producer instance across threads
https://issues.apache.org/jira/browse/STORM-1858
You can merge this pull request into a Git repository by running
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2069
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2024
@vongosling @hustfxj Updated. Can you take a look again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2067
STORM-2474: fix external README format
This is a really minor change to fix the file format.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r111346264
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,177 @@
+/**
+ * Licensed
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r111345560
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,177 @@
+/**
+ * Licensed
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r111344417
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,179 @@
+/**
+ * Licensed
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2064
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2061
STORM-2469: fix integration-test dependencies issue
This is the hot fix for integration-test dependencies issue
* add storm-server. since __the ExclamationTopology depends
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2058
I guess the change is a copy from
http://storm.apache.org/releases/1.1.0/SECURITY.html "Storm Kerberos
Configuration" section.
Overall looks good to me.
---
If your project
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2056
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2057
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2059
@revans2 100ms dosen't work, but 1s works well. 500ms sometimes still get
failure.
I changed the value to 1s.
---
If your project is set up for it, you can reply to this email and have your
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/2059
STORM-2463: fix DRPCTest.testDequeueAfterTimeout test failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-2463
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2048
@liu-zhaokun Will merge it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2046
@souravmitra Yes, I will merge it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2046
Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2048
Thanks @liu-zhaokun Keep the good work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2048
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2024
POM files updated & Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2024
Hi @hustfxj I guess you know Apache RocketMQ a lot, please take a look if
you have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2024
@vongosling Thanks for your comments. And I will rebase the code on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r110599823
--- Diff:
external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMQSpout.java
---
@@ -0,0 +1,179 @@
+/**
+ * Licensed
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r110599801
--- Diff: external/storm-rocketmq/pom.xml ---
@@ -0,0 +1,89 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/2024#discussion_r110599786
--- Diff: external/storm-rocketmq/pom.xml ---
@@ -0,0 +1,89 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2045
@liu-zhaokun Yes, I will merge it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2044
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2045
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2042
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 556 matches
Mail list logo
