Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1696
@qiozas The Kafka 0.10 API changes were more or less a one-liner for the
spout if I recall, so it shouldn't be a big risk to update. 0.9 and 0.10 have
the same API.
I'll take a look at
Github user qiozas commented on the issue:
https://github.com/apache/storm/pull/1696
@srdo thank you very much for your offer.
We have performed many tests with 1.0.2/3 release in order to be sure for
any problems in migration from 0.9.6 to new version. Our major problem is
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1696
@qiozas If you really need it on 1.0.x, then I wouldn't mind porting it. It
seems like 1.1.0 is right around the corner though (RCs are being tested), so
it might be faster for you to upgrade when that
Github user qiozas commented on the issue:
https://github.com/apache/storm/pull/1696
Do you plan to port this to 1.0.x branch too?
We are facing the same issue on 1.0.3 release (upgrade from 0.9.6).
---
If your project is set up for it, you can reply to this email and have your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1696
This looks good to me. Now that I have gone through the kafka spout code
for my other pull request I am confident in giving this a +1.
---
If your project is set up for it, you can reply to this
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1696
@revans2 ping for review if you have time. I'd like to get this in before
too long if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1696
@hmcl @revans2 @knusbaum Could you guys take a look at this at some point?
I noticed that two new PRs (https://github.com/apache/storm/pull/1752,
https://github.com/apache/storm/pull/1753) were opened
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1696
@hmcl ping. Had a chance to look at this? It would be nice to get merged
soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1696
@hmcl Sure thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1696
@srdo @jfenc91 I am on vacation this week (with limited access to Internet)
and I will be back on Monday. Can we please holding on merging this until I can
finish my review. I implemented the original
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1696
The test failure is due to maven failing to download dependencies on
storm-core. !storm-core passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
11 matches
Mail list logo
