Github user kevpeek commented on the issue:
https://github.com/apache/storm/pull/1790
@HeartSaVioR I created a PR on master with the squashed version of these
commits. I hope that's flexible enough to do what you need.
https://github.com/apache/storm/pull/1797
---
If your project
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1790
@kevpeek
Could you squash your commits into one? The change is small enough and
other commits are closer to code style.
I can handle it while merging, but PR for non-master branch is
Github user Crim commented on the issue:
https://github.com/apache/storm/pull/1790
I feel you, tests can't cover everything. Performance tests are even more
difficult to put together something that's actually valid.
---
If your project is set up for it, you can reply to this email
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1790
@Crim
One thing to be clear, please don't consider my comment as on behalf of
community's opinion. Opinions are completely on my own.
To be honest, I'm not a big fan of test
Github user Crim commented on the issue:
https://github.com/apache/storm/pull/1790
Your comment is a tad worrisome. Is test coverage not at a place where
project contributors can feel good about a release? Or is each release
essentially QA'd by early adopters?
---
If your project
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1790
@ohadedel
I don't know the intention of 'equivalent' (implementation, or result), but
if it means only the result, the result of twos would be similar if you think
far. They provide uniform
Github user ohadedel commented on the issue:
https://github.com/apache/storm/pull/1790
Sound reasonable :)
The documentation in storm was a bit misleading, made us think that its
being implemented the same.
"None grouping: This grouping specifies that you don't care
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1790
NoneGrouping just runs Random.nextInt() for deciding 'tasks' (so it will
follow uniform distribution), whereas ShuffleGrouping simply does Round-Robin.
---
If your project is set up for it, you
Github user ohadedel commented on the issue:
https://github.com/apache/storm/pull/1790
Hi, I don't know what storm release policy, but any chance to see a stable
version with this bug fix release any time soon (v1.0.3).
What we see in our environment is that the host with the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1790
I looked the implementation, and without locking array shouldn't be
modified.
Nice finding. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kevpeek commented on the issue:
https://github.com/apache/storm/pull/1790
Great. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1790
@kevpeek No need, like I said it is a clean cherry pick. We just have a
rule that we need to merge code into master/newer versions before it goes into
older versions.
We also have a 24
Github user kevpeek commented on the issue:
https://github.com/apache/storm/pull/1790
@revans2 should I create a new PR against master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1790
The only other comment that I would have is that it would be nice to have a
pull request against master instead of 1.x, but that is minor as it is a clean
cherry-pick
---
If your project is set up
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1790
I keep beating my head against this to think if there are issues with this,
but I honestly don't see any. Long term I would like to see more of a
combining of shuffle grouping and the shuffle or
15 matches
Mail list logo
