Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2034
Just rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
@HeartSaVioR Yes I gave these changes a +1 because they were as good as I
could expect without having storm server removed completely from the storm jar
classpath. To make that happen we really had
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2034
@revans2
I just saw you also address 'storm-clojure' to refer 'storm-client' in
STORM-2447. Nice work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2034
@revans2
We didn't address origin concern, dependencies issue. This patch doesn't
relocate everything so it would be a regression for many users.
I'd like to get it resolved before
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
Just to let you know that I have been working on making local mode
transparent. I have it working, but I have a lot of work to do on the examples
and docs left.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
+1 it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
I filed STORM-2447 and STORM-2448 to allow for us to separate out the
classpath and make the change transparent for end users.
---
If your project is set up for it, you can reply to this email and
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
I am +1 for the general concept. I need to finish going through the code,
but I am probably going to do it outside of github because the patch is so
huge.
As a side note git used to use
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2034
I googled about `git mv` and some SO article claims `git mv` is just a
shorthand of `delete and create`. Unfortunately there seems no way to reduce
the diff.
---
If your project is set up for
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2034
Travis build fails intermittently. Travis build for fork passes (without
integration test).
https://travis-ci.org/HeartSaVioR/storm/builds/217048964
---
If your project is set up for it,
11 matches
Mail list logo
