Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2150
+1. @harshach @priyank5485 can you please take one final look. If you don't
have any objection, I suggest that we merge this patch in the next day or so.
---
If your project is set up for it, you can
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2150
@hmcl Sorry, I accidentally overwrote this PR with the STORM-2548 content.
This shouldn't contain the STORM-2548 changes. I added the getter and fixed the
content error.
---
If your project is set up
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2150
@srdo Thanks for your diligence and awesome work refactoring this code. It
just made it much better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2150
@srdo I am +1 on this PR. Let's just add the getter method as we agreed on
[this
comment](https://github.com/apache/storm/pull/2150#discussion_r124855414), and
have this PR consist of two commits
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2150
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2150
The issues raised in https://issues.apache.org/jira/browse/STORM-2600
aren't really related to this PR, since the pattern based subscriptions were
already unsupported by storm-kafka-monitor prior to
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2150
@priyank5485 Thanks for responding, I replied on the linked issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user priyank5485 commented on the issue:
https://github.com/apache/storm/pull/2150
@srdo @harshach Some comments related to storm-kafka-monitor
[~Srdo] Regarding first point, because the lag request is a http pull
request from UI, as long as
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2150
Created the issue for storm-kafka-monitor here
https://issues.apache.org/jira/browse/STORM-2600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
