Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-194866571
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-194748171
I am fine with refactoring system topology builder in separate JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user bastiliu commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-194641160
@revans2 @abhishekagarwal87 Thanks for your review. CommonInstaller was
removed, and the drpc changes have been merged. For SystemTopologyBuilder,
maybe it is better t
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-194443713
The code looks really good an I am +1 for merging it in as is. There are
still a few nits though. one with CommonInstaller and another that
@arunmahadevan pointed out f
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55566050
--- Diff:
storm-core/test/jvm/org/apache/storm/utils/staticmocking/CommonInstaller.java
---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55565851
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user bastiliu commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-194271492
I have updated the code according to your comments, and remove the
unnecessary null checks.
---
If your project is set up for it, you can reply to this email and have
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55503834
--- Diff:
storm-core/test/jvm/org/apache/storm/utils/staticmocking/CommonInstaller.java
---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Softwar
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55502112
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55490580
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55489975
--- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj ---
@@ -408,19 +69,3 @@
(:default-shared-resources worker)
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55489803
--- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj ---
@@ -86,26 +40,6 @@
(defn new-executor-stats []
(ExecutorStats. 0 0 0 0 0))
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55489222
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55488575
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55488501
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-193490519
For the most part things look really good. Just a lots of null checks that
were not in the original code. In these cases where we are validating the
structure of the t
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55285995
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -254,6 +254,9 @@
(log-error e "Error when processing event")
(
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55285564
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -742,7 +742,7 @@
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55285470
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -536,17 +536,17 @@
(throw (RuntimeException.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55285131
--- Diff:
storm-core/test/jvm/org/apache/storm/utils/staticmocking/CommonInstaller.java
---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55284861
--- Diff:
storm-core/test/clj/org/apache/storm/messaging/netty_integration_test.clj ---
@@ -1,4 +1,3 @@
-
--- End diff --
Please revert the c
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55284650
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55284177
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55283874
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55283304
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55281249
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55280379
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55280255
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55280156
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55279265
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55279121
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55279184
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55278586
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55277889
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55277573
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55277280
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55276746
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55276131
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55275531
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55271310
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55271251
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55270857
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55269157
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55269210
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55269119
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55269053
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,604 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-193442125
Please upmerge the metrics code has been moved to
StormMetricsRegistry.java, and is causing conflicts now.
---
If your project is set up for it, you can reply to this e
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55268410
--- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj ---
@@ -408,19 +69,3 @@
(:default-shared-resources worker)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55268203
--- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj ---
@@ -86,26 +40,6 @@
(defn new-executor-stats []
(ExecutorStats. 0 0 0 0 0))
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-192486048
upmerge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55007994
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55007937
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55007696
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55007490
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55007408
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55007255
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55006975
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -0,0 +1,605 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55005929
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -2302,4 +2302,54 @@ public Object call() {
public static long bitXor(Long a, Lo
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55002193
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -2302,4 +2302,54 @@ public Object call() {
public static long bitXor(Long a, Lon
GitHub user bastiliu opened a pull request:
https://github.com/apache/storm/pull/1185
[STORM-1269] port backtype.storm.daemon.common to java
1. Following clojure defined records in common, "Assignment, StormBase,
SupervisorInfo, ExecutorStats", were not migrated here. There are corr
61 matches
Mail list logo
