Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-132990727
Modified version of UI is what I and @knusbaum , @d2r suggested, and it
seems that there're no other opinions now.
Build failure is not related to.
So I'm +1.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-132891659
Just modified the UI to have error time shown as a time and date. If you
hover over that time a tooltip will pop up displaying the elapsed time.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-131150732
@HeartSaVioR can you take a look at my pull request again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-131272147
@jerrypeng
I'm with @knusbaum. PR is a bit different from JIRA title, and I'm also
more in favor of putting time/date.
How about gathering consensus about
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130829555
Yes but the exact time and date can be found if you drill down to the
component. Having the elapsed time since time I feel like will tell
administrators in a finer
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130827376
I'm more in favor of putting a time/date here than an elapsed time.
The actual description for STORM-949 is On the topology summary UI page,
last shown error
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36867859
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
/th
th class=headerLast error
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130327785
---
If your project is
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130347080
fixed the formating issues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/675
[STORM-949] On the topology summary UI page, added Elapsed time since error
column.
Current on the topology summary UI page and tells you the last error and
highlights it red if it happened
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130084456
Not sure why travis is failing again. I just built and ran all tests on my
local machine and everything was fine
---
If your project is set up for it, you can reply
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130085867
Hi, there's a storm-hive compilation issue.
Your patch modifies html pages, so you don't need to worry about build. :)
I'll take a look when I have some time.
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36819256
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
/th
th class=headerLast error
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36807536
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
/th
th class=headerLast error
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36807588
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -244,6 +248,9 @@
td
span id={{errorLapsedSecs}}
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36807871
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -226,6 +226,10 @@
/th
th class=headerLast error
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130099776
@jerrypeng
I'd like to see applied screenshot first before taking a detail look. Could
you post it to comment?
---
If your project is set up for it, you can
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36824315
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
/th
th class=headerLast error
19 matches
Mail list logo
