[GitHub] storm pull request: Added support for serialization to SequenceFil...

2014-12-15 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/347#issuecomment-67024196 @mikert Could you please open a JIRA for this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm pull request: Added support for serialization to SequenceFil...

2014-12-15 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/347#discussion_r21839632 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/SequenceFileBolt.java --- @@ -108,7 +109,11 @@ public void execute(Tuple

[GitHub] storm pull request: Added support for serialization to SequenceFil...

2014-12-15 Thread mikert
Github user mikert commented on the pull request: https://github.com/apache/storm/pull/347#issuecomment-67100672 @harshach Sure thing. Can you provide feedback about Parth-Brahmbhatt's comment? I did it that way to ensure that code written for 0.9.3 wouldn't be immediately broken in

[GitHub] storm pull request: Added support for serialization to SequenceFil...

2014-12-14 Thread mikert
GitHub user mikert reopened a pull request: https://github.com/apache/storm/pull/347 Added support for serialization to SequenceFileBolt Added support for org.apache.hadoop.io.serializer.Serialization to the SequenceFileBolt. The new SerializableSequenceFormat interface allows