Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/871
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-202747713
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-202559608
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-202514351
Thanks for the review @Parth-Brahmbhatt @ptgoetz . Addressed the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-202502403
Two very minor nits. Two files are missing Apache headers, and a for loop
that should be enclosed in '{}'.
Aside from that, I'm +1 for the patch.
---
If your
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r57602797
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r57596988
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/trident/HiveStateFactory.java
---
@@ -1,20 +1,3 @@
-/**
- * Licensed to the Apache
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r57597051
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/trident/HiveUpdater.java
---
@@ -1,20 +1,3 @@
-/**
- * Licensed to the Apache
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-200564783
This PR has been open for a long time, i am still +1 and will merge this
this weekend if no one objects.
---
If your project is set up for it, you can reply to
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r49201838
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveConnector.java
---
@@ -0,0 +1,241 @@
+package org.apache.storm.hive.common;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r49201673
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveConnector.java
---
@@ -0,0 +1,241 @@
+package org.apache.storm.hive.common;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r49201793
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveConnector.java
---
@@ -0,0 +1,241 @@
+package org.apache.storm.hive.common;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r49201617
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -25,75 +26,40 @@
import
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-170037330
Sorry this took so long to get back to. The code looks good for the most
part. I have a few minor formatting nits, but the header needs to be updated
and I would like
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-162580970
Still +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-162259764
@revans2 @Parth-Brahmbhatt requesting for one more review as I deleted
duplicated code and addressed previous comments. Thanks.
---
If your project is set up for it,
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44670951
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44673758
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44680811
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44699532
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44598712
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-155934542
Done with a quick pass through the code, for the most part it looks good,
just a few minor comments.
---
If your project is set up for it, you can reply to this email
Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44600468
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44597850
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -56,9 +56,9 @@
private ExecutorService callTimeoutPool;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44598471
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44600086
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44365638
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -87,7 +87,7 @@ public void prepare(Map conf, TopologyContext
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-155269316
overall I am +1, couple of clarifying questions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/871
STORM-1030. Hive Connector Fixes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-1030-V1
Alternatively you can
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44365442
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -87,7 +87,7 @@ public void prepare(Map conf,
30 matches
Mail list logo
