Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/445
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/445#issuecomment-82392832
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/445#issuecomment-78291244
@revans2 pinging for a review. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/445#issuecomment-78300710
+1. I think most users would much rather define a nimbus.groups m e can
probably file a separate jira for that.
---
If your project is set up for it, you can
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/445#issuecomment-78814683
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/445#issuecomment-78663596
@Parth-Brahmbhatt @revans2 Thanks for the review. I updated the PR to
include nimbus.groups as well and added doc under SECURITY.md. Please take a
look.
---
If your
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/445#discussion_r26266419
--- Diff:
storm-core/src/jvm/backtype/storm/security/auth/authorizer/SimpleACLAuthorizer.java
---
@@ -96,7 +101,10 @@ public boolean permit(ReqContext
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/445#issuecomment-78395668
Sorry it took so long for the review. It looks good, and I agree having
groups of allowed users would be a good step.
---
If your project is set up for it, you can
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/445
STORM-689. SimpleACLAuthorizer should provide a way to restrict who can
submit topologies.
You can merge this pull request into a Git repository by running:
$ git pull
