Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-128171287
Maybe @harshach doesn't have time to review at the moment.
I'll merge it right now.
---
If your project is set up for it, you can reply to this email and have
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/573
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-127606460
+1.
@harshach Could you take a look? Or do you want me to merge it without your
review?
---
If your project is set up for it, you can reply to this email and
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35514297
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,72 @@
+# Storm Elasticsearch Bolt Trident State
+
+ EsIndexBolt,
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35514502
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,72 @@
+# Storm Elasticsearch Bolt Trident State
+
+ EsIndexBolt, EsPercolateBolt
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-125113030
@sweetest
Please check comments which doesn't show as outdated. You seems missed some
comments.
Other things are fine.
And I agree that ES is not a
Github user sweetest commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-125119851
All comments addressed, please check.
Thanks for review and all the help @HeartSaVioR , @harshach
---
If your project is set up for it, you can reply to this
Github user sweetest commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-125092854
I addressed comments @HeartSaVioR made.
As you've said, I started from where I'm more experienced so this module
does not contain comprehensive functionality. I
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35506441
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsPercolateBolt.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35506391
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsPercolateBolt.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35506395
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/trident/EsStateFactory.java
---
@@ -0,0 +1,51 @@
+/**
+ *
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35506387
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsIndexBolt.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed to
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35506372
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,66 @@
+# Storm Elasticsearch Bolt Trident State
+
+ EsIndexBolt, EsPercolateBolt
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35506376
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,66 @@
+# Storm Elasticsearch Bolt Trident State
+
+ EsIndexBolt, EsPercolateBolt
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35388631
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,66 @@
+# Storm Elasticsearch Bolt Trident State
+
+ EsIndexBolt,
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-124287695
@sweetest
The code looks great to me overall, too.
Btw, actually I read your post from your company's official technical blog.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35388752
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,66 @@
+# Storm Elasticsearch Bolt Trident State
+
+ EsIndexBolt,
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-12420
@sweetest
And I saw elasticsearch-hadoop has EsSpout, but this module doesn't include
Spout implementation.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35388649
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,66 @@
+# Storm Elasticsearch Bolt Trident State
+
+ EsIndexBolt,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35388715
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,66 @@
+# Storm Elasticsearch Bolt Trident State
+
+ EsIndexBolt,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35388927
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsPercolateBolt.java
---
@@ -0,0 +1,81 @@
+/**
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35388973
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/trident/EsStateFactory.java
---
@@ -0,0 +1,51 @@
+/**
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35388900
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsIndexBolt.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r35389019
--- Diff:
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsPercolateBolt.java
---
@@ -0,0 +1,81 @@
+/**
+ *
Github user sweetest commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-123982826
Thanks for comments from all of you guys.
@harshach
I added javadocs you've mentioned.
@HeartSaVioR @mnogu
Regarding Elasticsearch-hadoop,
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-122078315
@sweetest The code looks great to me. I would like to see some more
javadocs explaining what each of the bolts/state do/need as input. I would
also like to see some
Github user mnogu commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-121772429
Elasticsearch-hadoop doesn't support Trident API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-121773444
@mnogu
Yeah, right. My first look this PR seems superior than elasticsearch-hadoop.
Actually I'm thinking about future maintenance, where is the best
Github user mnogu commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-114502315
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-114161607
@sweetest thanks for the quick turnaround. I'll take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mnogu commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r32942300
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,66 @@
+# Storm ElasticSearch Bolt Trident State
--- End diff --
This search
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r32908774
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,71 @@
+# Storm ElasticSearch Bolt Trident State
+
+ EsIndexBolt, EsPercolateBolt
Github user sweetest commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-114061561
@harshach I've addressed your comment and rebased based on current upstream
master.
Please have a look and let me know if there's any other issues.
---
If your
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r33006123
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,66 @@
+# Storm ElasticSearch Bolt Trident State
--- End diff --
@mnogu
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r32905722
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,71 @@
+# Storm ElasticSearch Bolt Trident State
+
+ EsIndexBolt,
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r32904099
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,71 @@
+# Storm ElasticSearch Bolt Trident State
+
+ EsIndexBolt, EsPercolateBolt
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-113995462
@sweetest it looks good on my first look. I volunteer to be a sponsor for
this connector. Can you upmerge this. I'll work on getting this in. Thanks.
---
If your
37 matches
Mail list logo
