Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-167640073
closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-167632432
@Parth-Brahmbhatt should we close this pull request for now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user Parth-Brahmbhatt closed the pull request at:
https://github.com/apache/storm/pull/387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-112220073
@Parth-Brahmbhatt @wurstmeister will this supersede STORM-590? ([pull
request](https://github.com/apache/storm/pull/407))
---
If your project is set up for it, you can
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-112223772
I think we should be able to merge STORM-590 for now given that change is
backward compatible and atleast allows users to move on to Kafka broker APIs.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-75582274
Do we want to close this pull request for the time being and re-open after
discussion in STORM-650?
---
If your project is set up for it, you can reply to this email and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-72542849
@ptgoetz makes sense. STORM-631 aiming to be a umbrella jira. Creating
another jira is fine too.
---
If your project is set up for it, you can reply to this email and
Github user wurstmeister commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-72537785
sounds good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-72536213
@ptgoetz Makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-72551762
STORM-650 created. Let's try to focus discussion/efforts there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ogorun commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-72505185
Hi @Parth-Brahmbhatt ,
Thank you for pointing me to this pull request. I see that my pull request
https://github.com/apache/storm/pull/406 shares part of ideas
Github user wurstmeister commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-72496938
Hi,
i've created a backwards compatible alternative focused on using the Kafka
API for reading partition information in
Github user wurstmeister commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-72336141
Hi
thanks for starting this refactoring, i've had this on my list of things to
do but unfortunately have not had the time to do it.
A few
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-72349915
Thanks for the suggestions, I have tried to address all the concerns below.
* I can create multiple jiras and separate the refactoring in two parts as
you
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/387#issuecomment-70728873
I also tested the changes against kafka 0.8.2 release candidate and was
able to verify that bolts/spouts/trident states/emitter are able to read and
write from
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/387
Storm 631: refactoring kafka connector code.
This also covers STORM-590. I could not come up with a better name for
partitionCoordinator which is more like PartitionManagerCache but it also
16 matches
Mail list logo
