[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/667 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2016-03-07 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-193484745 JStorm's cgroups merged with #1053. Closing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2016-01-04 Thread bastiliu
Github user bastiliu commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-168880465 @ptgoetz Yes, @revans2 has created one. Following is the JIRA for jstorm merge. https://issues.apache.org/jira/browse/STORM-1336 --- If your project is set up for

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2016-01-04 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-168877269 I agree with @d2r, or would at least answer that, yes, we should hold off on cgroups support until the jstorm merge. I believe that @revans2 might have already covered th

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-12-28 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-167626299 @revans2 @hustfxj @jerrypeng @caishize Should we add support for cgroups with the jstorm merge, or should we try to add support for it now? @caishize It wou

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-11-08 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-154820435 it is great that storm begin to support cgroup function just like jstorm --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-11-05 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-154126726 any updates on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-10-07 Thread caishize
Github user caishize commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-146106627 Yes,there's an update haven't been submitted, but it still only works on an Linux operating system which has the cgroup installed.. Sent from my iPhone

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-10-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-145260043 @caishize Any update on this? I really would like to have cgroup support, and this should work really well with the resource aware scheduling we are working on, on anoth

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-08-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-136175840 @caishize please file a JIRA here https://issues.apache.org/jira/browse/STORM . I haven't taken a close look at the changes but does any of these changes interfere with

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-08-09 Thread caishize
Github user caishize commented on a diff in the pull request: https://github.com/apache/storm/pull/667#discussion_r36604416 --- Diff: storm-core/src/clj/backtype/storm/cgroup/cgroup_manager.clj --- @@ -0,0 +1,109 @@ +(ns backtype.storm.cgroup.cgroup-manager + (:import [java

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-08-09 Thread lazyval
Github user lazyval commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-129257863 AFAIK, if some feature is non-trivial, it requires backing JIRA ticket for it --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-08-09 Thread lazyval
Github user lazyval commented on a diff in the pull request: https://github.com/apache/storm/pull/667#discussion_r36594606 --- Diff: storm-core/src/clj/backtype/storm/cgroup/cgroup_manager.clj --- @@ -0,0 +1,109 @@ +(ns backtype.storm.cgroup.cgroup-manager + (:import [java.

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-08-06 Thread caishize
GitHub user caishize opened a pull request: https://github.com/apache/storm/pull/667 add cgroup function that can limit cpu share of each worker add cgroup function that can limit cpu share of each worker, and it really help indeed You can merge this pull request into a Git reposit