[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2019 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-18 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2019#discussion_r106796495 --- Diff: storm-core/src/jvm/org/apache/storm/bolt/JoinBolt.java --- @@ -191,9 +191,9 @@ public void execute(TupleWindow inputWindow) { for (R

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-18 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2019#discussion_r106796491 --- Diff: docs/Joins.md --- @@ -122,4 +122,18 @@ is treated as a single stream and joined against `stream2` from `bolt3`. 2. Duplication of joined re

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-18 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2019#discussion_r106795812 --- Diff: storm-core/src/jvm/org/apache/storm/bolt/JoinBolt.java --- @@ -191,9 +191,9 @@ public void execute(TupleWindow inputWindow) { for (Resu

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-18 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2019#discussion_r106795693 --- Diff: docs/Joins.md --- @@ -122,4 +122,18 @@ is treated as a single stream and joined against `stream2` from `bolt3`. 2. Duplication of joined recor

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-18 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2019#discussion_r106795805 --- Diff: storm-core/src/jvm/org/apache/storm/bolt/JoinBolt.java --- @@ -191,9 +191,9 @@ public void execute(TupleWindow inputWindow) { for (Resu

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-18 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2019#discussion_r106795850 --- Diff: docs/Joins.md --- @@ -122,4 +122,18 @@ is treated as a single stream and joined against `stream2` from `bolt3`. 2. Duplication of joined recor

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-17 Thread roshannaik
GitHub user roshannaik opened a pull request: https://github.com/apache/storm/pull/2019 STORM-2423 - Join Bolt should use explicit instead of default window anchoring of emitted tuples Default anchoring will anchor each emitted tuple to every tuple in current window. This requires