Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2291#discussion_r134629852
--- Diff: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ---
@@ -84,21 +83,6 @@ public void invalidConfigTest() throws
InvocationTargetExcept
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2291#discussion_r134629272
--- Diff: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ---
@@ -84,21 +83,6 @@ public void invalidConfigTest() throws
InvocationTargetEx
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2291#discussion_r134629037
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2529,7 +2529,7 @@ public void submitTopologyWithOpts(String topoName,
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2291#discussion_r134628949
--- Diff: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ---
@@ -84,21 +83,6 @@ public void invalidConfigTest() throws
InvocationTargetExcept
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2291#discussion_r134621182
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2529,7 +2529,7 @@ public void submitTopologyWithOpts(String topoN
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2291#discussion_r134621377
--- Diff: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ---
@@ -84,21 +83,6 @@ public void invalidConfigTest() throws
InvocationTargetEx
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2291
[STORM-2704] Check blob permission before submitting the topology
See: https://issues.apache.org/jira/browse/STORM-2704
The original code only checks if the keys in `topology.blobstore.map`
