Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2380
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147053713
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147050615
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147050462
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit() {
priva
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147026299
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit() {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147025782
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsFor
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147025420
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsFor
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147022902
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147016997
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015438
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015407
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147015173
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147014032
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit() {
priva
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013717
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -255,26 +255,25 @@ private void throwKafkaConsumerInter
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013620
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -125,8 +125,8 @@ public void open(Map conf,
TopologyCo
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013385
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147013419
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012506
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012486
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012458
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r147012467
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146997432
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146997051
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146996955
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146996683
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146325232
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146328865
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146325123
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146325771
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146326837
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327070
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146329393
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit() {
priva
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327143
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146329456
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327422
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -125,8 +125,8 @@ public void open(Map conf,
TopologyCo
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146326949
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327983
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -255,26 +255,25 @@ private void throwKafkaConsumerInter
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146326263
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146329730
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146325303
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146329596
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146324431
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146324267
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2380
STORM-2781: Refactor storm-kafka-client KafkaSpout Processing Guarantees
- Define processing guarantees as AT_LEAST_ONCE, AT_MOST_ONCE, NONE
- Refactor method name from setForceEnableTupleTracking
45 matches
Mail list logo
