[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2475 ---

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-19 Thread hmcc
Github user hmcc commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162613466 --- Diff: storm-client/src/jvm/org/apache/storm/utils/DefaultShellLogHandler.java --- @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162317935 --- Diff: storm-client/test/resources/log4j2-test.xml --- @@ -0,0 +1,32 @@ + + + + + + + +

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162313151 --- Diff: storm-client/src/jvm/org/apache/storm/task/ShellBolt.java --- @@ -145,6 +148,8 @@ public void prepare(Map topoConf,

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162313649 --- Diff: storm-client/src/jvm/org/apache/storm/spout/ShellSpout.java --- @@ -177,6 +179,7 @@ private void handleMetrics(ShellMsg shellMsg) {

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162314626 --- Diff: storm-client/src/jvm/org/apache/storm/utils/DefaultShellLogHandler.java --- @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162317609 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java --- @@ -464,4 +465,18 @@ public void run() { } } +

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162316967 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java --- @@ -464,4 +465,18 @@ public void run() { } } +

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162315997 --- Diff: storm-client/src/jvm/org/apache/storm/utils/DefaultShellLogHandler.java --- @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162312970 --- Diff: storm-client/src/jvm/org/apache/storm/spout/ShellSpout.java --- @@ -50,6 +51,7 @@ private SpoutOutputCollector _collector;

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162314056 --- Diff: storm-client/src/jvm/org/apache/storm/task/ShellBolt.java --- @@ -351,6 +328,7 @@ public void run() { private class

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r162316609 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java --- @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r159973491 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-05 Thread hmcc
Github user hmcc commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r159972449 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r159895567 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r159863976 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r159742244 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

2018-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2475#discussion_r159742835 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation