Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2475
---
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162613466
--- Diff:
storm-client/src/jvm/org/apache/storm/utils/DefaultShellLogHandler.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162317935
--- Diff: storm-client/test/resources/log4j2-test.xml ---
@@ -0,0 +1,32 @@
+
+
+
+
+
+
+
+
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162313151
--- Diff: storm-client/src/jvm/org/apache/storm/task/ShellBolt.java ---
@@ -145,6 +148,8 @@ public void prepare(Map topoConf,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162313649
--- Diff: storm-client/src/jvm/org/apache/storm/spout/ShellSpout.java ---
@@ -177,6 +179,7 @@ private void handleMetrics(ShellMsg shellMsg) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162314626
--- Diff:
storm-client/src/jvm/org/apache/storm/utils/DefaultShellLogHandler.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162317609
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java ---
@@ -464,4 +465,18 @@ public void run() {
}
}
+
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162316967
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java ---
@@ -464,4 +465,18 @@ public void run() {
}
}
+
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162315997
--- Diff:
storm-client/src/jvm/org/apache/storm/utils/DefaultShellLogHandler.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162312970
--- Diff: storm-client/src/jvm/org/apache/storm/spout/ShellSpout.java ---
@@ -50,6 +51,7 @@
private SpoutOutputCollector _collector;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162314056
--- Diff: storm-client/src/jvm/org/apache/storm/task/ShellBolt.java ---
@@ -351,6 +328,7 @@ public void run() {
private class
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162316609
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159973491
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159972449
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159895567
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159863976
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159742244
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159742835
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
18 matches
Mail list logo