[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-03-17 Thread reiabreu
GitHub user reiabreu opened a pull request: https://github.com/apache/storm/pull/2593 STORM-2994 KafkaSpout commit offsets for null tuples Hello, Let's kick off this pull request. Unit tests for null tuples were missing. I'm in the process of adding them. I'll update

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-03-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r175256133 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -576,6 +579,8 @@ public void ack(Object messageId) {

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-03-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r175256064 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -484,8 +484,11 @@ private boolean emitOrRetryTuple(Cons

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-04-02 Thread reiabreu
Github user reiabreu commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178510737 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -484,8 +484,11 @@ private boolean emitOrRetryTuple(

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-04-02 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178551488 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -570,20 +572,25 @@ public void ack(Object messageId) {

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-04-02 Thread reiabreu
Github user reiabreu commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178559146 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -570,20 +572,25 @@ public void ack(Object messageId

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-04-02 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178562679 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -570,20 +572,25 @@ public void ack(Object messageId) {

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-04-02 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178571949 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutNullTupleTest.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-04-02 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178571304 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutNullTupleTest.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

2018-04-02 Thread reiabreu
Github user reiabreu commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178586564 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutNullTupleTest.java --- @@ -0,0 +1,76 @@ +/* + * Licensed