Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2733
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r198614590
--- Diff: dev-tools/travis/travis-script.sh ---
@@ -31,7 +31,14 @@ else
# Travis only has 3GB of memory, lets use 1GB for build, and 1.5GB for
forked
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197857993
--- Diff: storm-core/test/resources/log4j2-test.xml ---
@@ -23,7 +23,8 @@
-
+
+
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197857694
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Time.java ---
@@ -185,8 +173,17 @@ public static void advanceTimeNanos(long nanos) {
if
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197857719
--- Diff: storm-core/pom.xml ---
@@ -184,6 +184,10 @@
mockito-core
test
+
+
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197857597
--- Diff: dev-tools/travis/travis-script.sh ---
@@ -31,7 +31,14 @@ else
# Travis only has 3GB of memory, lets use 1GB for build, and 1.5GB for
forked
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197836264
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Time.java ---
@@ -185,8 +173,17 @@ public static void advanceTimeNanos(long nanos) {
if
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197831240
--- Diff: dev-tools/travis/travis-script.sh ---
@@ -31,7 +31,14 @@ else
# Travis only has 3GB of memory, lets use 1GB for build, and 1.5GB for
forked
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197836676
--- Diff: storm-core/pom.xml ---
@@ -184,6 +184,10 @@
mockito-core
test
+
+
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197837001
--- Diff: storm-core/test/resources/log4j2-test.xml ---
@@ -23,7 +23,8 @@
-
+
+
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2733
STORM-3119: Build Storm with Java 10
https://issues.apache.org/jira/browse/STORM-3119
There are some changes in this PR that are only tangentially related to
building with JDK10, namely fixes
11 matches
Mail list logo
