Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2771
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207672905
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric;
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207665264
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -50,19 +61,19 @@ public static void startMetricsReporters(Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207663344
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -50,19 +61,19 @@ public static void startMetricsReporters(Map
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207640687
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207638261
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207636496
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -50,19 +61,19 @@ public static void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207601720
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric;
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207599113
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207594931
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -50,19 +61,19 @@ public static void startMetricsReporters(Map
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205520696
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205046141
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -88,19 +110,24 @@ public static void startMetricsReporters(Map
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205045839
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205045449
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric;
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205044870
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,79 +12,122 @@
package org.apache.storm.metric;
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204920511
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -88,19 +110,24 @@ public static void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204917201
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
---
@@ -312,7 +315,7 @@ public void launchDaemon() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204916859
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,79 +12,122 @@
package
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204915515
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204894886
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204891653
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -88,19 +110,24 @@ public static void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204890243
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204862238
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204860271
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204876125
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
---
@@ -312,7 +315,7 @@ public void launchDaemon() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204867270
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -88,19 +110,24 @@ public static void startMetricsReporters(Map
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204861682
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204875066
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,79 +12,122 @@
package org.apache.storm.metric;
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204862534
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric;
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204858543
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric;
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2771
STORM-3157: General improvement to StormMetricsRegistry
This contains and address the issues in #2763. This should help standardize
the process to register metrics and MetricSet in the future.
31 matches
Mail list logo
