Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-15 Thread via GitHub
jnioche commented on PR #3615: URL: https://github.com/apache/storm/pull/3615#issuecomment-1892317878 Thanks @Scomocouk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-15 Thread via GitHub
jnioche merged PR #3615: URL: https://github.com/apache/storm/pull/3615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-08 Thread via GitHub
Scomocouk commented on PR #3615: URL: https://github.com/apache/storm/pull/3615#issuecomment-1881677336 As suggested from my previous pull request (https://github.com/apache/storm/pull/3614), I have resubmitted this for merging into master instead of 2.4.x-branch -- This is an automated

[PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-08 Thread via GitHub
Scomocouk opened a new pull request, #3615: URL: https://github.com/apache/storm/pull/3615 ## What is the purpose of the change Fixes STORM-4017 I raised recently so that isAnyWindowsProcessAlive works correctly in Windows. What prompted this was that we are evaluating Storm 2.5.0

Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-08 Thread via GitHub
Scomocouk closed pull request #3614: STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids URL: https://github.com/apache/storm/pull/3614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-08 Thread via GitHub
rzo1 commented on PR #3614: URL: https://github.com/apache/storm/pull/3614#issuecomment-1881242017 Therefore, I suggest to target `main` with the change and post a related mail on dev@ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-08 Thread via GitHub
rzo1 commented on PR #3614: URL: https://github.com/apache/storm/pull/3614#issuecomment-1881216003 Thanks for the PR. I definitley see it in the next release of Storm. However, given the limited amount of volunteers working on Storm (it was discussed to move it to the attic a couple of mont

Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-08 Thread via GitHub
Scomocouk commented on PR #3614: URL: https://github.com/apache/storm/pull/3614#issuecomment-1881120469 This request is to merge to 2.4.x-branch. However, we are actaully working with 2.5.0 but notice there is no corresponding 2.5.x-branch to merge in to. Can this be added? (We are working

[PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)

2024-01-08 Thread via GitHub
Scomocouk opened a new pull request, #3614: URL: https://github.com/apache/storm/pull/3614 ## What is the purpose of the change Fixes STORM-4017 I raised recently so that isAnyWindowsProcessAlive works correctly in Windows. What prompted this was that we are evaluating Storm 2.5.0