[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates

2018-06-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2689 @vesense I am trying to get the RocketMQ example topology up and running so I can manually test that it is working, but there is no documentation on how to do it. I managed to download RocketMQ and

[GitHub] storm issue #2708: STORM-3098: Fixed method filterChangingBlobsFor()

2018-06-07 Thread zd-project
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2708 I extended the test to cover the testing of filterChangingBlob now. ---

Re: Running tests via Clojure REPL

2018-06-07 Thread Kishorkumar Patil
Please run On master branch, please run `mvn install -DskipTests;` before running * ./dev-tools/test-ns.py org.apache.storm.drpc-test*. main: [INFO] Executed tasks [INFO] [INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ storm-core --- [INFO] [INFO] --- clojure-maven-plugin:1.7.1:test

[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates

2018-06-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2689 @ptgoetz I am trying to run all of the examples/tests I can to be sure that I didn't break anything when I upgraded versions. One of the issues I am running into is around the spring framework in

[GitHub] storm issue #2707: STORM-3097: Remove storm-druid

2018-06-07 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2707 Thanks, +1 again ---

Re: Running tests via Clojure REPL

2018-06-07 Thread Vivian Kong
Thanks Kishor! I tried the script but it didn't seem to be working. It didn't find any tests to run: ... main: [INFO] Executed tasks [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ storm-core --- [INFO] [INFO] --- clojure-maven-plugin:1.7.1:test (test-clojure) @ storm-core

[GitHub] storm issue #2706: STORM-3097: deprecate storm-druid (1.x)

2018-06-07 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2706 +1 ---

[GitHub] storm issue #2703: [STORM-3094] : Added topology name validation at client s...

2018-06-07 Thread ManoharVanam
Github user ManoharVanam commented on the issue: https://github.com/apache/storm/pull/2703 Yes , here we are handling two things, 1. Fail fast without uploading the jar 2. Giving clear message to the user at the client side. ---

[GitHub] storm pull request #2690: STORM-3061: Clean up some storm-druid dependencies

2018-06-07 Thread revans2
Github user revans2 closed the pull request at: https://github.com/apache/storm/pull/2690 ---

[GitHub] storm issue #2690: STORM-3061: Clean up some storm-druid dependencies

2018-06-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2690 Because of STORM-3097 #2707 I am closing this pull request. I might reopen it if STORM-3097 goes a different direction. ---

[GitHub] storm issue #2706: STORM-3097: deprecate storm-druid (1.x)

2018-06-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2706 Thanks @srdo I updated the docs to include the deprecated message. ---

[GitHub] storm issue #2707: STORM-3097: Remove storm-druid

2018-06-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2707 Thanks @srdo I removed storm-druid.md and removed the link form index.md (which was the only one I could find) ---

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2698 ---

Re: Running tests via Clojure REPL

2018-06-07 Thread Kishorkumar Patil
Try *./dev-tools/test-ns.py org.apache.storm.drcp_test* Kishor On Thu, Jun 7, 2018 at 11:00 AM, Vivian Kong wrote: > > > Hi, > > I am following > https://github.com/apache/storm/blob/master/DEVELOPER.md#testing-1 to try > to run a subset of storm-core tests via the Clojure REPL but I

Running tests via Clojure REPL

2018-06-07 Thread Vivian Kong
Hi, I am following https://github.com/apache/storm/blob/master/DEVELOPER.md#testing-1 to try to run a subset of storm-core tests via the Clojure REPL but I couldn't figured out how to do that. Tried the following but hit an exception (see below). I appreciate any pointers/examples on how to

[GitHub] storm issue #2708: STORM-3098: Fixed method filterChangingBlobsFor()

2018-06-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2708 Conceptually the change looks like a good fix. When I first wrote the code I would launch a topology which depended on several blobs, some that required a relaunch of the worker and others

[GitHub] storm pull request #2708: STORM-3098: Fixed method filterChangingBlobsFor()

2018-06-07 Thread zd-project
GitHub user zd-project opened a pull request: https://github.com/apache/storm/pull/2708 STORM-3098: Fixed method filterChangingBlobsFor() You can merge this pull request into a Git repository by running: $ git pull https://github.com/zd-project/storm STORM-3098 Alternatively