Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928671
--- Diff: pom.xml ---
@@ -169,8 +169,9 @@
external/storm-redis
external/storm-eventhubs
external/flux
-examples
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928702
--- Diff: external/storm-solr/README.md ---
@@ -0,0 +1,188 @@
+# Storm Solr
+Storm and Trident integration for Apache Solr. This package includes a
bolt
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928692
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928682
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928717
--- Diff: external/storm-solr/pom.xml ---
@@ -0,0 +1,106 @@
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/702#issuecomment-140458502
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43548241
--- Diff:
storm-core/src/jvm/backtype/storm/serialization/SerializationFactory.java ---
@@ -81,8 +81,9 @@ public static Kryo getKryo(Map conf
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43548584
--- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java ---
@@ -30,18 +31,20 @@
private HashMap>> bundles =
new H
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549300
--- Diff:
storm-core/src/jvm/storm/trident/spout/OpaquePartitionedTridentSpoutExecutor.java
---
@@ -162,9 +162,9 @@ public void commit(TransactionAttempt
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549404
--- Diff:
storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java ---
@@ -233,8 +234,9 @@ public StormTopology buildTopology
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549539
--- Diff:
storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java ---
@@ -248,8 +250,9 @@ public StormTopology buildTopology
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/836#issuecomment-152646032
+1 LGTM. A few pinpoints only related with readability of the code that are
left to the discretion of the implementer.
---
If your project is set up for it, you can reply
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/836#issuecomment-152676783
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
801 - 813 of 813 matches
Mail list logo
