[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-28 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-202556630 It should be fairly easy to alter the UI to make it clear to users when this is disabled, as well as how to enable it. If we can do that I would support disabling it by

[GitHub] storm pull request: STORM-1030. Hive Connector Fixes.

2016-03-28 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/871#issuecomment-202559608 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-499

2014-09-30 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/274 STORM-499 This simply removes shaded/relocated artifacts from the published POM and promotes transitive dependencies. You can merge this pull request into a Git repository by running: $ git

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2014-09-30 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/254#issuecomment-57393403 @d2r It looks good to me, I think we just need an up-merge. @rick-kilgore can you merge your branch with master? --- If your project is set up for it, you can

[GitHub] storm pull request: STORM-422 Allow more arguments to be passed to...

2014-09-30 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/201#issuecomment-57400145 Thanks @Parth-Brahmbhatt, you beat me to it. I'll comment on [STORM-487](https://issues.apache.org/jira/browse/STORM-487) separately, but in my experience,

[GitHub] storm pull request: Storm 509. Make groups checking specific for S...

2014-09-30 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/273#issuecomment-57414452 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-428: extracted ITuple interface

2014-09-30 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/271#issuecomment-57414560 +1 This needs to be synced with master, but that will likely be an easy change. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: [STORM-507] Topology visualization should not ...

2014-09-30 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/270#issuecomment-57414646 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: Change clojure class called by `storm repl`

2014-09-30 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/263#issuecomment-57414742 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-210: Add storm-hbase module

2014-09-30 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/255#issuecomment-57415046 @harshach Would you be interested in acting as a sponsor (i.e. committing to help support and maintain the module)? Any other committers interested? --- If your

[GitHub] storm pull request: STORM-439: Replace purl.js with jquery url plu...

2014-09-30 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/242#issuecomment-57415388 +1 If no one minds, I'd like to merge this one so I can verify the licensing is correct (no code changed). --- If your project is set up for it, you can reply to

[GitHub] storm pull request: STORM-166:Nimbus HA solution based on Zookeepe...

2014-10-01 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/61#issuecomment-57552912 @yveschina The main concern I have is with catastrophic failure of a nimbus node during code distribution. I'm not sure it's acceptable to force users to

[GitHub] storm pull request: STORM-497: don't modify the mapping while the ...

2014-10-01 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/257#issuecomment-57559023 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2014-10-01 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/254#discussion_r18316629 --- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java --- @@ -26,8 +26,19 @@ public Integer zkPort = null; public String zkRoot

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2014-10-01 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/254#issuecomment-57561410 @rick-kilgore You can go ahead and close the other pull request. Also see my comment regarding throwing an exception if the configuration is out of whack. Once

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2014-10-01 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/254#discussion_r18323164 --- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java --- @@ -26,8 +26,19 @@ public Integer zkPort = null; public String zkRoot

[GitHub] storm pull request: STORM-514: Refer to post-graduation Storm webs...

2014-10-02 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/277#issuecomment-57593933 +1 Thanks @miguno! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: STORM-519 adding tuple as an input param to HB...

2014-10-07 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/283#issuecomment-58234789 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-488: Exit with 254 error code if storm C...

2014-10-07 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/278#issuecomment-58240854 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2014-10-07 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/254#issuecomment-58241961 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-506: Do not count bolt acks & fails in t...

2014-10-07 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/267#issuecomment-58242517 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-10-07 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/279#discussion_r18547500 --- Diff: DEVELOPER.md --- @@ -229,6 +229,9 @@ The following commands must be run from the top-level directory. # Build the code and run the tests

[GitHub] storm pull request: [STORM-386] Moved storm.js to multilang folder...

2014-10-07 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/265#issuecomment-58258916 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-10-21 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/279#discussion_r19171864 --- Diff: DEVELOPER.md --- @@ -229,6 +229,9 @@ The following commands must be run from the top-level directory. # Build the code and run the tests

[GitHub] storm pull request: STORM-538: Also shade com.google.thirdparty.pu...

2014-10-21 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/299#issuecomment-59982176 +1 targeted for 0.9.3-rc2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-513 check heartbeat from multilang subpr...

2014-10-21 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/286#issuecomment-59983717 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-511 update startOffset in PartitionManag...

2014-10-23 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/272#issuecomment-60306459 @viktortnk Thanks for your work on this. I made some minor changes and submitted a pull request to your repo. I confirmed that the issue is reproducible in 0.9.3

[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/293#issuecomment-60419007 @caofangkun If this pull request has been superseded by #296 would you mind closing this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: Update README.md

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/292#issuecomment-60419239 +1 Thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: Remove 'provided' from storm-kafka pom.xml exa...

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/290#issuecomment-60419385 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-529] Send fail(tup) when BasicBolt proc...

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/291#issuecomment-60422965 +1 I agree with @revans2, I don't think we need to wait for STORM-528 --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] storm pull request: STORM-307: reset LocalState if files are corru...

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/282#issuecomment-60423299 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-511 update startOffset in PartitionManag...

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/272#issuecomment-60423496 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-540: Change default time format in logs ...

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/301#issuecomment-60427539 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-513 check heartbeat from multilang subpr...

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/286#issuecomment-60438795 @itaifrenkel No, not that's available for use via the bolt API, but it's an interesting idea. You could effectively do the same by making the scheduler sta

[GitHub] storm pull request: STORM-513 check heartbeat from multilang subpr...

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/286#issuecomment-60438969 Since there were additional commits added to the pull request, we need to give it more time for others to review before merging, but I am still +1 for the patch. --- If

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/279#issuecomment-61857050 -1 Per my previous comment, this needs to be an environment variable, not a system property. The problem is that the way that the clojure unit tests are run

[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/298#issuecomment-61857797 -1 The storm platform itself does not require any native libraries, and the config option should be sufficient. --- If your project is set up for it, you can

[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61860848 -1 I agree with @HeartSaVioR that if we want an implementation of `ISpoutWaitStrategy` that takes into account the `streak` parameter, it should be a separate

[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/307#issuecomment-61882471 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61883299 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-492 with reverting previous merge

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/308#issuecomment-61897392 Thanks @HeartSaVioR. No need to apologize, we all make mistakes. The important part is that we have a community to review and catch them. When we do. :) I'm

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-61919968 @HeartSaVioR sorry for the delay. I will test and reply when I have the chance. I would encourage others to do the same as well. --- If your project is set up for it

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61923239 @clockfly thanks for participating in the review. Let's hold off on merging until others have had a chance to weigh in (we span many time zones). --- If your proje

[GitHub] storm pull request: use configured local hostname for reporting me...

2014-11-07 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/306#issuecomment-6089 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-216: Added Authentication and Authorizat...

2014-11-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/121#issuecomment-62839886 I also replied to the list, I'm +1 for merging to master once we create a 0.9.3 branch. The modifications in the security branch have been QA'd fairly e

[GitHub] storm pull request: STORM-216: Added Authentication and Authorizat...

2014-11-13 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/121#issuecomment-62946641 @revans2 Yeah, I created that branch earlier today then got distracted by meetings before I could send out a notification. That branch is currently identical to master

[GitHub] storm pull request: Storm555: Storm json response should set chars...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/313#issuecomment-63092518 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/309#issuecomment-63092885 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-549: "topology.enable.message.timeouts" ...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/309#issuecomment-63108151 Thanks @SeanTAllen. I merged this into master and 0.9.3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-63127132 I tested this by applying it to the 0.9.3 branch and found problems with the unit tests (never-ending cycle of zookeeper reconnects, tests never complete

[GitHub] storm pull request: STORM-552:add new config storm.messaging.netty...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/311#issuecomment-63127667 @caofangkun Can you add some detail regarding what this patch fixes? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/302#issuecomment-63128505 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-513 check heartbeat from multilang subpr...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/286#issuecomment-63134028 +1 (again) @harshach The problem you saw was due to two of the `storm.rb` files being out of sync. I will correct that at merge time. --- If your project is set

[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/302#issuecomment-63138277 @revans2 I think we can merge this and open a JIRA for discussing changing the metrics infrastructure. --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...

2014-11-17 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/315#issuecomment-63318696 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: Storm555: Storm json response should set chars...

2014-11-17 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/313#issuecomment-63367628 Thanks @Parth-Brahmbhatt. I merged this into the master and 0.9.3 branches. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...

2014-11-17 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/315#issuecomment-63373190 Thanks @xiaokang. I merged this into the master and 0.9.3 branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-567: Move Storm Documentation/Website fr...

2014-11-26 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/330 STORM-567: Move Storm Documentation/Website from SVN to git This is a work in progress on migrating the storm website/documentation to git in order to make it easier for the community to contribute

[GitHub] storm pull request: STORM-567: Move Storm Documentation/Website fr...

2014-11-26 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/330#issuecomment-64701658 I should also mention the site is statically generated using [jekyll](http://jekyllrb.com). First install jekyll (assuming you have ruby installed

[GitHub] storm pull request: STORM-567: Move Storm Documentation/Website fr...

2014-12-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/330#issuecomment-65824578 @revans2 Merged. I also added a README with instructions for generating and publishing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: STORM-544 Fix outdated documents

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/340#issuecomment-66828662 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-586: TridentKafkaEmitter should catch up...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/339#issuecomment-66829121 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: typo

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/333#issuecomment-66829256 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-391] KafkaSpout to await for the topic

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/338#issuecomment-66830619 @Lewuathe Here is the exception: https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/common/UnknownTopicOrPartitionException.scala I'd rath

[GitHub] storm pull request: Performance improvement: Fix for https://issue...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/343#issuecomment-66830696 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-583: Initiali check-in for storm-eventhu...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/336#discussion_r21771427 --- Diff: external/storm-eventhubs/pom.xml --- @@ -0,0 +1,107 @@ + --- End diff -- Need apache license header. --- If your project is set up

[GitHub] storm pull request: STORM-583: Initiali check-in for storm-eventhu...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/336#issuecomment-66832916 I would support pulling this in, but we need additional committers to approve it, and one or more to volunteer as sponsor(s). As @revans2 mentioned, this is a

[GitHub] storm pull request: STORM-577:supervisor heartbeat and handle ev...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/332#issuecomment-66833294 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-66836806 @tedxia This pull request has merge conflicts, would you mind syncing up with the master branch? @nathanmarz There's been a considerable amount of discu

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/254#issuecomment-66837722 +1 (again). Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: STORM-583: Initiali check-in for storm-eventhu...

2015-01-28 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/336#issuecomment-71903553 +1 for accepting this as a code donation from Microsoft and moving forward with the IP clearance process. COMMTTERS please note that this must not be merged until

[GitHub] storm pull request: STORM-583: Initiali check-in for storm-eventhu...

2015-01-28 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/336#issuecomment-71907274 @shanyu Also, once the source code tarball for IP clearance has been created, please don't add any commits to this pull request. Any necessary modifications can

[GitHub] storm pull request: STORM-130. Supervisor getting killed due to ja...

2015-01-28 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/400#issuecomment-71970386 @harshach One nit: white space changes make the diff harder to read. (Though appending '?w=1' to the URL will force github to ignore white space.)

[GitHub] storm pull request: Storm 631: refactoring kafka connector code.

2015-02-02 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/387#issuecomment-72533983 @Parth-Brahmbhatt, @wurstmeister, @ogorun, @harshach: Forgive me for hijacking this pull request discussion, but it seems like we have a number of efforts/JIRAs

[GitHub] storm pull request: Storm 631: refactoring kafka connector code.

2015-02-02 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/387#issuecomment-72551762 STORM-650 created. Let's try to focus discussion/efforts there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] storm pull request: [STORM-400] Thrift upgrade to thrift-0.9.2

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/410#issuecomment-72722775 Looks like this needs an up merge, but I'm +1 for the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] storm pull request: STORM-637: Integrate PartialKeyGrouping into s...

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/404#issuecomment-72723482 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/401#issuecomment-72725245 +1. I'd also like to see this back-ported to the 0.9.3 branch, but that shouldn't block this from getting merged to master. --- If your project is set up for i

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24036406 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24036567 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24037306 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24037432 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24038992 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java --- @@ -0,0 +1,213 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24039341 --- Diff: external/storm-jdbc/pom.xml --- @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/374#issuecomment-72735923 Overall I think this is a good start and I am supportive. @revans2 brought up some good points and I tried to expand/clarify in several places. I feel more efficient use

[GitHub] storm pull request: STORM-656: Document "external" modules and "Co...

2015-02-03 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/416 STORM-656: Document "external" modules and "Committer Sponsors" JIRA: https://issues.apache.org/jira/browse/STORM-656 You can merge this pull request into a Git repository by

[GitHub] storm pull request: STORM-656: Document "external" modules and "Co...

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/416#issuecomment-72779670 @HeartSaVioR, yes. Basically just an indicator that at least one committer (i.e. someone with commit rights) is interested in supporting a module. But your

[GitHub] storm pull request: update bylaws for adoption discussion

2015-02-05 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/419 update bylaws for adoption discussion Please see [DISCUSS] thread on d...@storm.apache.com NOTE: This pull request should not be merged until a successful VOTE for adoption has taken place

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-11 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/374#issuecomment-73918034 +1 looks good to me. I don't think we need the LICENSE file here, but that's a trivial change that can be done at merge time. --- If your project is set up f

[GitHub] storm pull request: STORM-651: Rename "ui" service to "storm ui" a...

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/427#issuecomment-74098372 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: Storm-649: Storm HDFS test topologies should w...

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/426#issuecomment-74098599 +1, looks fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/418#issuecomment-74099551 +1 I'll presume +1 approvals carry over from #401, but allow others time to comment. --- If your project is set up for it, you can reply to this email and

[GitHub] storm pull request: STORM-670: restore java 1.6 compatibility (sto...

2015-02-12 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/431 STORM-670: restore java 1.6 compatibility (storm-kafka) Not sure how long we want to cling to 1.6 compatibility, but this is a very small change. You can merge this pull request into a Git

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/415#issuecomment-74114183 +1 The typo fix is a non-code change so I'm fine with including that. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] storm pull request: STORM-658:when config topology.acker.executors...

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/417#issuecomment-74128755 -1. This breaks trident functionality if `topology.acker.executors` is `null` in `storm.yaml` and not overridden in the topology conf. I've not dug too far

[GitHub] storm pull request: STORM-640. Storm UI vulnerable to poodle attac...

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/412#issuecomment-74145215 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-641. Add total number of topologies to a...

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/411#issuecomment-74145467 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-652. Use latest junit 4.11 .

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/409#issuecomment-74145938 +1 The upgrade does not seem to cause any issues with tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: Storm-539. Storm hive bolt and trident state.

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/350#issuecomment-74159664 +1 You should probably list yourself as a committer sponsor. ;) (You can add me as well if you like.) --- If your project is set up for it, you can reply to

<    1   2   3   4   5   6   7   8   >