[GitHub] stratos pull request: Cleaning and Formatting Code

2016-05-20 Thread pamod
Github user pamod commented on a diff in the pull request: https://github.com/apache/stratos/pull/420#discussion_r64026803 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -93,7 +92,6 @@ im

[GitHub] stratos pull request: Cleaning and Formatting

2015-09-09 Thread imesh
Github user imesh commented on the pull request: https://github.com/apache/stratos/pull/459#issuecomment-138889051 Thanks for the code clean up fix Thanuja! Now this is merged to master branch. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] stratos pull request: Cleaning and Formatting

2015-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/stratos/pull/459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] stratos pull request: Cleaning and Formatting

2015-09-08 Thread Thanu
GitHub user Thanu opened a pull request: https://github.com/apache/stratos/pull/459 Cleaning and Formatting This P/R includes cleaning and formatting some classes in Cloud-Controller. Following changes are included: 1. Fix for SonarQube Analysis issues: remove unused im

[GitHub] stratos pull request: Cleaning and Formatting

2015-09-08 Thread Thanu
Github user Thanu commented on the pull request: https://github.com/apache/stratos/pull/444#issuecomment-138546698 Closing this P/R because its outdated and has merge conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] stratos pull request: Cleaning and Formatting

2015-09-08 Thread Thanu
Github user Thanu closed the pull request at: https://github.com/apache/stratos/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] stratos pull request: Cleaning and Formatting

2015-08-20 Thread Thanu
GitHub user Thanu opened a pull request: https://github.com/apache/stratos/pull/444 Cleaning and Formatting This P/R includes cleaning and formatting some classes in Cloud-Controller. You can merge this pull request into a Git repository by running: $ git pull https://github.co

[GitHub] stratos pull request: Cleaning and Formatting Code

2015-08-10 Thread rekathiru
Github user rekathiru commented on the pull request: https://github.com/apache/stratos/pull/420#issuecomment-129382653 Sorry for the noise..There was a NULL check already added in the code. So no need of doing it.. --- If your project is set up for it, you can reply to this email and

[GitHub] stratos pull request: Cleaning and Formatting Code

2015-08-10 Thread rekathiru
Github user rekathiru commented on the pull request: https://github.com/apache/stratos/pull/420#issuecomment-129368585 Hi Thanuja, Please add the application null check to the if condition. Otherwise there could be a possibility for NPE in the following if condition.

[GitHub] stratos pull request: Cleaning and Formatting Code

2015-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/stratos/pull/420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] stratos pull request: Cleaning and Formatting Code

2015-08-07 Thread Thanu
GitHub user Thanu opened a pull request: https://github.com/apache/stratos/pull/420 Cleaning and Formatting Code Cleaning and Formatting Code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Thanu/stratos master Alternatively you