Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Rajkumar Rajaratnam
Fixed in 5c63e93026c580b373dbb513c1ae1c On Fri, Nov 13, 2015 at 5:30 PM, Rajkumar Rajaratnam wrote: > Had an offline discussion with Akila, Sajith & Gayan. > > It is not a good idea to introduce new configuration files in a minor > release. > > So we are going to read the same cartridge-config.p

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Rajkumar Rajaratnam
Had an offline discussion with Akila, Sajith & Gayan. It is not a good idea to introduce new configuration files in a minor release. So we are going to read the same cartridge-config.properties fie from AS. For that, we are moving CartridgeConfigFileReader class from SM to Common package and call

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Rajkumar Rajaratnam
On Fri, Nov 13, 2015 at 4:54 PM, Sajith Kariyawasam wrote: > From which component do we read puppet.* values? > ​AS. ​ > > On Fri, Nov 13, 2015 at 4:19 PM, Rajkumar Rajaratnam > wrote: > >> Akila, +1. >> >> @All, What do you think about the following structure for >> stratos-manager.xml? It i

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Sajith Kariyawasam
>From which component do we read puppet.* values? On Fri, Nov 13, 2015 at 4:19 PM, Rajkumar Rajaratnam wrote: > Akila, +1. > > @All, What do you think about the following structure for > stratos-manager.xml? It is similar to autoscaler.xml. > > > > > localhost >

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Rajkumar Rajaratnam
Akila, +1. @All, What do you think about the following structure for stratos-manager.xml? It is similar to autoscaler.xml. localhost 9443 services/CloudControllerService 30 localhost

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Akila Ravihansa Perera
Hi, I'd prefer not to use System variables to pass service URLs. Any component which needs those can read from the file right? Thanks. On Fri, Nov 13, 2015 at 3:15 PM, Rajkumar Rajaratnam wrote: > Hi All, > > Thanks for your thoughts. > > Will do the following. > > 1) Lets remove service URLs

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Rajkumar Rajaratnam
Hi All, Thanks for your thoughts. Will do the following. 1) Lets remove service URLs (AS, SM, CC & DAS) from cartridge-config.properties file 2) Lets included these service URLs in stratos-manager.xml (new) and autoscaler.xml. CC doesn't need these URLs. 3) Configuration file (stratos-manager.xm

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Sajith Kariyawasam
What if we keep stratos-manger.xml, cloud-controller.xml (already have) and autoscaler.xml (already have) file and move only the relevant configs to each of those files? For eg, the values need to be read by SM should only be in stratos-manager.xml. I think cartridge-config.properties file was mean

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Thanuja Uruththirakodeeswaran
On Fri, Nov 13, 2015 at 12:53 PM, Gayan Gunarathne wrote: > Hi, > > On Fri, Nov 13, 2015 at 12:42 PM, Rajkumar Rajaratnam > wrote: > >> Hi Devs, >> >> This file content is as below. >> >> >> >> >> >> >> >> >> >> *autoscaler.service.url=https://localhost:9443/services/AutoscalerService/ >>

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-13 Thread Isuru Haththotuwa
Additionally, IMO we can rename this configuration file to have a generic name (stratos.xml/stratos.properties). wdyt? On Fri, Nov 13, 2015 at 12:53 PM, Gayan Gunarathne wrote: > Hi, > > On Fri, Nov 13, 2015 at 12:42 PM, Rajkumar Rajaratnam > wrote: > >> Hi Devs, >> >> This file content is as b

Re: [Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-12 Thread Gayan Gunarathne
Hi, On Fri, Nov 13, 2015 at 12:42 PM, Rajkumar Rajaratnam wrote: > Hi Devs, > > This file content is as below. > > > > > > > > > > *autoscaler.service.url=https://localhost:9443/services/AutoscalerService/ > cloud.controller.service.url=https:/

[Stratos 4.1.5] [Blocker] Issues with cartridge-config.properties file

2015-11-12 Thread Rajkumar Rajaratnam
Hi Devs, This file content is as below. *autoscaler.service.url=https://localhost:9443/services/AutoscalerService/ cloud.controller.service.url=https://localhost:9443/services/CloudControllerService/