Re: Doubts on the patch application process

2014-06-30 Thread Udara Liyanage
Hi Chris, Sorry I did not see the "kernel" part. Most of the times we might not need to make kernel patches since they will be created by carbon kernel developers. @pradeep may provide a better answer. On Mon, Jun 30, 2014 at 12:30 PM, chris snow wrote: > Hi Udara. > > The instructions you gi

Re: Doubts on the patch application process

2014-06-30 Thread chris snow
Hi Udara. The instructions you give above for Patch type B are quite different to the instructions here [1]. Am I correct in thinking that the instructions at [1] will never be needed on the Stratos project? Many thanks, Chris --- [1] https://docs.wso2.org/display/Carbon410/Creating+a+Carbon+

Re: Doubts on the patch application process

2014-06-29 Thread Udara Liyanage
Hi Chris, Patch type A are source code patches which are merged to the Stratos source code. Patch type B are binary patches which are meant to be applied to a running Stratos setup. So Stratos commiters will not provide them. Above is the short answer for the query.Let me explain more a bit. Lets

Re: Doubts on the patch application process

2014-06-29 Thread Praneesha Chandrasiri
Hi Udara, Would you please help me to provide answers to the further doubts mentioned by Chris in [1] as follows? I'm still a bit confused. It seems that there are two types of patches: A) diffs created using a version control system (e.g. diff's/pull requests) B) archive files that have a well

Re: Doubts on the patch application process

2014-06-26 Thread Praneesha Chandrasiri
Hi Chris, Can we resolve this JIRA now? On Thu, Jun 26, 2014 at 8:40 PM, Praneesha Chandrasiri wrote: > Thanks a lot Udara! > > > On Thu, Jun 26, 2014 at 5:30 PM, Udara Liyanage wrote: > >> >> >> >> On Thu, Jun 26, 2014 at 1:37 PM, Praneesha Chandrasiri < >> pranee...@wso2.com> wrote: >> >>>

Re: Doubts on the patch application process

2014-06-26 Thread Praneesha Chandrasiri
Thanks a lot Udara! On Thu, Jun 26, 2014 at 5:30 PM, Udara Liyanage wrote: > > > > On Thu, Jun 26, 2014 at 1:37 PM, Praneesha Chandrasiri > wrote: > >> Hi devs, >> >> Shall we provide answers to the following doubts mentioned by Chris in >> [1]? >> >> 1) Patches will need to be applied by both

Re: Doubts on the patch application process

2014-06-26 Thread Udara Liyanage
On Thu, Jun 26, 2014 at 1:37 PM, Praneesha Chandrasiri wrote: > Hi devs, > > Shall we provide answers to the following doubts mentioned by Chris in [1]? > > 1) Patches will need to be applied by both committers and non-committers? > Contributers who are not yet commiters can send patches which a

Doubts on the patch application process

2014-06-26 Thread Praneesha Chandrasiri
Hi devs, Shall we provide answers to the following doubts mentioned by Chris in [1]? 1) Patches will need to be applied by both committers and non-committers? 2) Are there different sorts of patches? a) git diff patches containing source code changes (created as described in step 3 here [1]) b) s