[jira] [Commented] (STREAMS-70) Generic Json Processors

[ https://issues.apache.org/jira/browse/STREAMS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002679#comment-14002679 ] ASF GitHub Bot commented on STREAMS-70: --- Github user asfgit closed the pull request

[GitHub] incubator-streams pull request: Streams 70

Github user asfgit closed the pull request at: https://github.com/apache/incubator-streams/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] incubator-streams pull request: Streams 33

GitHub user steveblackmon opened a pull request: https://github.com/apache/incubator-streams/pull/21 Streams 33 Implements/Tests basic functionality in the pig runtime You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubat

[GitHub] incubator-streams pull request: Streams 70

Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/20#issuecomment-43572511 Other than above comments, I think it looks good. IMHO, you should feel free to commit once you change them. --- If your project is set up for it, you can r

[GitHub] incubator-streams pull request: Streams 70

Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/20#discussion_r12822529 --- Diff: streams-contrib/streams-processor-json/src/test/java/org/apache/streams/json/test/JsonPathExtractorTest.java --- @@ -0,0 +1,82 @@ +

[GitHub] incubator-streams pull request: Streams 70

Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/20#discussion_r12822550 --- Diff: streams-contrib/streams-processor-json/src/main/java/org/apache/streams/json/JsonPathFilter.java --- @@ -0,0 +1,171 @@ +package org

[jira] [Commented] (STREAMS-70) Generic Json Processors

[ https://issues.apache.org/jira/browse/STREAMS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002520#comment-14002520 ] ASF GitHub Bot commented on STREAMS-70: --- GitHub user steveblackmon opened a pull req

[GitHub] incubator-streams pull request: Streams 70

GitHub user steveblackmon opened a pull request: https://github.com/apache/incubator-streams/pull/20 Streams 70 Reopening STREAMS-70 PR. All comments have been addressed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/inc

[GitHub] incubator-streams pull request: Streams 74

Github user steveblackmon closed the pull request at: https://github.com/apache/incubator-streams/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[jira] [Commented] (STREAMS-60) WebHdfsReader should set timestamp when reading documents

[ https://issues.apache.org/jira/browse/STREAMS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002467#comment-14002467 ] ASF GitHub Bot commented on STREAMS-60: --- Github user steveblackmon closed the pull r

[GitHub] incubator-streams pull request: STREAMS-60, STREAMS-70

Github user steveblackmon commented on the pull request: https://github.com/apache/incubator-streams/pull/12#issuecomment-43563498 closing, will reopen from apache branch instead of w2ogroup branch --- If your project is set up for it, you can reply to this email and have your reply a

[jira] [Commented] (STREAMS-60) WebHdfsReader should set timestamp when reading documents

[ https://issues.apache.org/jira/browse/STREAMS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002466#comment-14002466 ] ASF GitHub Bot commented on STREAMS-60: --- Github user steveblackmon commented on the

[GitHub] incubator-streams pull request: STREAMS-60, STREAMS-70

Github user steveblackmon closed the pull request at: https://github.com/apache/incubator-streams/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[jira] [Commented] (STREAMS-87) TwitterTimelineProvider needs to allow for backoff

[ https://issues.apache.org/jira/browse/STREAMS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002441#comment-14002441 ] ASF GitHub Bot commented on STREAMS-87: --- Github user smashew commented on a diff in

[GitHub] incubator-streams pull request: STREAMS-87 | We now try to collect...

Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/19#discussion_r12817799 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -116,10

[jira] [Commented] (STREAMS-87) TwitterTimelineProvider needs to allow for backoff

[ https://issues.apache.org/jira/browse/STREAMS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002443#comment-14002443 ] ASF GitHub Bot commented on STREAMS-87: --- Github user mfranklin commented on a diff i

[GitHub] incubator-streams pull request: STREAMS-87 | We now try to collect...

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/19#discussion_r12817778 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -116,10 +1

[jira] [Commented] (STREAMS-87) TwitterTimelineProvider needs to allow for backoff

[ https://issues.apache.org/jira/browse/STREAMS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002436#comment-14002436 ] ASF GitHub Bot commented on STREAMS-87: --- Github user smashew commented on a diff in

[GitHub] incubator-streams pull request: STREAMS-87 | We now try to collect...

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/19#discussion_r12817666 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -116,10 +1

[jira] [Commented] (STREAMS-87) TwitterTimelineProvider needs to allow for backoff

[ https://issues.apache.org/jira/browse/STREAMS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002433#comment-14002433 ] ASF GitHub Bot commented on STREAMS-87: --- Github user mfranklin commented on a diff i

[GitHub] incubator-streams pull request: STREAMS-87 | We now try to collect...

Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/19#discussion_r12817536 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -116,10

[jira] [Created] (STREAMS-88) TwitterEventClassifier does not react as expected to 'User' objects

Robert Douglas created STREAMS-88: - Summary: TwitterEventClassifier does not react as expected to 'User' objects Key: STREAMS-88 URL: https://issues.apache.org/jira/browse/STREAMS-88 Project: Streams

[jira] [Commented] (STREAMS-60) WebHdfsReader should set timestamp when reading documents

[ https://issues.apache.org/jira/browse/STREAMS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002254#comment-14002254 ] ASF GitHub Bot commented on STREAMS-60: --- Github user steveblackmon commented on a di

[jira] [Commented] (STREAMS-60) WebHdfsReader should set timestamp when reading documents

[ https://issues.apache.org/jira/browse/STREAMS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002257#comment-14002257 ] ASF GitHub Bot commented on STREAMS-60: --- Github user steveblackmon commented on the

[jira] [Commented] (STREAMS-87) TwitterTimelineProvider needs to allow for backoff

[ https://issues.apache.org/jira/browse/STREAMS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002252#comment-14002252 ] ASF GitHub Bot commented on STREAMS-87: --- GitHub user robdouglas opened a pull reques

[GitHub] incubator-streams pull request: STREAMS-60, STREAMS-70

Github user steveblackmon commented on the pull request: https://github.com/apache/incubator-streams/pull/12#issuecomment-43548135 @mfranklin updated per pull request feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-streams pull request: STREAMS-60, STREAMS-70

Github user steveblackmon commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/12#discussion_r12812755 --- Diff: streams-contrib/streams-processor-json/src/main/java/org/apache/streams/json/JsonPathFilter.java --- @@ -0,0 +1,149 @@ +package

[GitHub] incubator-streams pull request: STREAMS-87 | We now try to collect...

GitHub user robdouglas opened a pull request: https://github.com/apache/incubator-streams/pull/19 STREAMS-87 | We now try to collect an ID's timeline put to 5 times befor... ...e giving up You can merge this pull request into a Git repository by running: $ git pull https://gith

[jira] [Created] (STREAMS-87) TwitterTimelineProvider needs to allow for backoff

Robert Douglas created STREAMS-87: - Summary: TwitterTimelineProvider needs to allow for backoff Key: STREAMS-87 URL: https://issues.apache.org/jira/browse/STREAMS-87 Project: Streams Issue Ty

[GitHub] incubator-streams pull request: Streams 86

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12812532 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -246,9 +28

[GitHub] incubator-streams pull request: Streams 86

Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12812492 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -246,9 +

[GitHub] incubator-streams pull request: Streams 86

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12812452 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -246,9 +28

[jira] [Commented] (STREAMS-60) WebHdfsReader should set timestamp when reading documents

[ https://issues.apache.org/jira/browse/STREAMS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002224#comment-14002224 ] ASF GitHub Bot commented on STREAMS-60: --- Github user steveblackmon commented on a di

[GitHub] incubator-streams pull request: Streams 86

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12812370 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -54,12 +72

[GitHub] incubator-streams pull request: STREAMS-60, STREAMS-70

Github user steveblackmon commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/12#discussion_r12812340 --- Diff: streams-contrib/streams-processor-json/src/main/java/org/apache/streams/json/JsonPathExtractor.java --- @@ -0,0 +1,119 @@ +pack

[GitHub] incubator-streams pull request: Streams 86

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12812291 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -45,6 +62,

[GitHub] incubator-streams pull request: Streams 86

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12812241 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -54,12 +72

[GitHub] incubator-streams pull request: Streams 86

Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12812061 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -246,9 +

[GitHub] incubator-streams pull request: Streams 86

Github user robdouglas commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12811972 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -54,12

[GitHub] incubator-streams pull request: Streams 74

Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/18#issuecomment-43546216 :-1: If I understand this, correctly, this automatically adds headers to the files in the repository. I am all for having rat check the files, for headers,

[GitHub] incubator-streams pull request: Streams 74

Github user smashew commented on the pull request: https://github.com/apache/incubator-streams/pull/18#issuecomment-43546201 Kind of a large commit... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] incubator-streams pull request: Streams 86

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12811822 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -246,9 +28

[GitHub] incubator-streams pull request: Streams 86

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12811784 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -54,12 +72

[GitHub] incubator-streams pull request: Streams 86

Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12811736 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -116,17 +1

[GitHub] incubator-streams pull request: Streams 74

GitHub user steveblackmon opened a pull request: https://github.com/apache/incubator-streams/pull/18 Streams 74 Ensures that new contributions contain a valid license header when check-file-header is part of the maven plan. Headers can also be auto-generated with update-file-heade

[GitHub] incubator-streams pull request: Streams 86

Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/17#issuecomment-43544336 :+1: I will commit this tomorrow, unless there are objections --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-streams pull request: Streams 86

Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/17#discussion_r12810177 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -246,9 +

[GitHub] incubator-streams pull request: Streams 86

GitHub user robdouglas opened a pull request: https://github.com/apache/incubator-streams/pull/17 Streams 86 Added in Reentrant read and write locks anytime the provider queue is being updated or read from. This should ensure that we do not have situations where data is lost betwee

[jira] [Commented] (STREAMS-80) StreamsProcressorTask and StreamsPersistWriterTask are BROKEN

[ https://issues.apache.org/jira/browse/STREAMS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002005#comment-14002005 ] ASF GitHub Bot commented on STREAMS-80: --- Github user smashew commented on the pull r

[GitHub] incubator-streams pull request: Fixed bug for STREAMS-80

Github user smashew commented on the pull request: https://github.com/apache/incubator-streams/pull/15#issuecomment-43531042 Essentially, once the provider is terminated the hose is 'shut off' and all the remaining queues deplete until they are satisfied, however long that takes. ---

[jira] [Commented] (STREAMS-80) StreamsProcressorTask and StreamsPersistWriterTask are BROKEN

[ https://issues.apache.org/jira/browse/STREAMS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002003#comment-14002003 ] ASF GitHub Bot commented on STREAMS-80: --- Github user smashew commented on the pull r

[GitHub] incubator-streams pull request: Fixed bug for STREAMS-80

Github user smashew commented on the pull request: https://github.com/apache/incubator-streams/pull/15#issuecomment-43530900 There are other ways to do it as well. Including having an executor thread that tracks the 'running' state by asking if there are active items in the queue. Thi

[jira] [Commented] (STREAMS-80) StreamsProcressorTask and StreamsPersistWriterTask are BROKEN

[ https://issues.apache.org/jira/browse/STREAMS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001985#comment-14001985 ] ASF GitHub Bot commented on STREAMS-80: --- Github user mfranklin commented on the pull

[GitHub] incubator-streams pull request: Fixed bug for STREAMS-80

Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/15#issuecomment-43529420 This does not appear to be the best way to solve for the problem you are encountering. The semantics of the setRunning(false) method indicate that I want the

[jira] [Commented] (STREAMS-81) Monitor thread pool never fully shuts down tasks in LocalStreamBuilder

[ https://issues.apache.org/jira/browse/STREAMS-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001740#comment-14001740 ] ASF GitHub Bot commented on STREAMS-81: --- Github user smashew closed the pull request

[GitHub] incubator-streams pull request: Overhaul of LocalStreamsBuilder

Github user smashew closed the pull request at: https://github.com/apache/incubator-streams/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] incubator-streams pull request: Overhaul of LocalStreamsBuilder

Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/16#issuecomment-43513667 Yes, please close this PR and submit new ones for each of the issues you noted above when you are able. We all have day jobs and understand that they take pr

[GitHub] incubator-streams pull request: Overhaul of LocalStreamsBuilder

Github user smashew commented on the pull request: https://github.com/apache/incubator-streams/pull/16#issuecomment-43510043 @mfranklin Thank you very much for your comments as always. Unfortunately, work demands will unfortunately delay my ability to conform to these require

[jira] [Commented] (STREAMS-60) WebHdfsReader should set timestamp when reading documents

[ https://issues.apache.org/jira/browse/STREAMS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001674#comment-14001674 ] ASF GitHub Bot commented on STREAMS-60: --- Github user mfranklin commented on the pull

[GitHub] incubator-streams pull request: STREAMS-60, STREAMS-70

Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/12#issuecomment-43501875 @steveblackmon Checking to make sure you saw this was reviewed. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] incubator-streams pull request: Overhaul of LocalStreamsBuilder

Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/16#issuecomment-43500256 Thanks for the patch. However, there are a few issues I see with it right off the bat: 1) It includes commits from another author. Your pull request