I'm forwarding a reference about handling PRs from Suneel Marthi (mentor)
for the Streams podling, which IMO might also be useful for the NetBeans
community to consider.
Regards, Ate
Forwarded Message
Subject: Submitting and Handling Github PRs
Date: Sat, 22 Oct 2016 16:
I've seen some use of Github PR comment templates/pre-filled forms to remind
the submitter to do all the necessary stuff:
- JIRA issue opened
- JIRA issue in the title
- Run contrib-check
- Link to Apache CLA form
- Anything else?
It's a nice place to put the info since it's not uncommon for peo
That is very helpful
On 10/22/16, 5:03 PM, "sblackmon" wrote:
That’s a nice PR tutorial page. We should add one like it to the streams
website.
+1 to squashing and referencing JIRA on every commit message as common
practice - should make it easier to follow what’s happened on ma
That’s a nice PR tutorial page. We should add one like it to the streams
website.
+1 to squashing and referencing JIRA on every commit message as common practice
- should make it easier to follow what’s happened on master branch.
Steve
On October 22, 2016 at 3:57:54 PM, Suneel Marthi (smar...@
Wanted to bring up 2 things about managing PRs:
1. Squash all commits before merging PRs to master
2. Include the jira in the final commit before merging to master
Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.
For reference, see
https://mahout.apache.org/develope
