Re: Proposed Action base class change

> Kind of depressing though... I'm trying to contribute, but so far all my ideas have > been shot down (but for good reasons, so I'm not bitter about it). Just have to > keep trying I suppose. :) But you (and the rest of us) can learn something from the ensuing discussion, even if your ideas ar

DO NOT REPLY [Bug 17165] - logic:iterate tag not releasing collections from memory

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31585] - Minor Memory Leak in Iterator Tag

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31230] - Multiple classes using deprecated DefinitionsUtil class

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31585] - Minor Memory Leak in Iterator Tag

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Bundles and JSTL

After further investigation, I don't see this is being done (at least in the 1.1 release - I have not investigated further) This is a straight forward fix. All I did to resolve this was extend the processLocale method in my request processor as follows: --- protected void processLocale(HttpServl

DO NOT REPLY [Bug 31585] - Minor Memory Leak in Iterator Tag

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: rev 54010 - struts/trunk/src/share/org/apache/struts/taglib/logic

Author: niallp Date: Thu Oct 7 12:43:39 2004 New Revision: 54010 Modified: struts/trunk/src/share/org/apache/struts/taglib/logic/IterateTag.java Log: Remove change made in Revision 54006 for Bug 31585 As pointed out by Kris Schneider this could cause Tag Pooling problems Modified: struts/tru

Re: Proposed Action base class change

I agree with the == comment, but even if you wanted to go hashCode, you could use System.identityHashCode( obj ); Quoting Paul Speed <[EMAIL PROTECTED]>: > I'd just like to point out that the only valid way to tell if two > objects are the same instance if to use ==. Any other approach will not

DO NOT REPLY [Bug 31585] - Minor Memory Leak in Iterator Tag

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31514] - Either insufficient docs on validwhen or a bug

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31585] - Minor Memory Leak in Iterator Tag

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: rev 54006 - struts/trunk/src/share/org/apache/struts/taglib/logic

Author: niallp Date: Thu Oct 7 11:42:52 2004 New Revision: 54006 Modified: struts/trunk/src/share/org/apache/struts/taglib/logic/IterateTag.java Log: Bug 31585 Minor Memory Leak in Iterator Tag reported by Jens Schumann Modified: struts/trunk/src/share/org/apache/struts/taglib/logic/IterateTa

Bundles and JSTL

Could we add code to either the request processor or the action servlet to add the default message resource defined in a struts.config to a scope (app/session/request) under the key "javax.servlet.jsp.jstl.fmt.localizationContext", so the default bundle works with fmt:message without having to do a

DO NOT REPLY [Bug 31585] - Minor Memory Leak in Iterator Tag

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31585] New: - Minor Memory Leak in Iterator Tag

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Proposed Action base class change

There are several companies that would agree ;-) On Thu, 2004-10-07 at 13:29, Paul Speed wrote: > It was bound to happen... sometimes it would be nice to have an "unsend" > button. :) Just need to work out that whole time/space continuum thing. > -Paul > > [EMAIL PROTECTED] wrote: > > > Bah2

Re: Proposed Action base class change

It was bound to happen... sometimes it would be nice to have an "unsend" button. :) Just need to work out that whole time/space continuum thing. -Paul [EMAIL PROTECTED] wrote: Bah2 ;-) Saw this message after I had already responded to the previous one Hiran --

RE: Proposed Action base class change

Bah2 ;-) Saw this message after I had already responded to the previous one Hiran - Hiran Chaudhuri SAG Systemhaus GmbH Elsenheimer Straße 11 80867 München Phone +49-89-54 74 21 34 Fax +49-89-54 74 21 99 > -Original Message- > From: Paul

RE: Proposed Action base class change

Hi, Paul. Just yesterday I wanted to make sure the HttpServletRequest I modified in a filter is the very same instance that arrives at the JSP, as I was wondering why getParameter() would return different results for the JSP. Having a "System.out.println(request)" in my filter and the same line

Re: Proposed Action base class change

Bah! Realized after I hit send that you were talking about logging. Others have already pointed out how to do that one using the System call. So, nevermind. -Paul Paul Speed wrote: I'd just like to point out that the only valid way to tell if two objects are the same instance if to use ==. Any

Re: Proposed Action base class change

I'd just like to point out that the only valid way to tell if two objects are the same instance if to use ==. Any other approach will not work. Comparing the toString() method results as you do is only really comparing the hashcodes... which are not unique by a long shot (I never assume peopl

Re: ViewSVN (was Re: Conversion from CVS to Subversion Complete)

Excellent, thanks very much. Matt Don Brown wrote: Yes, there is a version of viewcvs, viewsvn, for subversion: http://svn.apache.org/viewcvs.cgi/struts/?root=Apache-SVN Don Matt Bathje wrote: Hi all. Is there a "viewcvs.cgi" equivalent for the SVN Repository? I realize I can open the url in a b

ViewSVN (was Re: Conversion from CVS to Subversion Complete)

Yes, there is a version of viewcvs, viewsvn, for subversion: http://svn.apache.org/viewcvs.cgi/struts/?root=Apache-SVN Don Matt Bathje wrote: Hi all. Is there a "viewcvs.cgi" equivalent for the SVN Repository? I realize I can open the url in a browser and view the latest revision, but I liked t

RE: Proposed Action base class change

Hi, Mike. In that case I misunderstood your example code. This ToStringBuilder seems to do what I coded myself. I'll eventually try that and maybe switch over. Hiran - Hiran Chaudhuri SAG Systemhaus GmbH Elsenheimer Straße 11 80867 München Phone +49-89-54

Re: Conversion from CVS to Subversion Complete

Hi all. Is there a "viewcvs.cgi" equivalent for the SVN Repository? I realize I can open the url in a browser and view the latest revision, but I liked that you could see the history on the CVS version. In case its not clear what I am talking about: http://svn.apache.org/repos/asf/struts/trunk/

RE: Proposed Action base class change

wait a sec, I'm slightly confused. How is this static method different from your static method? Indeed, ToStringBuilder (as the name implies) assists in writing the toString method, but it also provides utility methods for representing objects as strings. There is no restriction on where it is u

RE: Proposed Action base class change

Okay, for the pedants out there, the *real* equivalent of Object's toString method is: public static String objectToString(Object obj) { if (obj == null) { return "null"; } else { return obj.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(obj));

RE: Proposed Action base class change

Is this really more convenient than simply overriding toString() ? - Mike On Thu, 2004-10-07 at 09:45, Kris Schneider wrote: > This should always give you the equivalent of Object's toString method: > > Integer.toHexString(System.identityHashCode(obj)). > > If anything gets added, I'd rather s

RE: Proposed Action base class change

Hi, Mike. Indeed I have not had a look at that class. But then, the ToStringBuilder makes it easier to write the toString method, while my approach saves me completely from writing it. Thanks for the hint anyway. Hiran - Hiran Chaudhuri SAG Systemhaus G

RE: Proposed Action base class change

This should always give you the equivalent of Object's toString method: Integer.toHexString(System.identityHashCode(obj)). If anything gets added, I'd rather see something like what's used in java.awt.Component. The toString method is implemented like: public String toString() { return getCl

RE: Proposed Action base class change

> With the static method I can apply my toString implementation to any object that > comes along - just what you need for debugging. I just wonder why the Apache > commons-beanutils does not provide such a method, and someone mentioned it might be > in commons-lang, but I could not find that ei

RE: Proposed Action base class change

> Well, that's the reason I put the idea out there... I can't think of every possible > angle to look at it from... If I thought I could, I wouldn't need to solicit > opinions in the first place. No one possibly could. Which is why Open Source is such an effective model for software development

RE: Proposed Action base class change

Frank, I also had to go a long way until I found this approach. It actually came to me when I saw in my project many data objects (= java beans) were generated using UML tools that did not care about the toString() method my way. Next I saw Castor XML/JAXB and JDO code generation, and finally h

RE: Proposed Action base class change

Another fair point. :) Well, that's the reason I put the idea out there... I can't think of every possible angle to look at it from... If I thought I could, I wouldn't need to solicit opinions in the first place. Kind of depressing though... I'm trying to contribute, but so far all my ideas hav

tiles-definition - role association issue

Hi, I know this is not a correct place to post this message. But I didn't get any response for this question in User Mailing list. Kindly provide me some inputs on my question. Regards, Ashutosh Q U E S T I O N === As per the Tiles Defini

tiles-definition - role association issue

Hi, I know this is not a correct place to post this message. But I didn't get any response for this question in User Mailing list. Kindly provide me some inputs on my question. Regards, Ashutosh Q U E S T I O N === As per the Tiles Defini

RE: Proposed Action base class change

Hi, Frank. I do not agree. While in most cases it is desireable to see inside a bean (hence I created my public static String toString(Object bean) method), there are times when I just have to make sure a bean is not just equal but the same instance. The java.lang.Object.toString() meth

Re: Proposed Action base class change

That's a good point Mike, I didn't think of that. You might have changed MY mind on this! I'll have to think about it a little more, but you raise a solid issue. -- Frank W. Zammetti Founder and Chief Software Architect Omnytex Technologies http://www.omnytex.com Mike Stanley wrote: I'm -1 on

Re: Proposed Action base class change

Hi Niall, I certainly agree it would not be possible to satisfy everyone, but seeing as the intrinsic toString() is all but useless (and people do generally expect that to be the case with many classes), why not give an implementation that is of at least some use to some people? Surely it woul

Re: Separate Lists for Wiki & Commits?

-1 - use filters. (but my vote is just opinion and has no real weight) - Mike On Wed, 2004-10-06 at 23:52, James Mitchell wrote: > I am also -1 on this. Why should I have to subscribe to so many lists? > > > > -- > James Mitchell > Software Engineer / Open Source Evangelist > EdgeTech, Inc.

Re: Proposed Action base class change

I'm -1 on this. By default, I think the ActionForms toString should be the default Object.toString. If you need/desire you can easily still create a base support class for your projects that implement the reflection based toString you suggest. The reason I'm anti- this is that it will cause

RE: Proposed Action base class change

Hi, Frank. I created a similar method, but rather a static one than a member method. So mine is in a class called BeanUtil (not the apache commons beanutils) and applicable to any other java bean. No need to modify the base class or whatever. So I can apply it on FormBeans as well as servletReq

DO NOT REPLY [Bug 31299] - Refactor RequestUtils to allow subclassing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Separate Lists for Wiki & Commits?

Hi Martin, You make a good point - although I'd probably prefer a digest version of those kinds of events... However having said that I didn't mean it to turn into a controversial issue and was really just making an enquiry. So from my point of view the issue is now dead and I yield to the mor