Fixed the build

2008-12-21 Thread Don Brown
I fixed the builds running at http://opensource.bamboo.atlassian.com/browse/STRUTS The problem was a Maven 1 repository in there that was causing Maven to, for some reason, not try all the repositories when looking for a dependency. For now, I just commented out that repository and we'll see what

Re: java tags proposal

2008-12-21 Thread James Holmes
Agreed on keeping simple theme to just the HTML-based tags. On Sun, Dec 21, 2008 at 10:30 AM, Musachy Barroso wrote: > yes I agree with James, we can do that in 2.2 after some testing is > done. Also, not all tags in the simple theme are implemented. I didn't > implement the ones that have javas

Re: Dojo plugin proposal(my last one I promise)

2008-12-21 Thread Ian Roughley
A few people have tried, but this was some time ago. I can't remember the problems right now, other than it was non-trivial. I agree with Martin that we shouldn't just dump the code expecting that someone else looks after it. Although, other than Musachy, I'm not aware of any of the committers wo

Re: [OSS Bamboo] Struts 2 SVN - Main Build build 973 has FAILED (0 tests failed). Change made by Nils-Helge Garli Hegvik

2008-12-21 Thread Nils-Helge Garli Hegvik
Argh... I'm getting tired of this failure On Sun, Dec 21, 2008 at 8:30 PM, wrote: > STRUTS-MAIN-973 failed. > Code has been updated by Nils-Helge Garli Hegvik. > No failed tests found, a possible compilation error. > Code Changes See full change details > Nils-Helge Garli Hegvik > WW-2720 Ad

Re: xwork ConfigurationProvider

2008-12-21 Thread Musachy Barroso
I committed my changes, rv#728469. To enable auto reloading set: @Blake: take a look at the changes, I think you might be able to do the same thing with CodeBehind, also the ClassLoader classes that I took from JCI are self contained (after a few mods), so you can lift them also. musachy On

Re: xwork ConfigurationProvider

2008-12-21 Thread Blake Byrnes
Cool stuff. I've been playing with the Struts 2 javarebel plugin to try to get it to load individual configuration changes using codebehind. It's nearly impossible to weave into the current setup, so you have to just reload the whole configuration. The framework will load anything registered as a

Re: xwork ConfigurationProvider

2008-12-21 Thread Musachy Barroso
just for reference, the only way I found to register a ConfigurationProvider in a plugin was registering a Dispatcher Listener, and then adding the ConfigurationProvider to the Configuration manager instace in the dispatcher, not very elegant, but that's all I got. As a side note, I used this plus

Re: java tags proposal

2008-12-21 Thread Musachy Barroso
yes I agree with James, we can do that in 2.2 after some testing is done. Also, not all tags in the simple theme are implemented. I didn't implement the ones that have javascript and are not just wrappers around html, like the optionstransferselect. These tags shouldn't be in the simple theme, IMO.

Re: tiles and portlet tickets

2008-12-21 Thread Musachy Barroso
I moved them to 2.1.4 On Sun, Dec 21, 2008 at 7:57 AM, Nils-Helge Garli Hegvik wrote: > I've been looking at the issues, WW-2749 and WW-2682. They both have > patches applied, but I'm not sure what to do with them, because both > would mean a coupling between the portlet and the tiles plugin. And

Re: java tags proposal

2008-12-21 Thread Don Brown
That's fine, I just think we should have an agreed-upon, documented strategy for Struts users and developers. Doing an 'svn move' is pretty easy - creating a migration strategy, documenting it, writing tests to ensure the transition goes smoothly, keeping on top of bugs, etc, there are the tricky

Re: tiles and portlet tickets

2008-12-21 Thread Nils-Helge Garli Hegvik
I've been looking at the issues, WW-2749 and WW-2682. They both have patches applied, but I'm not sure what to do with them, because both would mean a coupling between the portlet and the tiles plugin. And since I don't use Tiles with portlets, and I probably won't, I agree that we postpone these i

Re: java tags proposal

2008-12-21 Thread Nils-Helge Garli Hegvik
Didn't we have a discussion earlier on extracting the base tags into a plugin? Is that still something to consider? Nils-H On Sun, Dec 21, 2008 at 1:29 PM, Don Brown wrote: > Neat, I'm glad to see work finally being done on the tags. What > exactly would this mean for 2.1 and 2.2? Would this b

Re: java tags proposal

2008-12-21 Thread James Holmes
In my opinion the Java-tags should ultimately become the default in say 2.2 or 2.3, but for now they should be a "supported, experimental" plugin packaged with core. I say that because I think it's a little early to have them replace the time-tested FreeMarker-based tags. If we can get them out in

Re: java tags proposal

2008-12-21 Thread Don Brown
Neat, I'm glad to see work finally being done on the tags. What exactly would this mean for 2.1 and 2.2? Would this be the default template engine for the tags? Will the documentation need to be rewritten? How do we keep the engines in sync if we keep the freemarker and velocity engines around?