Re: [VOTE] - Struts2 Portlet Archetype 2.1.6

2009-04-23 Thread Musachy Barroso
+1 GA I created an app with it and ran it embedded in pluto, and it works as expected. musachy On Thu, Apr 23, 2009 at 4:22 PM, Nils-Helge Garli Hegvik wrote: > Okey, giving this another shot! > > The Struts 2 Portlet Archetype 2.1.6 is ready for testing. To test it, > point Maven 2 to the stag

[VOTE] - Struts2 Portlet Archetype 2.1.6

2009-04-23 Thread Nils-Helge Garli Hegvik
Okey, giving this another shot! The Struts 2 Portlet Archetype 2.1.6 is ready for testing. To test it, point Maven 2 to the staging repository and follow the documentation at http://cwiki.apache.org/confluence/display/WW/Struts+2+Maven+Archetypes Maven 2 staging repository: http://people.apache.o

Re: [VOTE] - Struts2 Portlet Archetype 2.1.6

2009-04-23 Thread Nils-Helge Garli Hegvik
I'm taking this vote down due to some signing issues. I'll create a new proper release and open a new vote. No votes has been registered. Nils-H On Tue, Apr 21, 2009 at 12:13 AM, Nils-Helge Garli Hegvik wrote: > Okey, this is my first vote thread, so please bear with me and correct > me if I'm d

Re: [OSS Bamboo] Struts 2 SVN - Main Build build 1103 was SUCCESSFUL (with 1005 tests). Change made by Wes Wannemacher

2009-04-23 Thread Musachy Barroso
meh :) musachy On Thu, Apr 23, 2009 at 2:41 PM, Wes Wannemacher wrote: > Musachy, if you break Bamboo one more time, I'm going to quit fixing it! :-D > > -Wes > > On Thu, Apr 23, 2009 at 2:37 PM,   wrote: >> STRUTS-MAIN-1103 was successful. >> Code has been updated by Wes Wannemacher. >> 1005 te

Re: [OSS Bamboo] Struts 2 SVN - Main Build build 1103 was SUCCESSFUL (with 1005 tests). Change made by Wes Wannemacher

2009-04-23 Thread Wes Wannemacher
Musachy, if you break Bamboo one more time, I'm going to quit fixing it! :-D -Wes On Thu, Apr 23, 2009 at 2:37 PM, wrote: > STRUTS-MAIN-1103 was successful. > Code has been updated by Wes Wannemacher. > 1005 tests in total. > Code Changes See full change details > Wes Wannemacher > adding profi

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
That's perfect, I have added a profile and look for a property called skipAssembly... I'm going to check the wiki and see where to put info on it. Once I update the doco, I'll commit it. -Wes On Thu, Apr 23, 2009 at 2:02 PM, Wendy Smoak wrote: > On Thu, Apr 23, 2009 at 10:53 AM, Musachy Barroso

Re: Moving struts assembly to a profile

2009-04-23 Thread Wendy Smoak
On Thu, Apr 23, 2009 at 10:53 AM, Musachy Barroso wrote: > The easiest thing we can do is to keep everything in by default, so > releases are easy. And just add a profile that excludes assembly, that > should work for everyone. If it's in the list of modules in the default build, you can't get ri

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
yep, agreed, I'll do it right now -Wes On Thu, Apr 23, 2009 at 1:53 PM, Musachy Barroso wrote: > The easiest thing we can do is to keep everything in by default, so > releases are easy. And just add a profile that excludes assembly, that > should work for everyone. > > musachy > > On Thu, Apr 23

Re: Moving struts assembly to a profile

2009-04-23 Thread Musachy Barroso
The easiest thing we can do is to keep everything in by default, so releases are easy. And just add a profile that excludes assembly, that should work for everyone. musachy On Thu, Apr 23, 2009 at 1:24 PM, Wes Wannemacher wrote: > I can live with that, but you might have to help set it up... I d

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
I can live with that, but you might have to help set it up... I don't know how to do an activation outside of a profile. Right now, assembly is a module invoked when you run 'mvn install' from the top-level. Do you mind setting it up so that we have a property, when defined, skips the assembly phas

Re: Moving struts assembly to a profile

2009-04-23 Thread Wendy Smoak
On Thu, Apr 23, 2009 at 9:42 AM, Wes Wannemacher wrote: > I'm not moving it to a plugin, I was going to move it to a profile. Sorry, typo. :) I meant 'profile'. > I was testing a simple change (you can see below). Basically, 'mvn clean > install' will build everything and install it all into yo

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
I'm not moving it to a plugin, I was going to move it to a profile. I was testing a simple change (you can see below). Basically, 'mvn clean install' will build everything and install it all into your ~/.m2/repo But, if you do 'mvn -Pall,assembly clean install' it will also build the zips. The pr

Re: Moving struts assembly to a profile

2009-04-23 Thread Musachy Barroso
that's an excellent idea. musachy On Thu, Apr 23, 2009 at 12:32 PM, Wendy Smoak wrote: > On Thu, Apr 23, 2009 at 5:52 AM, Wes Wannemacher wrote: > >> Unless someone can raise a decent reason not to do it, I'd like to >> move the assembly in the struts2 build into it's own profile. I don't >> mi

Re: Moving struts assembly to a profile

2009-04-23 Thread Wendy Smoak
On Thu, Apr 23, 2009 at 5:52 AM, Wes Wannemacher wrote: > Unless someone can raise a decent reason not to do it, I'd like to > move the assembly in the struts2 build into it's own profile. I don't > mind Hudson and Bamboo creating the zips through the assembly module, > but I like to keep up-to-d

Re: Moving struts assembly to a profile

2009-04-23 Thread Musachy Barroso
yeah that is fine Wes. When we re-organized the poms to make it easier to build, we said we could add profiles later. When you change it, please update the wiki that describes the release process. musachy On Thu, Apr 23, 2009 at 9:41 AM, Wes Wannemacher wrote: > On Thu, Apr 23, 2009 at 9:30 AM,

Re: about OGNL and parameter binding

2009-04-23 Thread Musachy Barroso
Not yet, the MVEL stuff is pretty much a draft at this moment. We could roll this in 2 steps, first stop using OGNL for parameter binding, and then, plugin MVEL. After #1 is achieve, #2 should be easy. The good thing is that the new parameter binding implementation can be turned on/off with a const

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
On Thu, Apr 23, 2009 at 9:30 AM, Rainer Hermanns wrote: > Wes, > > +42, please do so... that was disturbing me as well a lot :) > The build takes currently "forever", just to download all the docs. > > Thanks, > Rainer > Yeah, when it's hudson pulling docs from apache hardware to apache hardware,

Re: Moving struts assembly to a profile

2009-04-23 Thread Rainer Hermanns
Wes, +42, please do so... that was disturbing me as well a lot :) The build takes currently "forever", just to download all the docs. Thanks, Rainer > Hey guys, > > Unless someone can raise a decent reason not to do it, I'd like to > move the assembly in the struts2 build into it's own profile.

Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
Hey guys, Unless someone can raise a decent reason not to do it, I'd like to move the assembly in the struts2 build into it's own profile. I don't mind Hudson and Bamboo creating the zips through the assembly module, but I like to keep up-to-date and running mvn clean install -Pall on my machine t