Re: svn commit: r1228497 - /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/config/impl/ActionConfigMatcher.java

2012-01-07 Thread John Lindal
No, because convertParam expands the wildcard expression :) John On Jan 7, 2012, at 11:58 AM, Łukasz Lenart wrote: Wouldn't be better to first check if it's an allowed-method and then call convertParam() method ? if (!orig.isAllowedMethod(methodName)) { return null; } String methodName =

Re: strict DMI

2012-01-06 Thread John Lindal
I created a ticket for this: https://issues.apache.org/jira/browse/WW-3740 John On Jan 4, 2012, at 12:00 PM, Andreas Sachs wrote: Hi John, thanks for the clarification. But to come back to my original question: Why is not available for wildcard method invocation? Even you expected that it

Re: strict DMI

2012-01-04 Thread John Lindal
The wildcard support is limited to *, since (Method1|Method2|Method3) is actually a regex, not a wildcard. I agree that allowed-methods ought to limit the wildcard matching. Can you file a JIRA ticket for this? Thanks, John On Jan 4, 2012, at 12:00 PM, Andreas Sachs wrote: Hi John, than

Re: strict DMI

2012-01-04 Thread John Lindal
tion: if turned on, methods must be specified (by method-attribute or allowed_method) Thanks Andi Original-Nachricht Datum: Tue, 3 Jan 2012 15:42:50 -0800 Von: John Lindal An: "Struts Developers List" Betreff: Re: strict DMI I think the tag inside an controls bot

Re: strict DMI

2012-01-03 Thread John Lindal
I think the tag inside an controls both. John On Jan 3, 2012, at 2:50 PM, Andreas Sachs wrote: Hi, i like the idea of strict-method-invocation="true" and the possibility to define the allowed methods. I'm just wondering why this is only implemented for DMI and not for wildcard method i

Re: Struts 2.3.1 is coming ...

2011-08-01 Thread John Lindal
OK, I tried my best. Feel free to reword it :) Thanks, John On Jul 29, 2011, at 1:18 AM, Łukasz Lenart wrote: 2011/7/27 John Lindal : How should we mention the new DTD? Good point, some migration explanation with example would be nice. Could you write it ? Thanks in advance -- Łukasz

Re: Struts 2.3.1 is coming ...

2011-07-28 Thread John Lindal
How should we mention the new DTD? John On Jul 27, 2011, at 5:12 AM, Łukasz Lenart wrote: Hi, It's time to start thinking about to release a new version. I've started with Release Notes [1] as this is a major release. Please add your comments or edit it directly. https://cwiki.apache.org/co

Re: Test run into Failure after upgrading to Spring 3.0.5

2011-06-08 Thread John Lindal
I'm seeing this, too, after I just updated from svn, so I think the build in trunk is broken. John On 6/8/11 1:05 PM, "Johannes Geppert" wrote: > Hi all, > > I just try out to set the Spring Dependencies of Struts2 to 3.0.5. > > Index: pom.xml > ==

Modifying Struts DTD

2011-06-08 Thread John Lindal
WW-3264 requires a minor addition to the Struts2 DTD. Is it correct that all I have to do is upload the new version to /www/struts.apache.org/dtds on apache.org? What version number should I use in the new DTD? 2.3.0? Thanks, John --

Re: OGNL Documentation Location?

2011-06-02 Thread John Lindal
Opensymphony.com has a link to Wayback, under Project Websites. It's slow, but it does show the original site. John On 6/2/11 1:08 PM, "Steven Benitez" wrote: > With the recent closure of the OpenSymphony site, does anyone happen to know > where the full OGNL documentation is kept now?

Re: Unit test error for xwork-core in trunk

2011-06-01 Thread John Lindal
+1 John On 6/1/11 11:50 AM, "Maurizio Cucchiara" wrote: > +1 definitely > > Maurizio Cucchiara > > Il giorno 01/giu/2011 20.47, "Lukasz Lenart" > ha scritto: > 2011/6/1 Maurizio Cucchiara : > >> As we noticed, the opensymphony webiste has been shutdown, so the dtd >> is no longer reachable

Unit test error for xwork-core in trunk

2011-05-31 Thread John Lindal
I get “Wrong line number: http://www.opensymphony.com/xwork/xwork-validator-config-1.0.dtd:1:2” from com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest.testParserWithBadXML2() I’m using Maven 2, but I can’t see how that would affect the unit tests. Is anybody else getting this uni

Re: Upgrade Spring Dependencies to 3.0.x

2011-05-31 Thread John Lindal
+1 I've been using Spring 3 with Struts 2 for quite a while now with no problems. John On 5/30/11 9:48 PM, "Johannes Geppert" wrote: > Hi, > > what do you think about upgrading from Spring 2.5.6 dependencies to 3.0.5? > > I use this already in some applications without any trouble. > Maybe

Re: Problem on json result on includeparameter configuration

2011-05-27 Thread John Lindal
This should probably be sent to the user list instead. However, before we can answer your question, please tell us which version of Struts2 you are using and how you are setting the pattern. John On 5/27/11 5:52 AM, "benny" wrote: > I am using hibernate to generate a json object. > my object

Re: Roadmap for 2.3

2011-03-15 Thread John Lindal
interest all of u > > Will blog about this soon > > John, > We got that using the default json, the output gone like blank, the json is > not big, we try geneology tree json model, > > > > > /m/ > > -Original Message- > From: John Lindal

Re: Roadmap for 2.3

2011-03-15 Thread John Lindal
How big is the JSON data that you are parsing? I have heard good reports about Jackson's performance, but we will need to investigate whether it can support all the hooks provided by the current implementation. John On 3/15/11 4:24 AM, "Frans Thamura" wrote: > we find here to implement JSON u

Re: Roadmap for 2.3

2011-03-15 Thread John Lindal
+1 I've actually extended the DTD with additional configuration for security features. The XML is easier to review for errors and ommissions because it is centralized. John On 3/15/11 9:25 AM, "Steven Benitez" wrote: > I love annotations for a lot of things, but I also prefer the XML based >

Re: Road Map for 2.2.2

2011-03-07 Thread John Lindal
Can you explain what you mean by "the current json is not scalable enough"? John On 3/6/11 5:31 AM, "Frans Thamura" wrote: hi all just input, any idea to make a json plugin plugable, we use jackson here, but there is gson, and the current json is not scalable enough we put the source of stru

Re: Content-type returned by JSONInterceptor

2011-03-03 Thread John Lindal
value "2.0" and doesn't use the standard error codes. Adding the jsonrpc element is easy, but changing the errors codes will break backward compatibility. Thoughts? John On 3/3/11 5:07 PM, "Dave Newton" wrote: A search for the json-rpc type seems to return a lot of hits

Content-type returned by JSONInterceptor

2011-03-03 Thread John Lindal
I just noticed that org.apache.struts2.json.JSONUtil.writeJSONToResponse() sets the Content-type to 'application/json-rpc' for RPC responses. Is this really correct? I know browsers understand application/json, but do they understand application/json-rpc? Unless anybody objects, I would like

Re: Road Map for 2.2.2

2011-03-03 Thread John Lindal
WW-3549 sounds very similar to XW-388. Can you check, and close both, if they're duplicates? Thanks, John On 3/2/11 4:05 AM, "Lukasz Lenart" wrote: Hi, I'm going to prepare a new release but before that I want to close the issues below: - WW-3549 Shade common-io from the xwork-core.jar - WW

Re: svn commit: r1065355 - /struts/struts2/trunk/xwork-core/pom.xml

2011-02-14 Thread John Lindal
planning to do with the ticket in the first place. Any objections? John On 2/14/11 7:27 AM, "Maurizio Cucchiara" wrote: On 14 February 2011 16:11, John Lindal wrote: > Try locally reverting the change to xwork-core/pom.xml in ticket XW-388 and > see if it helps. Sure that it helps,

Re: svn commit: r1065355 - /struts/struts2/trunk/xwork-core/pom.xml

2011-02-14 Thread John Lindal
Try locally reverting the change to xwork-core/pom.xml in ticket XW-388 and see if it helps. I'll investigate on my end, too. The strange thing is that the maven-shade-plugin configuration doesn't mention FileExistsException, and I can't find any references to "org.apache.commons.io.xwork" in

Re: Broken web site link

2011-02-12 Thread John Lindal
Urk. All the links under "Modules" are also broken. Did a large chunk get left out of the latest site build of 2.2.2.1? It's there in 2.2.1 and older versions. John On 2/12/11 11:22 AM, "John Lindal" wrote: The link for "Struts Core / XWork APIs"

Broken web site link

2011-02-12 Thread John Lindal
The link for "Struts Core / XWork APIs" is broken on http://struts.apache.org/2.2.1.1/index.html I would fix it, but I can't figure out what it should be pointing to... John

Re: getting the container (or Configuration/ConfigurationManager) in a non-container-instantiated object

2011-02-10 Thread John Lindal
The simplest solution - if it's possible - is to make the spawned thread a parent of the request thread, and then grab what you need from the parent thread as soon as the child thread starts. Does Struts2 use InheritableThreadLocal? If it did, this would be even easier. John On 2/10/11 11:02

Re: XWork maven-shade-plugin configuation

2011-02-04 Thread John Lindal
Since the discussion is pretty quiet, I'll toss out a few more questions. (I don't have any good answers, since I'm pretty new here :) 1) Not huge uptake due to plethora of options--can't reduce the number of options, but can make S2 more appealing. Agreed. Options are good :) I'm not intimat

Re: XWork maven-shade-plugin configuation

2011-02-01 Thread John Lindal
oint? Dave On Tue, Feb 1, 2011 at 11:21 AM, John Lindal wrote: > The reason I don't think io needs to be shaded is because io was never > actually shaded. Lang was being shaded into io, which can't possibly be > right. > > >

Re: XWork maven-shade-plugin configuation

2011-02-01 Thread John Lindal
so there cannot be a struts application without common-io library along its path. [1] https://issues.apache.org/jira/browse/WW-3549 On 30 January 2011 20:30, John Lindal wrote: > In regards to this ticket: > > https://issues.apache.org/jira/browse/XW-388 > > Nothing in

Re: GXP Plugin

2011-01-31 Thread John Lindal
this fixes it. John On 1/31/11 2:04 PM, "Ben McCann" wrote: There's some code missing from the Subversion repository. E.g. the following two directories don't appear to be there: src/main/resources/ src/main/java/com/google/struts/gxp/ On Mon, Jan 31, 2011 at 1:57 P

Re: GXP Plugin

2011-01-31 Thread John Lindal
If you're referring to the pom.xml for building the gxp plugin, then that already has the dependency mentioned in the ticket, at least in trunk. John On 1/31/11 1:52 PM, "Ben McCann" wrote: Hi, I was wondering if someone would be able to check-in the rest of the code for the GXP plugin that I

XWork maven-shade-plugin configuation

2011-01-30 Thread John Lindal
In regards to this ticket: https://issues.apache.org/jira/browse/XW-388 Nothing in the entire Struts2 code base references either org.apache.commons.io.xwork or org.objectweb.asm.xwork. I assume these relocations were intended to be for internal use only? If so, we could significantly redu

Re: Volunteers page

2011-01-27 Thread John Lindal
ete page, in the wrong > location. The location also predates the ASF requirement that dev > pages live only within the dev section of the site. > > Let's just maintain the site we actually want instead of preserving > cruft just because it's there. > > -- > Marti

Re: Volunteers page

2011-01-26 Thread John Lindal
and exploding the output from the build, if that's not working. -- Martin Cooper On Tue, Jan 25, 2011 at 10:58 AM, John Lindal wrote: > Currently, there are two different versions: > > http://struts.apache.org/volunteers.html > http://struts.apache.org/dev/volunteers.html >

Volunteers page

2011-01-25 Thread John Lindal
Currently, there are two different versions: http://struts.apache.org/volunteers.html http://struts.apache.org/dev/volunteers.html The first one is clearly out of date, because the second one matches what is in subversion. Should I add a redirect in .htaccess to point /volunteers.html to /

Re: Displaying intermediate results as they are generated

2011-01-21 Thread John Lindal
If you don't limit yourself to what Struts can do, you could use either XHR (polling for data) or iframes (there is a trick to receive data as it becomes available, without polling). It depends on how comfortable you are with JavaScript. John On 1/21/11 1:12 AM, "Daniel Gerber" wrote: Hi,

Re: svn commit: r1060554 - /struts/site/src/site/xdoc/dev/volunteers.xml

2011-01-18 Thread John Lindal
teers.xml Tue Jan 18 20:13:58 2011 > @@ -183,6 +183,10 @@ limitations under the License. > Maurizio Cucchiara > (mcucchiara at apache.org) > > + > + John Lindal > + (jafl at apache.org) > + > > > > >

Enhancements to JSON plugin

2010-10-14 Thread John Lindal
hide&requestI d=12314570 FWIW, I used to be a contributor to Musachy Barroso's JSON plugin project on googlecode, before it was absorbed into the Struts2 core distribution. Several of the tickets, including the biggest patch (WW-3514), are for the JSON plugi